Received-SPF: pass (google.com: domain of linux-kernel+bounces-2104-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
MIME-Version: 1.0
From: "NeilBrown" <neilb@suse.de>
To: Ahelenia =?utf-8?q?Ziemia=C5=84ska?= <nabijaczleweli@nabijaczleweli.xyz>
Cc: "Trond Myklebust" <trond.myklebust@hammerspace.com>,
 "Anna Schumaker" <anna@kernel.org>, "Chuck Lever" <chuck.lever@oracle.com>,
 "Jeff Layton" <jlayton@kernel.org>, "Olga Kornievskaia" <kolga@netapp.com>,
 "Dai Ngo" <Dai.Ngo@oracle.com>, "Tom Talpey" <tom@talpey.com>,
 "David S. Miller" <davem@davemloft.net>, "Eric Dumazet" <edumazet@google.com>,
 "Jakub Kicinski" <kuba@kernel.org>, "Paolo Abeni" <pabeni@redhat.com>,
 linux-nfs@vger.kernel.org, netdev@vger.kernel.org,
 linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: sunrpc: sizeof('\0') is 4, not 1
In-reply-to:
 <ikgsiev777wvypqueii5mcshrdeftme22stfvztonxbvcrf35l@tarta.nabijaczleweli.xyz>
References: =?utf-8?q?=3C4zlmy3qwneijnrsbygfr2wbsnvdvcgvjyvudqnuxq5zvwmyaof?=
 =?utf-8?q?=40tarta=2Enabijaczleweli=2Exyz=3E=2C?=
 <170270083607.12910.2219100479356858889@noble.neil.brown.name>,
 <ikgsiev777wvypqueii5mcshrdeftme22stfvztonxbvcrf35l@tarta.nabijaczleweli.xyz>
Date: Sat, 16 Dec 2023 16:53:23 +1100
Message-id: <170270600360.12910.7954602598238459243@noble.neil.brown.name>

On Sat, 16 Dec 2023, Ahelenia Ziemia=C5=84ska wrote:
> On Sat, Dec 16, 2023 at 03:27:16PM +1100, NeilBrown wrote:
> > On Sat, 16 Dec 2023, Ahelenia Ziemia=C5=84ska wrote:
> > > To make it self-documenting, the referenced commit added the space
> > > for the null terminator as sizeof('\0'). The message elaborates on
> > > why only one byte is needed, so this is clearly a mistake.
> > > Spell it as 1 /* NUL */ instead.
> > >=20
> > > Fixes: commit 1e360a60b24a ("SUNRPC: Address  buffer overrun in
> > >  rpc_uaddr2sockaddr()")
> > It isn't clear to me that "Fixes" is appropriate as that patch isn't
> > harmful, just confused and sub-optimal.
> I definitely agree, I don't like Fixes here at all,
> but I don't really see another trailer in the documentation
> or in the log that could be used for this.
>=20

Make up a new Trailer?=20

I would probably just write

 To make it self-documenting,
   commit 1e360a60b24a ("SUNRPC: Address  buffer overrun in rpc_uaddr2sockadd=
r()")
 added the space for the null terminator as sizeof('\0') which is 4.  The com=
mit
 elaborates on  why only one byte is needed, so this is clearly a mistake.
 Spell it as 1 /* NUL */ instead.
=20
NeilBrown