Received: by 2002:a05:7412:8d23:b0:f7:29d7:fb05 with SMTP id bj35csp39061rdb; Fri, 15 Dec 2023 22:14:06 -0800 (PST) X-Google-Smtp-Source: AGHT+IFSSOECiKEqRlSMNQ3kuoMLFKAddZf8vZnGP+AZJUW6zKSqm+H4E+5CQ2m9SDLyx19kTctE X-Received: by 2002:a17:902:e54b:b0:1d0:bf4c:166c with SMTP id n11-20020a170902e54b00b001d0bf4c166cmr17216092plf.1.1702707246144; Fri, 15 Dec 2023 22:14:06 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702707246; cv=none; d=google.com; s=arc-20160816; b=pKRYIG9aiHnLsmcy2xgtXzIUPPjGnRb5N+5hwmkDvGmKI6bV3C5H2OpOEJcPpYTSxZ xFvgh94dq8v0RsqhXmHZ8oorpIcTV9B02mIA9i2ul5Isq5iluj1yE5RLqxkloTei9qUl +7yTOyRyTyKU7fYknsc2ZEBqWuwck75u316xmXtVnQHHsA115MHdQhsY/W2ARHdSBhtd 6m1S3CuVH6/bBxrm1rsEFFXDKB8Jp4GPvPwyHrm+BVAurWZStctAgdSK9S8aRP9s4g6R pl/wZ/pq3PQQZE+uNYLzPJxE8WxQ/FwN/f0XCmUxTYzsmBI6K0WnJX4cjpVACMUoIbe4 xqBQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=xTCeiRnVo2DjWRhzmP26oRimtFAuGMuZmVBxfVmUuk0=; fh=TA75Cdh4va7ST6k+VTr9BJ5Kl9bKZJj9tlVUAJvbumY=; b=jyAi++Ukm8SmbYh3D8pmvev6PK2LYa7BaEyC/BcFd/aCsW238+6B2DrQ+P4vQRR1c6 qeoCx9DNW+gLz+kYXJt3PR3Fk3OUVD4eEaBGjX7ZtVsDOKhDKxw0Kp3C80pJDJCOApBo tazobBalcLsOJ3BPQ7w1RSjKH6b4PCgWTc3WnhiwDZ9A+7rv1n8mP8VPxRHiBHdla4g2 4hTs2YcoVWRVPAYjjD8/6jZk1HtjRQlDpS1VI2AS8NxKLT0yHOKSpxf2MRlEKaKdUkLW iBoJoU+gTfQWDB7w8JwDQ6nO9sbVGKDoNrxdD54QZPqWaAOxOa9uivJ7iI+aa6ksPnXc UQMg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=mcxQLRcX; spf=pass (google.com: domain of linux-kernel+bounces-2108-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-2108-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id x18-20020a170902b41200b001cfc2c87fbesi14310894plr.534.2023.12.15.22.14.05 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Dec 2023 22:14:06 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-2108-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=mcxQLRcX; spf=pass (google.com: domain of linux-kernel+bounces-2108-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-2108-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 3FD52B24653 for ; Sat, 16 Dec 2023 06:13:59 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 6E411134AC; Sat, 16 Dec 2023 06:13:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="mcxQLRcX" X-Original-To: linux-kernel@vger.kernel.org Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4E7E412B68; Sat, 16 Dec 2023 06:13:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=xTCeiRnVo2DjWRhzmP26oRimtFAuGMuZmVBxfVmUuk0=; b=mcxQLRcXOnAQa9bcf+QRpJaGbe yka5CwzwHnLt9n6aj9xIiTKol5KUsSWtBTM/kf2SWPCnU/QwgaIlUlVofWhLmxR4Xm38l2RvVMosO duLTjj4rjncA3lGDL8vVGYMqdnxwQ3VTg/EvxqgjVY09sgq0GJCM0a94Z1+7RopZnt+6pId1LHyk3 bTCVIUH5/9F0C5sfgEQDkmJYKFcWUM7CC6UZiatqlgBWchLEDRElBQs1A4jF9GGZPCSPcbpCl7UTH w+uv1+6KpY1mnRy2h/ciT6E5mn+7k4RFlPJkU/rL8fHZ/rWFf7JbTU7b9w+EQf3rvPm+thcgrXJrh Sm9vR33g==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1rENvh-007aiS-1r; Sat, 16 Dec 2023 06:13:41 +0000 Date: Sat, 16 Dec 2023 06:13:41 +0000 From: Matthew Wilcox To: Kent Overstreet Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, tglx@linutronix.de, x86@kernel.org, tj@kernel.org, peterz@infradead.org, mathieu.desnoyers@efficios.com, paulmck@kernel.org, keescook@chromium.org, dave.hansen@linux.intel.com, mingo@redhat.com, will@kernel.org, longman@redhat.com, boqun.feng@gmail.com, brauner@kernel.org Subject: Re: [PATCH 46/50] preempt.h: Kill dependency on list.h Message-ID: References: <20231216024834.3510073-1-kent.overstreet@linux.dev> <20231216033552.3553579-1-kent.overstreet@linux.dev> <20231216033552.3553579-3-kent.overstreet@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231216033552.3553579-3-kent.overstreet@linux.dev> On Fri, Dec 15, 2023 at 10:35:47PM -0500, Kent Overstreet wrote: > - INIT_HLIST_NODE(¬ifier->link); > + /* INIT_HLIST_NODE() open coded, to avoid dependency on list.h */ > + notifier->link.next = NULL; > + notifier->link.pprev = NULL; Arguably INIT_HLIST_NODE() belongs in types.h -- we already have RCUREF_INIT() and ATOMIC_INIT() in there.