Received-SPF: pass (google.com: domain of linux-kernel+bounces-2140-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <89ca6eb2-9a33-c37e-14ae-6181edb8626c@quicinc.com>
Date: Sat, 16 Dec 2023 13:45:14 +0530
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: [PATCH] power: reset: msm: Process register_restart_handler()
 error
Content-Language: en-US
To: Nikita Kiryushin <kiryushin@ancud.ru>, Andy Gross <agross@kernel.org>
CC: Bjorn Andersson <andersson@kernel.org>,
        Konrad Dybcio
	<konrad.dybcio@linaro.org>,
        Sebastian Reichel <sre@kernel.org>,
        Stephen Boyd
	<sboyd@codeaurora.org>,
        Pramod Gurav <pramod.gurav@smartplayin.com>,
        Guenter
 Roeck <linux@roeck-us.net>, <linux-arm-msm@vger.kernel.org>,
        <linux-pm@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <lvc-project@linuxtesting.org>
References: <feeb1a89-59bd-4fd6-81a5-1d828f95b0f0@ancud.ru>
From: Mukesh Ojha <quic_mojha@quicinc.com>
In-Reply-To: <feeb1a89-59bd-4fd6-81a5-1d828f95b0f0@ancud.ru>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit


On 11/8/2023 10:57 PM, Nikita Kiryushin wrote:
> If registering restart handler fails for msm-restart result is not checked.
> It may be irrelevant now (as stated in comment to register_restart_handler,
> the function currently always returns zero), but if the behavior changes
> in the future, an error at registration of handler will be silently 
> skipped.
> 
> Add return error code and print error message too debug log in case of
> non-zero result of register_restart_handler.
> 
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
> 
> Fixes: 18a702e0de98 ("power: reset: use restart_notifier mechanism for 
> msm-poweroff")
> 
> Signed-off-by: Nikita Kiryushin <kiryushin@ancud.ru>
> ---
>   drivers/power/reset/msm-poweroff.c | 7 ++++++-
>   1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/power/reset/msm-poweroff.c 
> b/drivers/power/reset/msm-poweroff.c
> index b9a401bd280b..5877a1ba2778 100644
> --- a/drivers/power/reset/msm-poweroff.c
> +++ b/drivers/power/reset/msm-poweroff.c
> @@ -35,11 +35,16 @@ static void do_msm_poweroff(void)
>    static int msm_restart_probe(struct platform_device *pdev)
>   {
> +    int ret = -EINVAL;

This does not add up anything., no need to initialize.

-Mukesh


>       msm_ps_hold = devm_platform_ioremap_resource(pdev, 0);
>       if (IS_ERR(msm_ps_hold))
>           return PTR_ERR(msm_ps_hold);
>   -    register_restart_handler(&restart_nb);
> +    ret = register_restart_handler(&restart_nb);
> +    if (ret) {
> +        dev_err(&pdev->dev, "unable to register restart handler, %d\n", 
> ret);
> +        return ret;
> +    }
>        pm_power_off = do_msm_poweroff;
>   -- 2.34.1
>