Received-SPF: pass (google.com: domain of linux-kernel+bounces-2175-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Sat, 16 Dec 2023 12:26:02 +0000
From: Conor Dooley <conor@kernel.org>
To: Zhifeng Tang <zhifeng.tang@unisoc.com>
Cc: Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Orson Zhai <orsonzhai@gmail.com>,
	Baolin Wang <baolin.wang@linux.alibaba.com>,
	Chunyan Zhang <zhang.lyra@gmail.com>, linux-clk@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	Zhifeng Tang <zhifeng.tang23@gmail.com>,
	Wenming Wu <wenming.wu@unisoc.com>
Subject: Re: [PATCH 4/4] dt-bindings: clock: Add reset controller bindings
 for Unisoc's UMS512.
Message-ID: <20231216-service-gallows-797dea781edb@spud>
References: <20231215081003.8373-1-zhifeng.tang@unisoc.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="GgSUqh2kPZiHFsMB"
Content-Disposition: inline
In-Reply-To: <20231215081003.8373-1-zhifeng.tang@unisoc.com>


--GgSUqh2kPZiHFsMB
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Dec 15, 2023 at 04:10:03PM +0800, Zhifeng Tang wrote:
> Add Reset Controller bindings to clock bindings for Unisoc's UMS512.

This is what the diff is doing, but there's no justification for why
this is the case. I _assume_ that the clock controller register block
also contains reset bits for some of these peripherals, but the commit
message needs to say that.

Cheers,
Conor.

>=20
> Signed-off-by: Zhifeng Tang <zhifeng.tang@unisoc.com>
> ---
>  Documentation/devicetree/bindings/clock/sprd,ums512-clk.yaml | 3 +++
>  1 file changed, 3 insertions(+)
>=20
> diff --git a/Documentation/devicetree/bindings/clock/sprd,ums512-clk.yaml=
 b/Documentation/devicetree/bindings/clock/sprd,ums512-clk.yaml
> index 43d2b6c31357..6b0892d637fe 100644
> --- a/Documentation/devicetree/bindings/clock/sprd,ums512-clk.yaml
> +++ b/Documentation/devicetree/bindings/clock/sprd,ums512-clk.yaml
> @@ -34,6 +34,9 @@ properties:
>    "#clock-cells":
>      const: 1
> =20
> +  "#reset-cells":
> +    const: 1
> +
>    clocks:
>      minItems: 1
>      maxItems: 4
> --=20
> 2.17.1
>=20

--GgSUqh2kPZiHFsMB
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZX2XWgAKCRB4tDGHoIJi
0kiJAP43JtrM14++P35LKrXG5klsr/OJjlApZw7S1S0MkmbavgD/QuEZ0BzUaDvP
ONpLEnqB2jvHnLpzkb58PHDSqhgQBgk=
=clIu
-----END PGP SIGNATURE-----

--GgSUqh2kPZiHFsMB--