Received: by 2002:a05:7412:8d23:b0:f7:29d7:fb05 with SMTP id bj35csp329361rdb; Sat, 16 Dec 2023 09:48:17 -0800 (PST) X-Google-Smtp-Source: AGHT+IHgNdIU6Zs9EX7U2VV3OMgn/2GWk1ubZAafVAeIa8ZTQdGQ4mGfzE74C+xBnn84/PBmN3wP X-Received: by 2002:a05:6870:9110:b0:203:c7a:618a with SMTP id o16-20020a056870911000b002030c7a618amr8629076oae.94.1702748897263; Sat, 16 Dec 2023 09:48:17 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702748897; cv=none; d=google.com; s=arc-20160816; b=eHOHyXqM8ph4MhVXjCmVDhkdeWodGq9xEojagfdcjf7XCH5wAKzoFIj6cbF1DWD8L7 /7T3Siw591KMJ96SuS+xv+CUP8c7XCy/h9g92RPh9RN7VhVvJ3wXpLQhTK9CeQZU4wOE TpZXm9/OVVILPfcfr1OJsv1fi6BguMD/kuEi5PN9yPTQPhKU7fvCtuV62d/OlccvaQZ2 a16t1R1duRRVe83lspjxTkcygHunSr00s1bd/ynRqX9bqZYZ3w13e1C8g8V7WdRLOEbf 74lnpokaYe9+WIAx1VYHm0UqYPx4VtlvYemwvPkUWUfvdsMVhSJc1BuYVpQ4tfzQg6mN 8XKA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:user-agent:date :message-id:organization:from:references:cc:to:subject; bh=OlLNRTIoOshLV8v20cl/BWyI+cnBx8MdUXcYBqIR8e0=; fh=2RsYFHEIGT6SdwVMn2Fr/vWWtVyxDK3oO9pDiUb5rTA=; b=N/VpVqeDvQEJfva3GIuC1iIc1WTh2UUrAYrU3ZUe7UdGVCz848m23Y+Q/+7WgYI8Bi 4tEDkkz0YqPv3Grr7pdlpMtrKSWspbr5yhK0V0Q5WS08OsqbbbAxSfPEfJ8Xak+oK0BL EJYmr9KCeKT6t1Wgrgx5SndC5a+F5Aj7gbxuc82jf5tit13/Y55WOiFHwiiZagtpi6Ws Yo5wR/iN5YQr22L46yrHa+HXMUU7HOHz8wo3XPXnY7DIKv2oGmKFxCLybshNAMakfHea /T8sNPHtDT1aHD9gSH2lWUKdt33lVUgaU+d2PEf+gNzFCadA9S/sgKiJRTdvbul7sjFF sTGA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-2303-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-2303-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id i11-20020a17090adc0b00b0028b4a11c68csi421883pjv.0.2023.12.16.09.48.16 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 16 Dec 2023 09:48:17 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-2303-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-2303-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-2303-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id DD34A285E81 for ; Sat, 16 Dec 2023 17:48:16 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id A85823158A; Sat, 16 Dec 2023 17:48:08 +0000 (UTC) X-Original-To: linux-kernel@vger.kernel.org Received: from mx01.omp.ru (mx01.omp.ru [90.154.21.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 768673159D; Sat, 16 Dec 2023 17:48:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=omp.ru Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=omp.ru Received: from [192.168.1.104] (31.173.82.73) by msexch01.omp.ru (10.188.4.12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.2.1258.12; Sat, 16 Dec 2023 20:47:56 +0300 Subject: Re: [PATCH net-next v2 14/21] net: ravb: Simplify ravb_suspend() To: Claudiu , , , , , , , , , CC: , , , Claudiu Beznea References: <20231214114600.2451162-1-claudiu.beznea.uj@bp.renesas.com> <20231214114600.2451162-15-claudiu.beznea.uj@bp.renesas.com> From: Sergey Shtylyov Organization: Open Mobile Platform Message-ID: Date: Sat, 16 Dec 2023 20:47:55 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 In-Reply-To: <20231214114600.2451162-15-claudiu.beznea.uj@bp.renesas.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: msexch01.omp.ru (10.188.4.12) To msexch01.omp.ru (10.188.4.12) X-KSE-ServerInfo: msexch01.omp.ru, 9 X-KSE-AntiSpam-Interceptor-Info: scan successful X-KSE-AntiSpam-Version: 6.1.0, Database issued on: 12/16/2023 17:34:33 X-KSE-AntiSpam-Status: KAS_STATUS_NOT_DETECTED X-KSE-AntiSpam-Method: none X-KSE-AntiSpam-Rate: 59 X-KSE-AntiSpam-Info: Lua profiles 182146 [Dec 15 2023] X-KSE-AntiSpam-Info: Version: 6.1.0.3 X-KSE-AntiSpam-Info: Envelope from: s.shtylyov@omp.ru X-KSE-AntiSpam-Info: LuaCore: 7 0.3.7 6d6bf5bd8eea7373134f756a2fd73e9456bb7d1a X-KSE-AntiSpam-Info: {rep_avail} X-KSE-AntiSpam-Info: {Tracking_from_domain_doesnt_match_to} X-KSE-AntiSpam-Info: {relay has no DNS name} X-KSE-AntiSpam-Info: {SMTP from is not routable} X-KSE-AntiSpam-Info: {Found in DNSBL: 31.173.82.73 in (user) b.barracudacentral.org} X-KSE-AntiSpam-Info: 127.0.0.199:7.1.2;31.173.82.73:7.1.2;omp.ru:7.1.1;d41d8cd98f00b204e9800998ecf8427e.com:7.1.1 X-KSE-AntiSpam-Info: ApMailHostAddress: 31.173.82.73 X-KSE-AntiSpam-Info: {DNS response errors} X-KSE-AntiSpam-Info: Rate: 59 X-KSE-AntiSpam-Info: Status: not_detected X-KSE-AntiSpam-Info: Method: none X-KSE-AntiSpam-Info: Auth:dmarc=temperror header.from=omp.ru;spf=temperror smtp.mailfrom=omp.ru;dkim=none X-KSE-Antiphishing-Info: Clean X-KSE-Antiphishing-ScanningType: Heuristic X-KSE-Antiphishing-Method: None X-KSE-Antiphishing-Bases: 12/16/2023 17:40:00 X-KSE-Antivirus-Interceptor-Info: scan successful X-KSE-Antivirus-Info: Clean, bases: 12/16/2023 2:57:00 PM X-KSE-Attachment-Filter-Triggered-Rules: Clean X-KSE-Attachment-Filter-Triggered-Filters: Clean X-KSE-BulkMessagesFiltering-Scan-Result: InTheLimit On 12/14/23 2:45 PM, Claudiu wrote: > From: Claudiu Beznea > > As ravb_close() contains now the call to ravb_ptp_stop() for both ccc_gac > and gPTP aware platforms, there is no need to keep the separated call in Separate. > ravb_suspend(). Instead, move it to ravb_wol_setup(). In this way the > resulting code is cleaner. > > Signed-off-by: Claudiu Beznea Reviewed-by: Sergey Shtylyov [...] MBR, Sergey