Received-SPF: pass (google.com: domain of linux-kernel+bounces-2336-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Sat, 16 Dec 2023 14:09:54 -0500
From: Kent Overstreet <kent.overstreet@linux.dev>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	linux-fsdevel@vger.kernel.org, tglx@linutronix.de, x86@kernel.org,
	tj@kernel.org, peterz@infradead.org, mathieu.desnoyers@efficios.com,
	paulmck@kernel.org, keescook@chromium.org,
	dave.hansen@linux.intel.com, mingo@redhat.com, will@kernel.org,
	longman@redhat.com, boqun.feng@gmail.com, brauner@kernel.org
Subject: Re: [PATCH 26/50] rslib: kill bogus dependency on list.h
Message-ID: <20231216190954.vjcgab7ttfrqk522@moria.home.lan>
References: <20231216024834.3510073-1-kent.overstreet@linux.dev>
 <20231216032957.3553313-1-kent.overstreet@linux.dev>
 <20231216032957.3553313-5-kent.overstreet@linux.dev>
 <5a5daf77-ba00-49db-a963-e343a0b2b8cf@infradead.org>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <5a5daf77-ba00-49db-a963-e343a0b2b8cf@infradead.org>

On Sat, Dec 16, 2023 at 11:05:08AM -0800, Randy Dunlap wrote:
> 
> 
> On 12/15/23 19:29, Kent Overstreet wrote:
> > list_head is defined in types.h, not list.h - this kills a sched.h
> > dependency.
> > 
> > Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
> > ---
> >  include/linux/rslib.h | 1 -
> >  1 file changed, 1 deletion(-)
> > 
> > diff --git a/include/linux/rslib.h b/include/linux/rslib.h
> > index 238bb85243d3..a04dacbdc8ae 100644
> > --- a/include/linux/rslib.h
> > +++ b/include/linux/rslib.h
> > @@ -10,7 +10,6 @@
> >  #ifndef _RSLIB_H_
> >  #define _RSLIB_H_
> >  
> > -#include <linux/list.h>
> >  #include <linux/types.h>	/* for gfp_t */
> >  #include <linux/gfp.h>		/* for GFP_KERNEL */
> >  
> 
> What about line 47?
> 
>     47		struct list_head list;

It's in types.h.