Received-SPF: pass (google.com: domain of linux-kernel+bounces-2337-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Message-ID: <65c68bf8-c577-4103-ae7e-7871ae276c22@infradead.org>
Date: Sat, 16 Dec 2023 11:10:03 -0800
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 26/50] rslib: kill bogus dependency on list.h
Content-Language: en-US
From: Randy Dunlap <rdunlap@infradead.org>
To: Kent Overstreet <kent.overstreet@linux.dev>,
 linux-kernel@vger.kernel.org, linux-mm@kvack.org,
 linux-fsdevel@vger.kernel.org
Cc: tglx@linutronix.de, x86@kernel.org, tj@kernel.org, peterz@infradead.org,
 mathieu.desnoyers@efficios.com, paulmck@kernel.org, keescook@chromium.org,
 dave.hansen@linux.intel.com, mingo@redhat.com, will@kernel.org,
 longman@redhat.com, boqun.feng@gmail.com, brauner@kernel.org
References: <20231216024834.3510073-1-kent.overstreet@linux.dev>
 <20231216032957.3553313-1-kent.overstreet@linux.dev>
 <20231216032957.3553313-5-kent.overstreet@linux.dev>
 <5a5daf77-ba00-49db-a963-e343a0b2b8cf@infradead.org>
In-Reply-To: <5a5daf77-ba00-49db-a963-e343a0b2b8cf@infradead.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit


On 12/16/23 11:05, Randy Dunlap wrote:
> 
> 
> On 12/15/23 19:29, Kent Overstreet wrote:
>> list_head is defined in types.h, not list.h - this kills a sched.h
>> dependency.
>>
>> Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
>> ---
>>  include/linux/rslib.h | 1 -
>>  1 file changed, 1 deletion(-)
>>
>> diff --git a/include/linux/rslib.h b/include/linux/rslib.h
>> index 238bb85243d3..a04dacbdc8ae 100644
>> --- a/include/linux/rslib.h
>> +++ b/include/linux/rslib.h
>> @@ -10,7 +10,6 @@
>>  #ifndef _RSLIB_H_
>>  #define _RSLIB_H_
>>  
>> -#include <linux/list.h>
>>  #include <linux/types.h>	/* for gfp_t */
>>  #include <linux/gfp.h>		/* for GFP_KERNEL */
>>  
> 
> What about line 47?
> 
>     47		struct list_head list;
> 

I see. :)
it's in types.h, not list.h, as you explained!


-- 
#Randy
https://people.kernel.org/tglx/notes-about-netiquette
https://subspace.kernel.org/etiquette.html