Received-SPF: pass (google.com: domain of linux-kernel+bounces-2345-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Sat, 16 Dec 2023 20:36:50 +0100
From: Pavel Machek <pavel@ucw.cz>
To: Alain Volmat <alain.volmat@foss.st.com>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Sakari Ailus <sakari.ailus@linux.intel.com>,
	Jacopo Mondi <jacopo.mondi@ideasonboard.com>,
	Kieran Bingham <kieran.bingham@ideasonboard.com>,
	Rob Herring <robh@kernel.org>, linux-media@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 3/3] media: i2c: gc2145: Galaxy Core GC2145 sensor
 support
Message-ID: <ZX38UnAvBn45+y0W@duo.ucw.cz>
References: <20231122075154.789431-1-alain.volmat@foss.st.com>
 <20231122075154.789431-4-alain.volmat@foss.st.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="J/MO1rl1fQBm0I5V"
Content-Disposition: inline
In-Reply-To: <20231122075154.789431-4-alain.volmat@foss.st.com>


--J/MO1rl1fQBm0I5V
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi!

> Addition of support for the Galaxy Core GC2145 XVGA sensor.
> The sensor supports both DVP and CSI-2 interfaces however for
> the time being only CSI-2 is implemented.
>=20
> Configurations are currently based on initialization scripts
> coming from Galaxy Core and so for that purpose only 3 static
> resolutions are supported:
>  - 640x480
>  - 1280x720
>  - 1600x1200

Also only limited subset of pixel formats is implemented? Would be
worth mentioning in the changelog, but perhaps comment at the start of
the file would be even better.

> +++ b/drivers/media/i2c/Kconfig
> @@ -50,6 +50,16 @@ config VIDEO_AR0521
>  	  To compile this driver as a module, choose M here: the
>  	  module will be called ar0521.
> =20
> +config VIDEO_GC2145
> +	select V4L2_CCI_I2C
> +	tristate "GalaxyCore GC2145 sensor support"
> +	help
> +	  This is a V4L2 sensor-level driver for GalaxyCore GC2145
> +	  2 Mpixel camera.

Normally tristate would go before select.

Reviewed-by: Pavel Machek <pavel@ucw.cz>

(But you probably want to solve the problems reported by the build
bot).

Thanks and best regards,
							Pavel
--=20
People of Russia, stop Putin before his war on Ukraine escalates.

--J/MO1rl1fQBm0I5V
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iF0EABECAB0WIQRPfPO7r0eAhk010v0w5/Bqldv68gUCZX38UgAKCRAw5/Bqldv6
8rhpAJ96f/a2MmnMxqL586aG7j0Su5XwFACfUliE825R4b4S2aYyg3SopYMo9XU=
=Ymzx
-----END PGP SIGNATURE-----

--J/MO1rl1fQBm0I5V--