Received-SPF: pass (google.com: domain of linux-kernel+bounces-2358-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
From: Zenm Chen <zenmchen@gmail.com>
To: Larry.Finger@lwfinger.net
Cc: Jes.Sorensen@gmail.com,
	kvalo@kernel.org,
	linux-kernel@vger.kernel.org,
	linux-wireless@vger.kernel.org,
	pkshih@realtek.com,
	rtl8821cerfe2@gmail.com,
	zenmchen@gmail.com
Subject: Re: [PATCH v2] wifi: rtl8xxxu: Add additional USB IDs for RTL8192EU
Date: Sun, 17 Dec 2023 04:13:59 +0800
Message-ID: <20231216201359.8176-1-zenmchen@gmail.com>
In-Reply-To: <20231216165259.5389-1-zenmchen@gmail.com>
References: <20231216165259.5389-1-zenmchen@gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

>> On 12/16/23 10:52, Zenm Chen wrote:
>> Add additional USB IDs found in the vendor driver from
>> https://github.com/Mange/rtl8192eu-linux-driver to support more
>> RTL8192EU devices.
>>
>> Signed-off-by: Zenm Chen <zenmchen@gmail.com>
>> ---
>> v2:
>>   - Not to put these USB IDs in CONFIG_RTL8XXXU_UNTESTED
>
> Have you tested all modes including STA, AP, P2P, etc? If not, then your devices
> belong in the CONFIG_RTL8XXXU_UNTESTED section.

You're right, I haven't tested these four devices, so they should be in the 
CONFIG_RTL8XXXU_UNTESTED section.

Please drop this patch, thanks.

>
> I am also not fond of splitting the rtl8192eu devices into several different
> spots in the table. That only makes it harder to see what devices are supported.
>
> NACKed by Larry Finger <Larry.Finger@lwfinger.net>
>
> Larry