Received-SPF: pass (google.com: domain of linux-kernel+bounces-2368-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Date: Sat, 16 Dec 2023 21:06:32 +0000
From: Simon Horman <horms@kernel.org>
To: Edward Adam Davis <eadavis@qq.com>
Cc: davem@davemloft.net, dhowells@redhat.com, edumazet@google.com,
	jarkko@kernel.org, jmorris@namei.org, keyrings@vger.kernel.org,
	kuba@kernel.org, linux-kernel@vger.kernel.org,
	linux-security-module@vger.kernel.org, netdev@vger.kernel.org,
	pabeni@redhat.com, paul@paul-moore.com, serge@hallyn.com,
	syzbot+94bbb75204a05da3d89f@syzkaller.appspotmail.com,
	syzkaller-bugs@googlegroups.com
Subject: Re: [PATCH V2 next] keys/dns: fix slab-out-of-bounds in
 dns_resolver_preparse
Message-ID: <20231216210632.GW6288@kernel.org>
References: <tencent_B0E34B701B7025C7BAFDBB2833BB9EE41B08@qq.com>
 <tencent_7D663C8936BA96F837124A4474AF76ED6709@qq.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <tencent_7D663C8936BA96F837124A4474AF76ED6709@qq.com>

On Thu, Dec 14, 2023 at 10:46:10PM +0800, Edward Adam Davis wrote:
> bin will be forcibly converted to "struct dns_server_list_v1_header *", so it 
> is necessary to compare datalen with sizeof(*v1).
> 
> Fixes: b946001d3bb1 ("keys, dns: Allow key types (eg. DNS) to be reclaimed immediately on expiry")
> Reported-and-tested-by: syzbot+94bbb75204a05da3d89f@syzkaller.appspotmail.com
> Signed-off-by: Edward Adam Davis <eadavis@qq.com>
> ---
>  net/dns_resolver/dns_key.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

This change looks correct to me.
And I agree that it addresses a problem introduced by the cited commit.
I also note that it depends on the cited commit, which is not present in net.

Reviewed-by: Simon Horman <horms@kernel.org>