Received-SPF: pass (google.com: domain of linux-kernel+bounces-2394-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <78ec36c9-5e87-4c83-bdbf-5680f6eaff4c@gmail.com>
Date: Sun, 17 Dec 2023 00:12:18 +0100
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] drm/tiny: print 'struct resource *' correctly
Content-Language: en-US
To: Randy Dunlap <rdunlap@infradead.org>, tzimmermann@suse.de
Cc: javierm@redhat.com, dri-devel@lists.freedesktop.org,
 linux-kernel@vger.kernel.org
References: <20231015131100.331880-1-yussef.dalton@gmail.com>
 <35984b5f-d4f5-4d45-9e17-b41140ff78e0@infradead.org>
From: Yussef Dalton <yussef.dalton@gmail.com>
In-Reply-To: <35984b5f-d4f5-4d45-9e17-b41140ff78e0@infradead.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

On 10/15/23 17:35, Randy Dunlap wrote:
> 
> 
> On 10/15/23 06:11, Yussef Dalton wrote:
>> Since format specifier %pr refers to a 'struct resource *', there is no
>> need to take the address of the 'res' variable since it is already of
>> type 'struct resource *'.
>>
>> Signed-off-by: Yussef Dalton <yussef.dalton@gmail.com>
> 
> Reviewed-by: Randy Dunlap <rdunlap@infradead.org>
> 
> Thanks.
> 
>> ---
>>   drivers/gpu/drm/tiny/ofdrm.c | 4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/tiny/ofdrm.c b/drivers/gpu/drm/tiny/ofdrm.c
>> index 2d999a0facde..6372ab383747 100644
>> --- a/drivers/gpu/drm/tiny/ofdrm.c
>> +++ b/drivers/gpu/drm/tiny/ofdrm.c
>> @@ -1208,13 +1208,13 @@ static struct ofdrm_device *ofdrm_device_create(struct drm_driver *drv,
>>   
>>   	ret = devm_aperture_acquire_from_firmware(dev, fb_pgbase, fb_pgsize);
>>   	if (ret) {
>> -		drm_err(dev, "could not acquire memory range %pr: error %d\n", &res, ret);
>> +		drm_err(dev, "could not acquire memory range %pr: error %d\n", res, ret);
>>   		return ERR_PTR(ret);
>>   	}
>>   
>>   	mem = devm_request_mem_region(&pdev->dev, fb_pgbase, fb_pgsize, drv->name);
>>   	if (!mem) {
>> -		drm_warn(dev, "could not acquire memory region %pr\n", &res);
>> +		drm_warn(dev, "could not acquire memory region %pr\n", res);
>>   		return ERR_PTR(-ENOMEM);
>>   	}
>>   
> 

Hi,

Sorry for the bump, but is there any news on my patch?

Regards,

Yussef