Received: by 2002:a05:7412:8d08:b0:f9:2d0a:d759 with SMTP id bj8csp47306rdb; Sun, 17 Dec 2023 01:23:24 -0800 (PST) X-Google-Smtp-Source: AGHT+IEqcqBBSmss08kqnAXxckhIZi/dYkBDAKqXM8HPoeiTEfWB6yH3JDs2aBeQLyr/4dyeV1wF X-Received: by 2002:a05:620a:460d:b0:77f:38ed:e47 with SMTP id br13-20020a05620a460d00b0077f38ed0e47mr20428673qkb.116.1702805004476; Sun, 17 Dec 2023 01:23:24 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702805004; cv=none; d=google.com; s=arc-20160816; b=G4HE0dJBRUXpdU9QbGpIYqXnk95IEJkPyak7W+glFkUdlKz9m5xhkddWE9/msVtwOR WZxnrO6Mu5ltp4k/Whgk6o63zLEpTZaZ0xN7sWwKjenooLfK4YuH23wX0fmIhlPB0OEu n5BEnxpjE02+AamRcnn/TDlUGoImh7+AJMeW+osVZrx2IFopymuhWyWXiHbQqPhxN0gL 4m9LdxUXone4kdRu5e7dXWIg9vLnjKLiMvKP6onzMxeOr7V00y6nUbDjtrC6L5gDm01B KLYbbbPfxE8Ns9Nv0HLA1f4BlRhIgJf0XIFEIOJ7JEbgvU0CDHbZtNX05eQIbOGXD4NW FTyw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=e2syS5gfOYyTr1CcR6QHmRC/0bl7RHoQ4/8xLhREdX8=; fh=oG7bweP8IWaFLtRAWiiDNwM/Uy9ksCy4A8hSxbvLJdk=; b=xn8Q2og7xXnnuaSm+b12CYYv+3END8G8UQKuWM/miN0/Z4XTQOhb78sKYPo+HzZJE9 d8QJ0kB06oCle6WP6n2XPBbpdTmP0XFqVzgD0jwMcGpozyhGw8NNgWfkB+Y3cP2Iz1y2 8VqoBREqEgqiSrQjMcLgYHbTG+0CP5UjK0tGm7yK5UzX6w7WQ/2WceCSVj0VZbkc4zoZ z7puBbIiXNNN9/BOmexY9UBhiAAjA4HsYq0r47wIvOSZdRJ7fACKl08qWMojBxF8RvWx mzHtG1z2nSong7LtGg98g/EP1hdraIoLCIMkvll5PNaCXIpD57VFa3nTo1T/jVjh+r7t V+Hg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=6Hz6PNrm; spf=pass (google.com: domain of linux-kernel+bounces-2512-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-2512-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id v2-20020a05620a0f0200b0077c0f390186si663880qkl.368.2023.12.17.01.23.24 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 17 Dec 2023 01:23:24 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-2512-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=6Hz6PNrm; spf=pass (google.com: domain of linux-kernel+bounces-2512-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-2512-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 3B12B1C21154 for ; Sun, 17 Dec 2023 09:23:24 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 2BCD31FDC; Sun, 17 Dec 2023 09:23:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="6Hz6PNrm" X-Original-To: linux-kernel@vger.kernel.org Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1D1CF20E4; Sun, 17 Dec 2023 09:23:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lunn.ch DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=e2syS5gfOYyTr1CcR6QHmRC/0bl7RHoQ4/8xLhREdX8=; b=6Hz6PNrmyyEJISORozhhdBYTY3 oCYrHfTrHC5dCh/2oN7MYLlvb4ZNm+Xm+PqdtDqnmj6Nk5iIbgQoGR8P++3zL1823xf/tcyCROb/z 1N+DZzTwvBTiRilx6pjfrflCX0og/+Qudc4vSg1cAgb31CPpqLOw9sRDOgRkyEr2F+/E=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1rEnMM-00399Q-7F; Sun, 17 Dec 2023 10:22:54 +0100 Date: Sun, 17 Dec 2023 10:22:54 +0100 From: Andrew Lunn To: Dimitri Fedrau Cc: Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Stefan Eichenberger , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: phy: marvell-88q2xxx: add driver for the Marvell 88Q2220 PHY Message-ID: <28cc73bf-ed6d-49d8-b80b-4fbf5fa0442f@lunn.ch> References: <20231215213102.35994-1-dima.fedrau@gmail.com> <74d4b8f9-700e-45bc-af59-95a40a777b00@lunn.ch> <20231216221151.GA143483@debian> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231216221151.GA143483@debian> > > > + /* Set IEEE power down */ > > > + ret = phy_write_mmd(phydev, MDIO_MMD_PMAPMD, MDIO_CTRL1, 0x840); > > > > 0x800 is MDIO_CTRL1_LPOWER. What is the other? It seems like a speed > > selection bit? > > > The other is MDIO_PMA_CTRL1_SPEED1000. Will fix this in V2. It seems odd to set a speed, and power it down. But i guess you have blindly copied the reference code, so have no idea why? Andrew