Received: by 2002:a05:7412:8d08:b0:f9:2d0a:d759 with SMTP id bj8csp67600rdb; Sun, 17 Dec 2023 02:30:37 -0800 (PST) X-Google-Smtp-Source: AGHT+IH82lVxlZqYtLVNjVyzRAL9gGzOmFD8MFlA+hbYLlDTM/zyvOJTfuagTv35p22Zc74LI0p1 X-Received: by 2002:a05:600c:524e:b0:40b:5e1e:b3b3 with SMTP id fc14-20020a05600c524e00b0040b5e1eb3b3mr8141418wmb.49.1702809036992; Sun, 17 Dec 2023 02:30:36 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702809036; cv=none; d=google.com; s=arc-20160816; b=NmjGCna99B2whraSQ+OOhnbFVOU7z5PAgzAX6VHGMsU4qI9+QbXMTpT2ISskmxYNk8 zAlpEivoRPjGd1TiFe1kluAxptv8Wv9Rg6R7SgG0S3m9gebb5BZja5ZcihGComi270L6 SbXyTqQJ64y92UdjoEnY/f589V+iPdbxc148Gt45AecLsxqoSlkwSZ5fdxJtRsiy0GeR nNmi8bSBl1p3omQDMp932iUzYYXxRRse9JyxXmHctnnlYrrNttqLpN6FuKWLgJefHbAf 3Hq0rfroyAnJgIpiQb5mpIgQk0u+p9TIURXAPSH9TQs+mCt8oy0H0PDlviVwljoD2xL1 91Ww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:feedback-id:dkim-signature:dkim-signature; bh=1pTTxU/VbzAm0lsOewvACvD5yOw657Fm5X2fzaBqO2I=; fh=29+NP+Avo3KW5WAFiPrv+jdOjQZBDMQJMXZlHI+I9m4=; b=Pc93eAd8JIgqe8jCVs/0dvsmHwLuTvSltboQpCaBdAGgZJAOajwckSUZxvVhq7rsfx c0aw/qcRr5JV4xj+nZVghKZonJVYnSPV7eWn8dzRqNwAJh6I/dsFZuA+xYUQqQs73lu4 p3GisbLoedRpENRF9ZDw+QEbLKM7+gZI2g81uhOOT3JETlZl1lgWHIoYnDGY7Rfujivm yfdhmlEoOic6Y90YERs+j7kFGbNkV4/BzM4AB0yKBwpoZw9l/Yujw66zf38LOghveFYv bL2TkLiHeZwOU7BxcMJdZPrsJFL+07YtLcoDAEvFPv0iXN1YWukV5xNckO+kBn2gdXfx SdEQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@sakamocchi.jp header.s=fm2 header.b=svQuyeIP; dkim=pass header.i=@messagingengine.com header.s=fm2 header.b=GcoZR86Y; spf=pass (google.com: domain of linux-kernel+bounces-2526-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-2526-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=sakamocchi.jp Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id v7-20020a170906180700b00a1d551f6324si9274830eje.355.2023.12.17.02.30.36 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 17 Dec 2023 02:30:36 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-2526-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@sakamocchi.jp header.s=fm2 header.b=svQuyeIP; dkim=pass header.i=@messagingengine.com header.s=fm2 header.b=GcoZR86Y; spf=pass (google.com: domain of linux-kernel+bounces-2526-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-2526-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=sakamocchi.jp Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id B357D1F21FEB for ; Sun, 17 Dec 2023 10:30:36 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 69B036FC5; Sun, 17 Dec 2023 10:30:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=sakamocchi.jp header.i=@sakamocchi.jp header.b="svQuyeIP"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="GcoZR86Y" X-Original-To: linux-kernel@vger.kernel.org Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 22FAE63DA for ; Sun, 17 Dec 2023 10:30:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sakamocchi.jp Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sakamocchi.jp Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id E569F5C00C7; Sun, 17 Dec 2023 05:30:18 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Sun, 17 Dec 2023 05:30:18 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sakamocchi.jp; h=cc:cc:content-transfer-encoding:content-type:date:date:from :from:in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to; s=fm2; t=1702809018; x= 1702895418; bh=1pTTxU/VbzAm0lsOewvACvD5yOw657Fm5X2fzaBqO2I=; b=s vQuyeIPK92jI1h59xHID4x1M1mY9Jc9uN0hTwfyXRUs9hkZgsDQVl7oA/tkOjAKA sxrTf4XLGx685gMpiAhLuzex0rCYuZX7VLq5hSnZzEfVmS08XfqjYQHS/hLg2Vm7 zISRUal77Dkt8EWpYbv7vdXTcOiqfalyXJytI+Wc79QcE1LK9gJUa+3NJg6DzXPG IDiuZ8MX3h2O+gCGr2nKou3fkfgwmiwJyLEWvxSWO7PIXBeUZMmXs7LoX94OCRN+ GIqp+tHB8l4Rq1FLwEL7yEtruY3K+S3a2fNlop2qQ0HLtjK0mACpszPPrU7MlG4e jBf/Y+mpKmzf/qaAQOatg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1702809018; x= 1702895418; bh=1pTTxU/VbzAm0lsOewvACvD5yOw657Fm5X2fzaBqO2I=; b=G coZR86YNxYWIDNJxbKMR78//htusgLWPBhH6Iyg+Mgmiewk/fie4rsvi6EzOalW1 e+agUOJdeRXHoLQI9oclEVAzDmsxcc9g77+WbdQfj2vK6PcINGXVNFpeEarGRJmT 9TZID/PR++LQXVDbWlQqoYq2M/xp06aKbRmyrKvqDX5zJ0eXvAOtLI26FSyNj4M1 4qln2tEtaou5MCTD7tcVvzpBUZem0icJvXX4pyxT7rv3pCC3U6jMtFfwWJi4Rd1m Nnoeln/N1M5oPf8JWmh4AL535/mLXExobh7sFXoEqS2pkbQYs41qgycjoGhfEcBa WF0htMEfEZNzAHGMyaEdg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrvddtiedgudehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhvfevufffkffojghfggfgsedtke ertdertddtnecuhfhrohhmpefvrghkrghshhhiucfurghkrghmohhtohcuoehoqdhtrghk rghshhhisehsrghkrghmohgttghhihdrjhhpqeenucggtffrrghtthgvrhhnpedvjefgje euvdfguddukeelveetgfdtvefhtdfffeeigfevueetffeivdffkedvtdenucevlhhushht vghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehoqdhtrghkrghshhhise hsrghkrghmohgttghhihdrjhhp X-ME-Proxy: Feedback-ID: ie8e14432:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 17 Dec 2023 05:30:17 -0500 (EST) From: Takashi Sakamoto To: linux1394-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org Cc: adamg@pobox.com Subject: [RFC PATCH 1/8] firewire: core: adds constant qualifier for local helper functions Date: Sun, 17 Dec 2023 19:30:04 +0900 Message-Id: <20231217103012.41273-2-o-takashi@sakamocchi.jp> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20231217103012.41273-1-o-takashi@sakamocchi.jp> References: <20231217103012.41273-1-o-takashi@sakamocchi.jp> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Some local functions just handles given argument as mutable, thus it is preferable to add constant qualifier to them. Signed-off-by: Takashi Sakamoto --- drivers/firewire/core-device.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/firewire/core-device.c b/drivers/firewire/core-device.c index aa597cda0d88..16c32cb38f0f 100644 --- a/drivers/firewire/core-device.c +++ b/drivers/firewire/core-device.c @@ -171,7 +171,7 @@ static const struct ieee1394_device_id *unit_match(struct device *dev, return NULL; } -static bool is_fw_unit(struct device *dev); +static bool is_fw_unit(const struct device *dev); static int fw_unit_match(struct device *dev, struct device_driver *drv) { @@ -679,7 +679,7 @@ static struct device_type fw_unit_type = { .release = fw_unit_release, }; -static bool is_fw_unit(struct device *dev) +static bool is_fw_unit(const struct device *dev) { return dev->type == &fw_unit_type; } @@ -838,7 +838,7 @@ static struct device_type fw_device_type = { .release = fw_device_release, }; -static bool is_fw_device(struct device *dev) +static bool is_fw_device(const struct device *dev) { return dev->type == &fw_device_type; } -- 2.39.2