Received: by 2002:a05:7412:8d08:b0:f9:2d0a:d759 with SMTP id bj8csp90364rdb; Sun, 17 Dec 2023 03:49:38 -0800 (PST) X-Google-Smtp-Source: AGHT+IG+A28GVo2pgivsh3X006VMGZCj+tpBWAAftq/sKnygd0NXhQ5Khhro7490J6KuP6hzhSv/ X-Received: by 2002:a17:906:74c8:b0:a23:b67:d1d9 with SMTP id z8-20020a17090674c800b00a230b67d1d9mr2885567ejl.2.1702813778015; Sun, 17 Dec 2023 03:49:38 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702813778; cv=none; d=google.com; s=arc-20160816; b=wG2eR1SzjOaUfl0fKlsV3SWCNuMVcslKL5Q6MTDRplFchhRkPW8K3tkkiGX09Ex/sX Lpdatiav4pavY4K8li9wM0yYKOeYU9DVDy7nwDzRVlQars4zJL7pIRaTBtEY1+wCxU9p PR2J4qU9Ux2uBVtA636zXWTqHV9iMCgBvblUrJf2P87Z63fQgrDcVEm05K0biGL5Z/hu cPCBxSjzOpKF72wcfZrIDMo9pyt/AMyQnUtVNK0BfrOqlKFb+ZBJle2NHW//L9sEV5D/ kyBUR10zMevr6Z0MehM/kHJlHw7rulCwfCLB/d9zCMA/Dg0zxj7o5geb/wqIDHEAQMJm 17Yg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=osJ1mLwIyuPutRkLFgbyHpDWSBr4iZkDr4H8oQCb/PA=; fh=cQTxynQ7rGExgmbyXq8tNmd/VmE1Fzgt9QW51hABj2c=; b=tntRfs/j9H9543eIV3E3pBz5Xx2Fwu4YHaIaZjMkEh6MkGAmUSdtpoDFZWqd3ELnBt rvZ3HLzuuRpPMmzm/hg+SPoIdWvdSaKdzxrlywRjAVfh/Orve1AYVwU6q90zTH1ajr3Y N8vHN4AEwn0/TG6SM9K0JpMrv7W5JZHwCx9kZdvBrjoA0FEd+cRZcD+pBOtQbuaBX7FX C3CM9fVgHYzxfR+P3AgrkelynkBU+TZcrRvNUb2cW8FRwP8NeTJ8W8V8eJEcl8qbhw6M GMCpBg2SOJTbdsSO0w7WHvA3oYZ0a9qxvoweJkjD/HbjlVh1o0+zWtJsxStB7mg+Fwez NGiQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=aXnOI2OO; spf=pass (google.com: domain of linux-kernel+bounces-2556-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-2556-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id b24-20020a170906151800b00a1dfe5894aasi8875073ejd.332.2023.12.17.03.49.37 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 17 Dec 2023 03:49:38 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-2556-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=aXnOI2OO; spf=pass (google.com: domain of linux-kernel+bounces-2556-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-2556-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 898821F21F1D for ; Sun, 17 Dec 2023 11:49:37 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id EF94732C86; Sun, 17 Dec 2023 11:49:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="aXnOI2OO" X-Original-To: linux-kernel@vger.kernel.org Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D05ED321A1; Sun, 17 Dec 2023 11:49:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1702813754; x=1734349754; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=pAB6UHpZ1jFyYGw9nUTrbNAF8ShhFcEIi6VVWcYmYi8=; b=aXnOI2OOG/MVhN9om3wrdCXgE5cXn+2dLaPLmLLoSH8TXJe2zMjGXEkX 0Q1uCAGB9FzLebX9EO405mvzDsRESJUaAOqdffblNZdTyqIl9cVMyY4WG bMykduFpTY9+RtPBxGOX2u6AK8MK65Ju0rtnacHH6MPhEFguf2OtT2NC2 ESLc65gssjxAkkR7sDrBoqESKbhZU5seDQHwgZPIZmTk5A3gsL1vSRkaZ glxS+4/aSyEQjHbxzrXAsaIxeV3sjAPTXweudnBBQtuOGvRMR5WiP/dzS 70ngNPpiSS9iZOU+lrXQWZyQCPOJ8ZNqxpAIiS2Er/iNEOEvsmbME1GMK w==; X-IronPort-AV: E=McAfee;i="6600,9927,10926"; a="2599468" X-IronPort-AV: E=Sophos;i="6.04,283,1695711600"; d="scan'208";a="2599468" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmvoesa104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Dec 2023 03:49:13 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10926"; a="751454178" X-IronPort-AV: E=Sophos;i="6.04,283,1695711600"; d="scan'208";a="751454178" Received: from ply01-vm-store.bj.intel.com ([10.238.153.201]) by orsmga006.jf.intel.com with ESMTP; 17 Dec 2023 03:49:09 -0800 From: Ethan Zhao To: bhelgaas@google.com, baolu.lu@linux.intel.com, dwmw2@infradead.org, will@kernel.org, robin.murphy@arm.com, lukas@wunner.de Cc: linux-pci@vger.kernel.org, iommu@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v3 1/2] PCI: make pci_dev_is_disconnected() helper public for Date: Sun, 17 Dec 2023 06:49:01 -0500 Message-Id: <20231217114902.3836260-2-haifeng.zhao@linux.intel.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20231217114902.3836260-1-haifeng.zhao@linux.intel.com> References: <20231217114902.3836260-1-haifeng.zhao@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Make pci_dev_is_disconnected() public so that it can be called from Intel vt-d driver to quick fix/workaround the SURPPRISE_REMOVAL unplug hang issue for those ATS capable devices on PCIe switch downstream ports. Tested-by: Haorong Ye Signed-off-by: Ethan Zhao --- drivers/pci/pci.h | 5 ----- include/linux/pci.h | 5 +++++ 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/pci/pci.h b/drivers/pci/pci.h index 5ecbcf041179..75fa2084492f 100644 --- a/drivers/pci/pci.h +++ b/drivers/pci/pci.h @@ -366,11 +366,6 @@ static inline int pci_dev_set_disconnected(struct pci_dev *dev, void *unused) return 0; } -static inline bool pci_dev_is_disconnected(const struct pci_dev *dev) -{ - return dev->error_state == pci_channel_io_perm_failure; -} - /* pci_dev priv_flags */ #define PCI_DEV_ADDED 0 #define PCI_DPC_RECOVERED 1 diff --git a/include/linux/pci.h b/include/linux/pci.h index 60ca768bc867..869f2ec97a84 100644 --- a/include/linux/pci.h +++ b/include/linux/pci.h @@ -2503,6 +2503,11 @@ static inline struct pci_dev *pcie_find_root_port(struct pci_dev *dev) return NULL; } +static inline bool pci_dev_is_disconnected(const struct pci_dev *dev) +{ + return dev->error_state == pci_channel_io_perm_failure; +} + void pci_request_acs(void); bool pci_acs_enabled(struct pci_dev *pdev, u16 acs_flags); bool pci_acs_path_enabled(struct pci_dev *start, -- 2.31.1