Received-SPF: pass (google.com: domain of linux-kernel+bounces-2567-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Sun, 17 Dec 2023 13:11:36 +0100
From: Borislav Petkov <bp@alien8.de>
To: Julian Stecklina <julian.stecklina@cyberus-technology.de>
Cc: kvm@vger.kernel.org,
	Thomas Prescher <thomas.prescher@cyberus-technology.de>,
	Sean Christopherson <seanjc@google.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	Dave Hansen <dave.hansen@linux.intel.com>, x86@kernel.org,
	"H. Peter Anvin" <hpa@zytor.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] KVM: x86/emulator: emulate movbe with operand-size prefix
Message-ID: <20231217121136.GAZX7leKpfy+tSO0Tz@fat_crate.local>
References: <20231212095938.26731-1-julian.stecklina@cyberus-technology.de>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20231212095938.26731-1-julian.stecklina@cyberus-technology.de>

On Tue, Dec 12, 2023 at 10:59:37AM +0100, Julian Stecklina wrote:
> From: Thomas Prescher <thomas.prescher@cyberus-technology.de>
> 
> The MOVBE instruction can come with an operand-size prefix (66h). In
> this, case the x86 emulation code returns EMULATION_FAILED.
> 
> It turns out that em_movbe can already handle this case and all that
> is missing is an entry in respective opcode tables to populate
> gprefix->pfx_66.
> 
> Signed-off-by: Thomas Prescher <thomas.prescher@cyberus-technology.de>
> Signed-off-by: Julian Stecklina <julian.stecklina@cyberus-technology.de>
> ---
>  arch/x86/kvm/emulate.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/x86/kvm/emulate.c b/arch/x86/kvm/emulate.c
> index 2673cd5c46cb..08013e158b2d 100644
> --- a/arch/x86/kvm/emulate.c
> +++ b/arch/x86/kvm/emulate.c
> @@ -4502,11 +4502,11 @@ static const struct instr_dual instr_dual_0f_38_f1 = {
>  };
>  
>  static const struct gprefix three_byte_0f_38_f0 = {
> -	ID(0, &instr_dual_0f_38_f0), N, N, N
> +	ID(0, &instr_dual_0f_38_f0), ID(0, &instr_dual_0f_38_f0), N, N
>  };
>  
>  static const struct gprefix three_byte_0f_38_f1 = {
> -	ID(0, &instr_dual_0f_38_f1), N, N, N
> +	ID(0, &instr_dual_0f_38_f1), ID(0, &instr_dual_0f_38_f1), N, N
>  };
>  
>  /*
> -- 

Acked-by: Borislav Petkov (AMD) <bp@alien8.de>

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette