Received-SPF: pass (google.com: domain of linux-kernel+bounces-2575-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Sun, 17 Dec 2023 12:26:27 +0000
From: Conor Dooley <conor@kernel.org>
To: Jingbao Qiu <qiujingbao.dlmu@gmail.com>
Cc: a.zummo@towertech.it, alexandre.belloni@bootlin.com, robh+dt@kernel.org,
	krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
	chao.wei@sophgo.com, unicorn_wang@outlook.com,
	paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu,
	linux-rtc@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, dlan@gentoo.org
Subject: Re: [PATCH v2 1/3] dt-bindings: rtc: sophgo: add RTC support for
 Sophgo CV1800 series SoC
Message-ID: <20231217-wrist-flakily-db9974d8b515@spud>
References: <20231217110952.78784-1-qiujingbao.dlmu@gmail.com>
 <20231217110952.78784-2-qiujingbao.dlmu@gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="OdLsfqhVywJgxuvx"
Content-Disposition: inline
In-Reply-To: <20231217110952.78784-2-qiujingbao.dlmu@gmail.com>


--OdLsfqhVywJgxuvx
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Sun, Dec 17, 2023 at 07:09:50PM +0800, Jingbao Qiu wrote:

> +  reg:
> +    items:
> +      - description: data register
> +      - description: control register

> +    rtc@5025000{
> +      compatible = "sophgo,cv1800-rtc";
> +      reg = <0x5025000 0x1000>, <0x5026000 0x1000>;

Why are these two regions rather than just one, given they are located
next to one another?
Are they separate on one of the other devices in this family?

Thanks,
Conor.

> +      clocks = <&osc>;
> +      interrupts = <17 IRQ_TYPE_LEVEL_HIGH>;
> +    };


--OdLsfqhVywJgxuvx
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZX7o8wAKCRB4tDGHoIJi
0haNAPsFYNZmM6Mo/NYopCKYD2j3+5K3GyDMMa1C3a6jTdlnKgEA6U5Z2UkuWvx0
JngeX5rzO1tn3afS6vFy8kGdWM55vAg=
=YuR3
-----END PGP SIGNATURE-----

--OdLsfqhVywJgxuvx--