Received-SPF: pass (google.com: domain of linux-kernel+bounces-2614-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <9a9e84bf64fc95840ff852aeb276ef8f724b60be.camel@perches.com>
Subject: Re: [PATCH v3] iio: sx9324: avoid copying property strings
From: Joe Perches <joe@perches.com>
To: Jonathan Cameron <jic23@kernel.org>
Cc: Justin Stitt <justinstitt@google.com>, Lars-Peter Clausen
 <lars@metafoo.de>,  Stephen Boyd <swboyd@chromium.org>,
 linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, 
 linux-hardening@vger.kernel.org
Date: Sun, 17 Dec 2023 05:41:12 -0800
In-Reply-To: <20231217132447.269072df@jic23-huawei>
References: 
	<20231212-strncpy-drivers-iio-proximity-sx9324-c-v3-1-b8ae12fc8a5d@google.com>
	 <f03d372a282712dee8412e47aff9bb54f181efd9.camel@perches.com>
	 <20231217132447.269072df@jic23-huawei>
Content-Type: text/plain; charset="ISO-8859-1"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.48.4 (3.48.4-1.fc38) 
Precedence: bulk
MIME-Version: 1.0

On Sun, 2023-12-17 at 13:24 +0000, Jonathan Cameron wrote:
> On Mon, 11 Dec 2023 22:30:12 -0800
> Joe Perches <joe@perches.com> wrote:
>=20
> > On Tue, 2023-12-12 at 00:42 +0000, Justin Stitt wrote:
> > > We're doing some needless string copies when trying to assign the pro=
per
> > > `prop` string. We can make `prop` a const char* and simply assign to
> > > string literals. =20
> >=20
> > trivia:
> >=20
> > I would have updated it like this moving the
> > various declarations into the case blocks
> > where they are used and removing a few unused
> > #defines
>=20
> I'd definitely like to see those defines gone.
> Arguably an unrelated change as I guess they are left from a previous ref=
actor
> of this code.
>=20
> Why prop to type renaming?

random, no specific need, though I prefer not reusing
identifiers with different types in separate local scopes.

>   It's getting passed into calls where the parameter
> is propname so I'd understand renaming to that, but type just seems a bit=
 random
> to me.  I do wonder if we are better off having some long lines and getti=
ng rid
> of the property naming local variables completely by just duplicating
> the device_property_read_u32() call and passing them in directly.

maybe, give it a try and see what you think.