Received: by 2002:a05:7412:8d08:b0:f9:2d0a:d759 with SMTP id bj8csp158391rdb; Sun, 17 Dec 2023 06:30:02 -0800 (PST) X-Google-Smtp-Source: AGHT+IEgYiiv01TA4QEMRSrNdchdcwwLw84bL/iTeHha5d0YkgcNce/rVaNsrTeHwToAX0iI4UNf X-Received: by 2002:a17:907:924e:b0:a23:4e54:25c9 with SMTP id kb14-20020a170907924e00b00a234e5425c9mr534718ejb.36.1702823402645; Sun, 17 Dec 2023 06:30:02 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702823402; cv=none; d=google.com; s=arc-20160816; b=c6/5sxKwXmzl6n2Gj88wpBXvYfILpVB4wy3L4sdCkLe4K2FNibTYbZbWovPasd+Gq0 RbpDAGqR6dDYYoKMdl8D8lI+aZTfsWMt5R/r6oaAHpU5d+LjFXIiwrn3VDlzteMO2uFD 9Rk5ldy5cuJPZAn9X3Umdi3sblBpG5xPrxbmP/he1F52WeyY/bn8+kyULGudtyy89YVD 6+2gL0apnPaBIQk1Zum/w6I4FlKjPJlm83WdkElBxyhVTzYlWUCbqcGw/NsGoYIBwsJn hKgdB16MctOkigc7NlwN88gFRtRZBydGJ7i41xrJuRawdH0jlDa4o88nsExhgm5BupbX ZoaQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :subject:cc:to:from:date:dkim-signature; bh=pccfQ9ZUb2Nh5eVooCsWxGFak9wLZlBNjcMiuGShqcQ=; fh=wIFnuZ8KiN/5rBh23g2HNZ4h4bphuKaDvJWymk2Nlhg=; b=u2rJl2CQnec8uccZZiLONQ0U7uQeItoFyJouGet0h+ooNj8dltJDYMBabAz0tO3oJn JUitneDD9Gtao6XhLzbOpp/YyfltuKxp83ASbfmFNHhOXZSJBK1ECx+xRfhwM7bh14KL 3uOHo09nnzVL0XOHCOK4em3/vyK24W9AmzFfgcMLD+JDxx4mBze0Q3nxScPD1/30tq28 JKc9+VYOrmbb6OlbzIQdYcxQR1DOXczPx7av0+M5J1HKW2UnozfGaqBzNtCGugzFfXI9 tr3CEqVFg8KtvKU5ImAJNRQAkpFmdosBCNA+g+aiZWj6UcqWyJAMutdCn7RjHWUeDCxj 0upA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=tEE90Lne; spf=pass (google.com: domain of linux-kernel+bounces-2629-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-2629-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id m10-20020a1709062b8a00b00a22f1120795si4721682ejg.183.2023.12.17.06.30.02 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 17 Dec 2023 06:30:02 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-2629-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=tEE90Lne; spf=pass (google.com: domain of linux-kernel+bounces-2629-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-2629-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 4A04A1F22715 for ; Sun, 17 Dec 2023 14:30:02 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 1D7B244C78; Sun, 17 Dec 2023 14:29:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="tEE90Lne" X-Original-To: linux-kernel@vger.kernel.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 42C27446D3; Sun, 17 Dec 2023 14:29:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D14ECC433C8; Sun, 17 Dec 2023 14:29:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1702823391; bh=1H1tix+lWo7PRIC9NukKzUsFE9MnvTSilpRM7bAhnMg=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=tEE90LnelQAWfxyJmnOzbsKSTycoB8VfXixfekQSuwjBeCFYAV82M0I8slIeh9L44 yv/Qy2H3HhPVidtZSkmE4cjXQkmEkN/NLISwoud2AmfE239dUdQLncBF9SBJnQ+YMi Fh5KICsf7aammduEeHNyqdPNmgtv+NmVuBQ9pzyR6PUEHBwgqtLFZQHZY6i1mOsDhL wSgRM4+gs12Mtoc8xJZY//QV4WcnzODBFhHcxzDcHGBYAD1RnoqnnAirexxCr5xuFh gjr7eKQNY9WvxntIlfPK+Awg10FyFIuvalEeEJtyt6ihEXyuub0pVyWVB9cwvu0uwM 5/8CqEsiRL5uA== Date: Sun, 17 Dec 2023 14:29:35 +0000 From: Jonathan Cameron To: David Lechner Cc: linux-iio@vger.kernel.org, linux-spi@vger.kernel.org, devicetree@vger.kernel.org, Rob Herring , Krzysztof Kozlowski , Conor Dooley , Michael Hennerich , Nuno =?UTF-8?B?U8Oh?= , Liam Girdwood , Mark Brown , linux-kernel@vger.kernel.org, Stefan Popa Subject: Re: [PATCH v3 3/3] iio: adc: ad7380: new driver for AD7380 ADCs Message-ID: <20231217142935.56426fba@jic23-huawei> In-Reply-To: <20231215-ad7380-mainline-v3-3-7a11ebf642b9@baylibre.com> References: <20231215-ad7380-mainline-v3-0-7a11ebf642b9@baylibre.com> <20231215-ad7380-mainline-v3-3-7a11ebf642b9@baylibre.com> X-Mailer: Claws Mail 4.2.0 (GTK 3.24.38; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Fri, 15 Dec 2023 04:32:04 -0600 David Lechner wrote: > This adds a new driver for the AD7380 family ADCs. > > The driver currently implements basic support for the AD7380, AD7381, > AD7383, and AD7384 2-channel differential ADCs. Support for additional > single-ended and 4-channel chips that use the same register map as well > as additional features of the chip will be added in future patches. > > Co-developed-by: Stefan Popa > Signed-off-by: Stefan Popa > Reviewed-by: Nuno Sa > Signed-off-by: David Lechner LGTM. Just the Ack from Mark on patch 1 needed now I think (unless other reviews come in of course!) Jonathan > +