Received: by 2002:a05:7412:8d08:b0:f9:2d0a:d759 with SMTP id bj8csp159287rdb; Sun, 17 Dec 2023 06:31:40 -0800 (PST) X-Google-Smtp-Source: AGHT+IHEe9Gog3EYO0bRudW1gYb7oKJSjxq0h+hkEUxF/ufhpBmY/3WMEaWT4QK9FCI8AzEbzszB X-Received: by 2002:a17:906:d8ac:b0:a1c:837c:e4a3 with SMTP id qc12-20020a170906d8ac00b00a1c837ce4a3mr7509521ejb.79.1702823500288; Sun, 17 Dec 2023 06:31:40 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702823500; cv=none; d=google.com; s=arc-20160816; b=o/ie93SC0x93nVdJYDHJMC+ydQy+dxdWkDE7Hbjbi5VQnncDr0HR9Gojm0bKWgJR47 Nsu6MAL3Jr1Eedbdktb6Ch6uMemJVzkHbtyC+LBjCqmNrqgQ9YenZ0I4h3wASqfb97l6 yq2lGjghAesIOV7FN2VuGR9lDDZi7SWo6nhj6U9Kd/AN5mFATr9cJhrlA4ln+qOZwsNz yYC91vPcNoQejBiAATfLtek6xKqMM5mmhgDa76n5RRGK+WmDE0tghq5ILKueNyjbRgTH WZuw5Au8+NHBCqtKwN/IXTL0dUacfj5e+xEq1tO/lD3X4oV8V9BLYmdmJQiXZYnqlSen OmlA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from; bh=6kSo6IM5noELbQvPU+rEV4GJIh1YNljG18YOAr8aWyU=; fh=xujKiMmFJlaRajf7/h0r/xgOkeSk7wwiavZofWauGUw=; b=VAc1f0oArRcOpIPz8vFyvDt3dbWzBAhgBju3lgv4ujBsy2j4iT2m1TSMik7wCzBhTf XILA7PsKAV8zIEysGyFbLcNd70SbKe071YD3OUi4J9iz5CbsqU0IWwCvM2FMNbH4b1wx k3PdIE6gpkK+GzmNjH3zkRedq0zq5CI1lkxKkhFkH+RwHc4596V7xr2LPJPKWOrOX1m0 J7zml+2L5PdwVazuhzhh58MbXPEcUpdAh/LdPpi1d9oOTm+8G5uPGyUDgXA1DbwLCBwW Nr5imxOk9oqBu33RuojUn0SyubLPkA3WVSdzqC3v4ObZQMP7oKRYP0JoJ1w7Ftkkr3ti KdEQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-2639-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-2639-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id j11-20020a170906410b00b00a2333071891si988176ejk.411.2023.12.17.06.31.40 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 17 Dec 2023 06:31:40 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-2639-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-2639-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-2639-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 0F3431F21A38 for ; Sun, 17 Dec 2023 14:31:40 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 5605D47F5F; Sun, 17 Dec 2023 14:30:22 +0000 (UTC) X-Original-To: linux-kernel@vger.kernel.org Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 68E3745014 for ; Sun, 17 Dec 2023 14:30:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rEs9e-0006VK-T6; Sun, 17 Dec 2023 15:30:06 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rEs9c-00GUh6-23; Sun, 17 Dec 2023 15:30:04 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1rEs9b-004hyt-Os; Sun, 17 Dec 2023 15:30:03 +0100 From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= To: Krzysztof Kozlowski Cc: kernel@pengutronix.de, Markus Mayer , Broadcom internal kernel review list , Florian Fainelli , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 01/15] memory: brcmstb_dpfe: Convert to platform remove callback returning void Date: Sun, 17 Dec 2023 15:29:27 +0100 Message-ID: <94780e5a414b20b6effa1e87208c14620c854e88.1702822744.git.u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.42.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Developer-Signature: v=1; a=openpgp-sha256; l=1782; i=u.kleine-koenig@pengutronix.de; h=from:subject:message-id; bh=NqCgvYjkJld3SgKTMzNoNFlN7UBIUNxiFFLbxrZ5cYQ=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBlfwXGl1AmJHmGkUrNQ1FnLcrkoZ4iDiokSMdTj kBRQcFosluJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZX8FxgAKCRCPgPtYfRL+ TgZPB/4yygmvfAFl9kDpKc6eG2Iay0PbfcS9KAho672FuxXi2wYKFF92Z7VSJkHcnd6C6Ix+YRk LujlGAzxjH+9IWgeGNV9cz/jweGLzDqkYgRnawaziENAnDO3Iq7tP+/5170007yJdXpXlFysicj oqONP/mZMeQeFSvbOM7JyWFXaOc68SPyPMWNlAyyG7mzc/PRX+bAqHbCZ29SGzxLQC6egU9PYxY rqlrsHx5t2HOBm5Q0ZNsyHawSJ7InOwuk+KFmXAfaR+ddDLxVmO7f7LRPg0kGHREeWYYWhA8TtU T5eo7lMF2U4nXnyd1mIZSLzSno+1pyI6hIUnPNRqb4oKb9fv X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 Content-Transfer-Encoding: 8bit X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/memory/brcmstb_dpfe.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/memory/brcmstb_dpfe.c b/drivers/memory/brcmstb_dpfe.c index a7ab3d377206..5028467b2dc9 100644 --- a/drivers/memory/brcmstb_dpfe.c +++ b/drivers/memory/brcmstb_dpfe.c @@ -909,13 +909,11 @@ static int brcmstb_dpfe_probe(struct platform_device *pdev) return ret; } -static int brcmstb_dpfe_remove(struct platform_device *pdev) +static void brcmstb_dpfe_remove(struct platform_device *pdev) { struct brcmstb_dpfe_priv *priv = dev_get_drvdata(&pdev->dev); sysfs_remove_groups(&pdev->dev.kobj, priv->dpfe_api->sysfs_attrs); - - return 0; } static const struct of_device_id brcmstb_dpfe_of_match[] = { @@ -936,7 +934,7 @@ static struct platform_driver brcmstb_dpfe_driver = { .of_match_table = brcmstb_dpfe_of_match, }, .probe = brcmstb_dpfe_probe, - .remove = brcmstb_dpfe_remove, + .remove_new = brcmstb_dpfe_remove, .resume = brcmstb_dpfe_resume, }; -- 2.42.0