Received-SPF: pass (google.com: domain of linux-kernel+bounces-2664-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Sender: Guenter Roeck <groeck7@gmail.com>
Date: Sun, 17 Dec 2023 07:33:19 -0800
From: Guenter Roeck <linux@roeck-us.net>
To: Potin Lai <potin.lai.pt@gmail.com>
Cc: Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Jean Delvare <jdelvare@suse.com>, Jonathan Corbet <corbet@lwn.net>,
	Mark Brown <broonie@kernel.org>, Joel Stanley <joel@jms.id.au>,
	Peter Yin <peteryin.openbmc@gmail.com>,
	Peter Yin <peter.yin@quantatw.com>,
	Potin Lai <potin.lai@quantatw.com>,
	Patrick Williams <patrick@stwcx.xyz>, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org,
	linux-doc@vger.kernel.org
Subject: Re: [PATCH v2 2/2] hwmon: (pmbus) Add support for MPS Multi-phase
 mp2856/mp2857 controller
Message-ID: <9abe3c01-f6ba-4791-9cf8-d73dfe44d899@roeck-us.net>
References: <20231211160519.21254-1-potin.lai.pt@gmail.com>
 <20231211160519.21254-3-potin.lai.pt@gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20231211160519.21254-3-potin.lai.pt@gmail.com>

On Tue, Dec 12, 2023 at 12:05:19AM +0800, Potin Lai wrote:
> From: Peter Yin <peteryin.openbmc@gmail.com>
> 
> Add support for mp2856/mp2857 device from Monolithic Power Systems, Inc.
> (MPS) vendor. This is a dual-loop, digital, multi-phase,
> modulation controller.
> 
> Signed-off-by: Peter Yin <peteryin.openbmc@gmail.com>
> Signed-off-by: Potin Lai <potin.lai.pt@gmail.com>

Applied, with reservations (because due to lack of datasheet it is all but
impossible to validate the code) and several fixups. So this driver comes
with even less warranty than usual.

CHECK: Alignment should match open parenthesis
#671: FILE: drivers/hwmon/pmbus/mp2856.c:413:
+	memcpy(data->max_phases, mp2856_max_phases[data->chip_id],
+		sizeof(data->max_phases));

CHECK: Please don't use multiple blank lines
#673: FILE: drivers/hwmon/pmbus/mp2856.c:415:
+
+

CHECK: Please don't use multiple blank lines
#707: FILE: drivers/hwmon/pmbus/mp2856.c:449:
+
+

Fix those, and use i2c_get_match_data().

_Please_ run your patches through checkpatch. The above is really
completely unnecessary and creates unnecessary extra work for others (me).

Guenter