Received-SPF: pass (google.com: domain of linux-kernel+bounces-2768-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Sun, 17 Dec 2023 18:03:16 +0000
From: Qais Yousef <qyousef@layalina.io>
To: Dietmar Eggemann <dietmar.eggemann@arm.com>
Cc: Lukasz Luba <lukasz.luba@arm.com>, linux-kernel@vger.kernel.org,
	linux-pm@vger.kernel.org, rafael@kernel.org, rui.zhang@intel.com,
	amit.kucheria@verdurent.com, amit.kachhap@gmail.com,
	daniel.lezcano@linaro.org, viresh.kumar@linaro.org,
	len.brown@intel.com, pavel@ucw.cz, mhiramat@kernel.org,
	wvw@google.com
Subject: Re: [PATCH v5 22/23] PM: EM: Add em_dev_compute_costs() as API for
 device drivers
Message-ID: <20231217180316.rblvtqaxjvu5xedf@airbuntu>
References: <20231129110853.94344-1-lukasz.luba@arm.com>
 <20231129110853.94344-23-lukasz.luba@arm.com>
 <8fc499cf-fca1-4465-bff7-a93dfd36f3c8@arm.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <8fc499cf-fca1-4465-bff7-a93dfd36f3c8@arm.com>

On 12/12/23 19:50, Dietmar Eggemann wrote:
> On 29/11/2023 12:08, Lukasz Luba wrote:
> > The device drivers can modify EM at runtime by providing a new EM table.
> > The EM is used by the EAS and the em_perf_state::cost stores
> > pre-calculated value to avoid overhead. This patch provides the API for
> > device drivers to calculate the cost values properly (and not duplicate
> > the same code).
> 
> New interface w/o any users? Can we not remove this from this patch-set
> and introduce it with the first user(s)?

It's a chicken and egg problem. No interface, will not enable the new users to
appear too. So assuming the interface makes sense, I vote to keep it.

I lost brain power half way through the series and didn't review this properly
yet; but will continue looking later during the week.


Cheers

--
Qais Yousef