Received-SPF: pass (google.com: domain of linux-kernel+bounces-2806-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Sun, 17 Dec 2023 20:58:19 +0000
From: Conor Dooley <conor@kernel.org>
To: Abdel Alkuor <alkuor@gmail.com>
Cc: Jean Delvare <jdelvare@suse.com>, Guenter Roeck <linux@roeck-us.net>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Jonathan Corbet <corbet@lwn.net>, linux-hwmon@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-doc@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: hwmon: Add AMS AS6200 temperature sensor
Message-ID: <20231217-enlarged-mule-a594e472d007@spud>
References: <149032e99136a9fe47c3533b57a71092646e497d.1702744180.git.alkuor@gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="0Nuw4ocMxTNpMmVV"
Content-Disposition: inline
In-Reply-To: <149032e99136a9fe47c3533b57a71092646e497d.1702744180.git.alkuor@gmail.com>


--0Nuw4ocMxTNpMmVV
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sat, Dec 16, 2023 at 11:39:29AM -0500, Abdel Alkuor wrote:
> as6200 is a temperature sensor with a range between -40=B0C to
> 125=B0C degrees and an accuracy of =B10.4=B0C degree between 0
> and 65=B0C and =B11=B0C for the other ranges.
>=20
> Signed-off-by: Abdel Alkuor <alkuor@gmail.com>

Is this not v3?
Either way,
Reviewed-by: Conor Dooley <conor.dooley@microchip.com>

Cheers,
Conor.

> ---
>  .../devicetree/bindings/hwmon/ams,as6200.yaml | 52 +++++++++++++++++++
>  1 file changed, 52 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/hwmon/ams,as6200.ya=
ml
>=20
> diff --git a/Documentation/devicetree/bindings/hwmon/ams,as6200.yaml b/Do=
cumentation/devicetree/bindings/hwmon/ams,as6200.yaml
> new file mode 100644
> index 000000000000..01476c1a4c98
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/hwmon/ams,as6200.yaml
> @@ -0,0 +1,52 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/hwmon/ams,as6200.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: AMS AS6200 Temperature Sensor
> +
> +maintainers:
> +  - Abdel Alkuor <alkuor@gmail.com>
> +
> +description: |
> +  as6200 is a temperature sensor with a range between -40=B0C to
> +  125=B0C degrees and an accuracy of =B10.4=B0C degree between 0
> +  and 65=B0C and =B11=B0C for the other ranges.
> +  https://ams.com/documents/20143/36005/AS6200_DS000449_4-00.pdf
> +
> +properties:
> +  compatible:
> +    const: ams,as6200
> +
> +  reg:
> +    maxItems: 1
> +
> +  vdd-supply: true
> +
> +  interrupts:
> +    maxItems: 1
> +
> +required:
> +  - compatible
> +  - reg
> +  - vdd-supply
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/interrupt-controller/irq.h>
> +    i2c {
> +        #address-cells =3D <1>;
> +        #size-cells =3D <0>;
> +
> +        temperature-sensor@48 {
> +            compatible =3D "ams,as6200";
> +            reg =3D <0x48>;
> +            vdd-supply =3D <&vdd>;
> +            interrupt-parent =3D <&gpio1>;
> +            interrupts =3D <17 IRQ_TYPE_EDGE_BOTH>;
> +        };
> +    };
> +...
> --=20
> 2.34.1
>=20

--0Nuw4ocMxTNpMmVV
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZX9g6wAKCRB4tDGHoIJi
0pt1AP9wa3Ox1pAcjn5pj3sf4FDkDATXqM48sSJn49Y6tvjAigEA/oTJrckePXPg
d17KRA0h1rPIryJLMl9jHSEA7Rip2QI=
=970O
-----END PGP SIGNATURE-----

--0Nuw4ocMxTNpMmVV--