Received-SPF: pass (google.com: domain of linux-kernel+bounces-2867-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
From: "Tian, Kevin" <kevin.tian@intel.com>
To: Nicolin Chen <nicolinc@nvidia.com>, "Liu, Yi L" <yi.l.liu@intel.com>
CC: "joro@8bytes.org" <joro@8bytes.org>, "alex.williamson@redhat.com"
	<alex.williamson@redhat.com>, "jgg@nvidia.com" <jgg@nvidia.com>,
	"robin.murphy@arm.com" <robin.murphy@arm.com>, "baolu.lu@linux.intel.com"
	<baolu.lu@linux.intel.com>, "cohuck@redhat.com" <cohuck@redhat.com>,
	"eric.auger@redhat.com" <eric.auger@redhat.com>, "kvm@vger.kernel.org"
	<kvm@vger.kernel.org>, "mjrosato@linux.ibm.com" <mjrosato@linux.ibm.com>,
	"chao.p.peng@linux.intel.com" <chao.p.peng@linux.intel.com>,
	"yi.y.sun@linux.intel.com" <yi.y.sun@linux.intel.com>, "peterx@redhat.com"
	<peterx@redhat.com>, "jasowang@redhat.com" <jasowang@redhat.com>,
	"shameerali.kolothum.thodi@huawei.com"
	<shameerali.kolothum.thodi@huawei.com>, "lulu@redhat.com" <lulu@redhat.com>,
	"suravee.suthikulpanit@amd.com" <suravee.suthikulpanit@amd.com>,
	"iommu@lists.linux.dev" <iommu@lists.linux.dev>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-kselftest@vger.kernel.org" <linux-kselftest@vger.kernel.org>, "Duan,
 Zhenzhong" <zhenzhong.duan@intel.com>, "joao.m.martins@oracle.com"
	<joao.m.martins@oracle.com>, "Zeng, Xin" <xin.zeng@intel.com>, "Zhao, Yan Y"
	<yan.y.zhao@intel.com>
Subject: RE: [PATCH v7 1/3] iommufd: Add data structure for Intel VT-d stage-1
 cache invalidation
Thread-Topic: [PATCH v7 1/3] iommufd: Add data structure for Intel VT-d
 stage-1 cache invalidation
Thread-Index: AQHaGViOWXGe59nutU2rEx/0zRDvrrCozh6AgADg1VCAABsWAIAACKYAgAAJVgCAAAgBgIACimIAgAHgBaA=
Date: Sun, 17 Dec 2023 23:28:24 +0000
Message-ID: <BN9PR11MB5276EF5F7C77C110E412514D8C91A@BN9PR11MB5276.namprd11.prod.outlook.com>
References: <20231117131816.24359-1-yi.l.liu@intel.com>
 <20231117131816.24359-2-yi.l.liu@intel.com>
 <c967e716-9112-4d1a-b6f7-9a005e28202d@intel.com>
 <BN9PR11MB5276D14D2A7FF60B41A6A7B48C93A@BN9PR11MB5276.namprd11.prod.outlook.com>
 <ZXu5whlIGfiq16wF@Asurada-Nvidia>
 <BN9PR11MB52766D7F774510E0181CC89B8C93A@BN9PR11MB5276.namprd11.prod.outlook.com>
 <ZXvI2IiXwwuHRE8V@Asurada-Nvidia>
 <7c398efc-8a2f-479d-bcff-ded8cc1ef3d0@intel.com>
 <ZX3xJH8LPr8noBvt@Asurada-Nvidia>
In-Reply-To: <ZX3xJH8LPr8noBvt@Asurada-Nvidia>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?pcYX0bog157Y8kppKMZSKp+GUXpRlT2bzOilNXn5Q8Ud1dewGyYUN46Us0f8?=
 =?us-ascii?Q?4bIJbiaic3+SSFIO/2OFN0S8bjF3rqhe2CI2KExbRR9X6wXj3oE2PnD4/0Ga?=
 =?us-ascii?Q?73CfGsBgV9RM8K0pPZnt5Sj4A3fwUWpzKIkQzstfVmt16Yfslv+18Jh7CXHG?=
 =?us-ascii?Q?Te8kIBcJ26MUoZV+u3n2IOzkMj8Y4jFTxo4L6m8wU1Ai08PjHI1SuyH82J7Y?=
 =?us-ascii?Q?OPnXPufVmuDXc/7X4gz/OW3CtvEmvmxVolJmzoHp21g/99OzZGUMIEUunTH8?=
 =?us-ascii?Q?LH6NEzfNoK35Osf5sC5CVKT5bE3FEyxUTgZx50ysjkiRPbskxb2iOLy/bT5Y?=
 =?us-ascii?Q?ebobFDORYcaWnBOKHhyH8F5WWJxQ1F8tZw/qYIYKSvUoBtaDH25fDTK6AG0z?=
 =?us-ascii?Q?mEhiFitmKJBFmlsHWDmRkea0mKX9jrEJBhZ71XxNjeNRagYni7p01di8Yp8w?=
 =?us-ascii?Q?MYSkD030WR1FDEofc0tvwe1jxn17DJKRCpNNTyC1emx5apS17fuXHodpmrF+?=
 =?us-ascii?Q?4Fm8GqgcmyLEQs54u5JruAowNb75L7ljN9PRNK8qS2ZY/BkyRHKwJP1o/XlD?=
 =?us-ascii?Q?wtEF21RpVJTdtuDh3LYHR4qYTtrFtM1oE0+z1TvHPiIybhIyf5IYuVyXqVUo?=
 =?us-ascii?Q?aPbYfuOyDNCog1dExdBXC3MP12iDbhmZTxxVuxmOsJ2Y0PcSnglNcLrLaP8y?=
 =?us-ascii?Q?lTiEhR3YiFky3i1HOfaWw8l13OWVfX1EldcMh52SveaFBBLoMYcfI8BAbng1?=
 =?us-ascii?Q?7u3l1kXmMmSbhWF/S4UqfGd35dpJmm+nKZVAe3G9/AW0mTXn7uBDXqWmlP2d?=
 =?us-ascii?Q?wyI52/Rp7UW4jsXcfJZWA1FGfbiS1QQJ9uInbB3AfHOn6zjo+OA8NJWI61By?=
 =?us-ascii?Q?yUIfRx2zfw5OAMMs3D6142xqhN2UhT1XpOUtbwiuWN2a9kXBPlkX7Jj35qtU?=
 =?us-ascii?Q?WExyYvEOUbSYfwf7L3Bl2AlIS4WWGiOD7CCeCoDMQxfRy23t69qwjfGiHgq5?=
 =?us-ascii?Q?y6iahtDyWZ0zxzc/pL0CKaJpkl7oBRRhtHJsIQLjl3PnzYLjvQMOF5xIlDer?=
 =?us-ascii?Q?nvpQrnIfAwDxK36oPpuBUcDudAr61tSw1iShwoIEpSQcYqhoeApeRIuDcCs1?=
 =?us-ascii?Q?pYC6nG6RUDof97wNKsvmz7mca6MYeOJVcp3h+IgFCmkeGPjcgD4lLAZoRZ6e?=
 =?us-ascii?Q?iyNg4isytyMB5ITlx1SnIVWDwBAN7vZjmaAjJBxK7D4AZ8DD8D6vepnydOd7?=
 =?us-ascii?Q?i3RIBWn2oLTAZK7fsi/lb2ifNfM4BMa6KZocXm0xA/N4ApJSk7M8qanxOZ4m?=
 =?us-ascii?Q?TFqp+6MAwjg+9XTWokX1nMrV+EJ/wjVO5p08pTpxGKiawTXHYWX7Im0i/IUU?=
 =?us-ascii?Q?hFPraUZBSuV8XzYKqw9ukBX39IYft+gcc5959ld8gtHGBLI9ryeU2mKXq0AO?=
 =?us-ascii?Q?EkAYuh/p/40RQTbryt9/0eHplydmNKtJ/eIUT1mBHeO2Ai3ddDA6BgykkPYA?=
 =?us-ascii?Q?Uaa/VUqiukR7x3O2lDZ7XygjWxKc8GUYBbl78dS6Ha8iPJRSxVJylABjoxPU?=
 =?us-ascii?Q?Il4jnSoNcQgCGlPq2N8F4hRiEd/zaMn11ADrXAAT?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5276.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d349c662-cdd0-4aa0-f43b-08dbff57dd60
X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Dec 2023 23:28:24.4259
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 9/VPMrlgfUClftcgPrDKOUJN2GWhaIgTvvtCa9yXmHTsyyTJ/rT3Ni3sO4c0Z9D753vOQTkut+y7RxeO/nrtDg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV8PR11MB8748
X-OriginatorOrg: intel.com

> From: Nicolin Chen <nicolinc@nvidia.com>
> Sent: Sunday, December 17, 2023 2:49 AM
>=20
> On Fri, Dec 15, 2023 at 12:01:19PM +0800, Yi Liu wrote:
> > On 2023/12/15 11:32, Nicolin Chen wrote:
> > > On Fri, Dec 15, 2023 at 03:04:44AM +0000, Tian, Kevin wrote:
> > > > > From: Nicolin Chen <nicolinc@nvidia.com>
> > > > > Sent: Friday, December 15, 2023 10:28 AM
> > > > > On Fri, Dec 15, 2023 at 01:50:07AM +0000, Tian, Kevin wrote:
> > > > > > > From: Liu, Yi L <yi.l.liu@intel.com>
> > > > > > > Sent: Thursday, December 14, 2023 7:27 PM
> > > > > > >
> > > > > > > On 2023/11/17 21:18, Yi Liu wrote:
> > > > > > and for this error reporting case what we actually require is t=
he
> > > > > > reverse map i.e. pRID->vRID. Not sure whether we can leverage t=
he
> > > > > > same RID mapping uAPI as for ARM/AMD but ignore viommu_id
> > > > > > and then store vRID under device_domain_info. a bit tricky on
> > > > > > life cycle management and also incompatible with SIOV...
> > > > >
> > > > > One thing that I am not very clear here: since both vRID and dev_=
id
> > > > > are given by the VMM, shouldn't it already know the mapping if th=
e
> > > > > point is to translate (pRID->)dev_id->vRID?
> > > > >
> > > >
> > > > it's true for current Qemu.
> > > >
> > > > but there is plan to support Qemu accepting a fd passed by Libvirt.
> > > > In that case Qemu even doesn't see the sysfs path hence is not
> > > > aware of pRID. otherwise yes we could leave the translation to
> > > > VMM instead.
> > >
> > > I think I misread Yi's narrative: dev_id is a working approach
> > > for VMM to convert to a vRID, while he is asking for a better
> > > alternative :)
> >
> > In concept, dev_id works, but in reality we have problem to get a dev_i=
d
> > for a given device in intel iommu driver, hence I'm asking for help her=
e. :)
>=20
> Yea, I got that.
>=20
> Would it be possible for us to postpone this error report in the
> vtd driver?
>=20

that is the plan. We'll still report error code but no dev_id error
data. this is allowed by vtd spec.