Received: by 2002:a05:7412:361b:b0:f9:2edb:3e4d with SMTP id ie27csp108934rdb; Sun, 17 Dec 2023 17:14:06 -0800 (PST) X-Google-Smtp-Source: AGHT+IGPbnDD7V607nl6T/QlSARfjNMgmJNnvGNkCCGt8KbjVO6kRpfWkTib+yGYeu+CB5Jbkqvw X-Received: by 2002:ad4:5ce8:0:b0:67f:135e:17ff with SMTP id iv8-20020ad45ce8000000b0067f135e17ffmr9198677qvb.45.1702862046342; Sun, 17 Dec 2023 17:14:06 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702862046; cv=none; d=google.com; s=arc-20160816; b=moKijGiQuNYgyC7cWbktXUsbzXTsjvb6zqIhp6Vezoel4payYQ17qjhWoI1mGA6j8P P2GOsXxmJbh08pB2bUwSPQLbJ0x8ykT1H6W6x1l2TJ5laGVwKzCKjuU39UxMFyEmLy9K Eoppx79whoY+i+LJeQgIVrh0BdtI7VuUxzRZzc+vy/Pxu5ATFCRbtpO55HJ7mfGlvPOk IAf+NdsmUvyrAbvxUIFLVJaVTbKoPXOoJDUfRwmKqCtctiJCG31YP8uyKR/OjN0iXvgF FFRHgFUztPo1DaWWpsOZ3Plj+k80cOcccisGUwzgjGLdAUWVw4TOmHTo536HSHbc0Z/T mqyA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=ZEvhQt6KyC3YmTShSBehYJCn/AfTUtDQHzjvN0mfk6Y=; fh=PkKPX03K3JsyHTes4BQLZMGAFWr/RPontOXNEyUJpL8=; b=WnqMV0gIIubnbHGPuAgGMgo/qf6gJqNLHhBM3jFuLfXWASpnjcMpkANiGdAcB3kp7z C6I2nARh+bojsrb0bbt14O9bkdqNlGsivMT0zegS+y6Wjdg0ZQGP0nvXmohscbpV3Kqj xJgfJAlPreCpvAH3cTNJ09oxcoQaqGnc6ubIqBxMqwwhhMzT9PNv6MrBynmu5Ai8gbXh H78A4w3EFlPKIFtz0WjLX1lLL0T5/a7Ltd8yPL2tK78gilqc5M8kTDNiVdrvHJdD38rK LuO0ywZ/5/Hwhy/0Har/rrXNIAvpEQ/PoLqKsMCrFOfmOB3pjdSadI8Mm/5otmnyt5rp fXeA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@windriver.com header.s=PPS06212021 header.b=YPYEAz83; spf=pass (google.com: domain of linux-kernel+bounces-2900-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-2900-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=windriver.com Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id p10-20020a0cf54a000000b0067f136f331dsi2558219qvm.240.2023.12.17.17.14.06 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 17 Dec 2023 17:14:06 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-2900-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@windriver.com header.s=PPS06212021 header.b=YPYEAz83; spf=pass (google.com: domain of linux-kernel+bounces-2900-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-2900-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=windriver.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 02D171C21F11 for ; Mon, 18 Dec 2023 01:14:06 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 26CC61FD7; Mon, 18 Dec 2023 01:13:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=windriver.com header.i=@windriver.com header.b="YPYEAz83" X-Original-To: linux-kernel@vger.kernel.org Received: from mx0b-0064b401.pphosted.com (mx0b-0064b401.pphosted.com [205.220.178.238]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 03A661FA3 for ; Mon, 18 Dec 2023 01:13:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=windriver.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=windriver.com Received: from pps.filterd (m0250812.ppops.net [127.0.0.1]) by mx0a-0064b401.pphosted.com (8.17.1.24/8.17.1.24) with ESMTP id 3BI1DUqS030923; Mon, 18 Dec 2023 01:13:46 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=windriver.com; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s= PPS06212021; bh=ZEvhQt6KyC3YmTShSBehYJCn/AfTUtDQHzjvN0mfk6Y=; b= YPYEAz832yWU+uWeIIF6TNB9BHeZ5RuyWYsk91n+UcGsrdCMpIQaL7sZpowqbgxP xo/+QdOq4AKSRyEtQBAzub0WHBPEaqTkK5ESHbJKC6hBnqpEGABept7SAGBIAuWB heAAwHBCOMB5/fZytkuCSYh249++59jhSJEv8YwuHSdA5m7jFKGzpj2RRXPXnfRB /Nq/SrFp/bDsKxfMizl41J2q8sCvT7bR+IeG19YCMzJOKsHQzzeqbbT/WrnxzzIV Jg4K+Xe2Lsm42JumSmpPDThZm14LOeUKwKN2eRugQFxP6bUS+t0NoVUHagLR1YPu tyE71rTpFrh+bFk9nxLZbg== Received: from ala-exchng02.corp.ad.wrs.com (ala-exchng02.wrs.com [147.11.82.254]) by mx0a-0064b401.pphosted.com (PPS) with ESMTPS id 3v12v5sekq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT); Mon, 18 Dec 2023 01:13:46 +0000 (GMT) Received: from ALA-EXCHNG02.corp.ad.wrs.com (147.11.82.254) by ALA-EXCHNG02.corp.ad.wrs.com (147.11.82.254) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Sun, 17 Dec 2023 17:13:51 -0800 Received: from pek-lpd-ccm6.wrs.com (147.11.136.210) by ALA-EXCHNG02.corp.ad.wrs.com (147.11.82.254) with Microsoft SMTP Server id 15.1.2507.35 via Frontend Transport; Sun, 17 Dec 2023 17:13:50 -0800 From: Lizhi Xu To: CC: , Subject: Re: [syzbot] [reiserfs?] possible deadlock in __run_timers Date: Mon, 18 Dec 2023 09:13:43 +0800 Message-ID: <20231218011343.1782210-1-lizhi.xu@windriver.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <000000000000b26907060cb9f1f5@google.com> References: <000000000000b26907060cb9f1f5@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Proofpoint-ORIG-GUID: H3gm6Qy4tsoHxOA-J3WJB66M7_897YZs X-Proofpoint-GUID: H3gm6Qy4tsoHxOA-J3WJB66M7_897YZs X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.987,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-11-16_25,2023-11-16_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 impostorscore=0 suspectscore=0 bulkscore=0 phishscore=0 mlxlogscore=720 priorityscore=1501 spamscore=0 clxscore=1011 adultscore=0 lowpriorityscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2311290000 definitions=main-2312180006 #syz test https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 88035e5694a8 diff --git a/kernel/workqueue.c b/kernel/workqueue.c index 2989b57e154a..33478bfee814 100644 --- a/kernel/workqueue.c +++ b/kernel/workqueue.c @@ -941,8 +941,10 @@ static void worker_enter_idle(struct worker *worker) /* idle_list is LIFO */ list_add(&worker->entry, &pool->idle_list); + raw_spin_unlock_irq(&pool->lock); if (too_many_workers(pool) && !timer_pending(&pool->idle_timer)) mod_timer(&pool->idle_timer, jiffies + IDLE_WORKER_TIMEOUT); + raw_spin_lock_irq(&pool->lock); /* Sanity check nr_running. */ WARN_ON_ONCE(pool->nr_workers == pool->nr_idle && pool->nr_running);