Received-SPF: pass (google.com: domain of linux-kernel+bounces-2921-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Mon, 18 Dec 2023 11:23:19 +0900
From: Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= <kw@linux.com>
To: Yang Li <yang.lee@linux.alibaba.com>
Cc: lpieralisi@kernel.org, robh@kernel.org, bhelgaas@google.com,
	michal.simek@amd.com, linux-pci@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
	Abaci Robot <abaci@linux.alibaba.com>
Subject: Re: [PATCH -next] PCI: xilinx-xdma: Remove redundant dev_err()
Message-ID: <20231218022319.GC88933@rocinante>
References: <20231030061242.51475-1-yang.lee@linux.alibaba.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20231030061242.51475-1-yang.lee@linux.alibaba.com>

Hello,

> There is no need to call the dev_err() function directly to print a
> custom message when handling an error from either the platform_get_irq()
> or platform_get_irq_byname() functions as both are going to display an
> appropriate error message in case of a failure.
> 
> ./drivers/pci/controller/pcie-xilinx-dma-pl.c:688:2-9: line 688 is redundant because platform_get_irq() already prints an error
> ./drivers/pci/controller/pcie-xilinx-dma-pl.c:702:2-9: line 702 is redundant because platform_get_irq() already prints an error

Applied to controller/xilinx, thank you!

[1/1] PCI: xilinx-xdma: Remove redundant dev_err()
      https://git.kernel.org/pci/pci/c/b642e081f46c

	Krzysztof