Received-SPF: pass (google.com: domain of linux-kernel+bounces-2940-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Precedence: bulk
MIME-Version: 1.0
References: <20231211160519.21254-1-potin.lai.pt@gmail.com>
 <20231211160519.21254-3-potin.lai.pt@gmail.com> <9abe3c01-f6ba-4791-9cf8-d73dfe44d899@roeck-us.net>
In-Reply-To: <9abe3c01-f6ba-4791-9cf8-d73dfe44d899@roeck-us.net>
From: Potin Lai <potin.lai.pt@gmail.com>
Date: Mon, 18 Dec 2023 10:43:51 +0800
Message-ID: <CAGfYmwXMHO7zYc0pzaexO4L5gXzCODEAd4Zxm8LmVL6USrrOwQ@mail.gmail.com>
Subject: Re: [PATCH v2 2/2] hwmon: (pmbus) Add support for MPS Multi-phase
 mp2856/mp2857 controller
To: Guenter Roeck <linux@roeck-us.net>
Cc: Rob Herring <robh+dt@kernel.org>, 
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>, 
	Jean Delvare <jdelvare@suse.com>, Jonathan Corbet <corbet@lwn.net>, Mark Brown <broonie@kernel.org>, 
	Joel Stanley <joel@jms.id.au>, Peter Yin <peteryin.openbmc@gmail.com>, 
	Peter Yin <peter.yin@quantatw.com>, Potin Lai <potin.lai@quantatw.com>, 
	Patrick Williams <patrick@stwcx.xyz>, devicetree@vger.kernel.org, 
	linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org, 
	linux-doc@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Sun, Dec 17, 2023 at 11:33=E2=80=AFPM Guenter Roeck <linux@roeck-us.net>=
 wrote:
>
> On Tue, Dec 12, 2023 at 12:05:19AM +0800, Potin Lai wrote:
> > From: Peter Yin <peteryin.openbmc@gmail.com>
> >
> > Add support for mp2856/mp2857 device from Monolithic Power Systems, Inc=
.
> > (MPS) vendor. This is a dual-loop, digital, multi-phase,
> > modulation controller.
> >
> > Signed-off-by: Peter Yin <peteryin.openbmc@gmail.com>
> > Signed-off-by: Potin Lai <potin.lai.pt@gmail.com>
>
> Applied, with reservations (because due to lack of datasheet it is all bu=
t
> impossible to validate the code) and several fixups. So this driver comes
> with even less warranty than usual.
>
> CHECK: Alignment should match open parenthesis
> #671: FILE: drivers/hwmon/pmbus/mp2856.c:413:
> +       memcpy(data->max_phases, mp2856_max_phases[data->chip_id],
> +               sizeof(data->max_phases));
>
> CHECK: Please don't use multiple blank lines
> #673: FILE: drivers/hwmon/pmbus/mp2856.c:415:
> +
> +
>
> CHECK: Please don't use multiple blank lines
> #707: FILE: drivers/hwmon/pmbus/mp2856.c:449:
> +
> +
>
> Fix those, and use i2c_get_match_data().
>
> _Please_ run your patches through checkpatch. The above is really
> completely unnecessary and creates unnecessary extra work for others (me)=
.
>
> Guenter

Apologies for missing the style check issue, I will add "--strict"
when running checkpatch.pl in future.
And thank you for fixing the mistakes and applying the driver.

Potin