Received-SPF: pass (google.com: domain of linux-kernel+bounces-2973-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Sun, 17 Dec 2023 19:34:13 -0800
From: Ira Weiny <ira.weiny@intel.com>
To: "Fabio M. De Francesco" <fabio.maria.de.francesco@linux.intel.com>, Andrew
 Morton <akpm@linux-foundation.org>, <linux-mm@kvack.org>,
	<linux-kernel@vger.kernel.org>
CC: "Fabio M. De Francesco" <fabio.maria.de.francesco@linux.intel.com>, "Ira
 Weiny" <ira.weiny@intel.com>
Subject: Re: [PATCH] mm/memory: Replace kmap() with kmap_local_page()
Message-ID: <657fbdb5db945_126a129483@iweiny-mobl.notmuch>
References: <20231215084417.2002370-1-fabio.maria.de.francesco@linux.intel.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20231215084417.2002370-1-fabio.maria.de.francesco@linux.intel.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?tkw2iOrtzQn5Fz578T5S5/z2wGRUPiAhYDv5EFNLtmPKePMR4VQjYhjSM9/+?=
 =?us-ascii?Q?TK3wS5zB0bun12k2eFFB3tUYvoXRyDWK2Nv5sr8gxhsjfinjtrYySt/WKk7k?=
 =?us-ascii?Q?m9m7Y9mOaDC3+KtKVfg6P3JFhHK7GL3g67mmRbpwUISS5gqsT+2bFiYayN+K?=
 =?us-ascii?Q?/OWonRsl3AJJwIDiWFO1aOQgDKAarIr9LkKVQxaxgdNALJFisFxqHFOdQXwl?=
 =?us-ascii?Q?kmhsg+IfwcNEqhrLmA6tHs8Py8NZIZn6FcpIhqRfsUMe66D1yVeBYnRZeYG7?=
 =?us-ascii?Q?N4rxSQTe05Cn0gxR9AVgRwqmddkae313rVqMy+GUhSv7q606NicM/YIadH9j?=
 =?us-ascii?Q?6cs5EpX3QnJVNQ+uZ2+Zvo0/a7wc9kcOwXDHe2xKGtEFhA8MnVX2kmVlrmrv?=
 =?us-ascii?Q?IT8Zg0N4D+BfCe0YkiCszWgY2YvZq7rtdDS7GcqYyUSEfhbyTJV7nXPRDpVH?=
 =?us-ascii?Q?kTAz0gYwbmCKRcviDaOS6xqggUZ9khHHUF0d+ipDXy67PK/JejVUvx2ZirYI?=
 =?us-ascii?Q?4OXDO3rUeuy/IgvxIsJ31wj//qON0YboIoMT2AOUJsE4YjV8OlwuVEIi2DRB?=
 =?us-ascii?Q?8xlYfKS4njYLbABVlek2ZY+BN3jU469lv4oXFg/plpqTmxBi3XP7p8pylvOn?=
 =?us-ascii?Q?ouVo01LIPlEbkguZFxxZS21Gu4ZOvFT6kdadDccA73VOH1NOwEfUGGS1Z8wK?=
 =?us-ascii?Q?rIuRXjrdlQ1aqAFLfEXpILzcq2jewNL4CMPdANH3sMrWgg7Ot/h94wcypnl9?=
 =?us-ascii?Q?dtna+v+AwGLrnkooMzBsg5h5pkukVhupx5mw4+3JV6M/jWVnJWowCGp+kihU?=
 =?us-ascii?Q?CDtP+nzaVf7mrTz6ELG8pdXFyGoYH6ru6ebF7paEfF5DKPhMlt9629ZikQjW?=
 =?us-ascii?Q?3ADt/ivrx6yVTIdnl2VgdmBofn92GdatGMu5GW8/4EkK3yEeshPBBPsr3r8g?=
 =?us-ascii?Q?o2BJrgLCc4N4SPFaTnnSnFGmyhoCkQLPt7ZnhI3SK/GJxjJ26efDngS/N2Id?=
 =?us-ascii?Q?VoyK+dURQNUJG9FuVJ5c1hUCTnXLDohB/VGrbZvNEHgMCSFmrmOyoVHBhqLy?=
 =?us-ascii?Q?4xK3MviTVtrPHd+uSL1pGUpRLZZZgjieFpzF9Brp+MrJMzW1DhKFwOsCpjAH?=
 =?us-ascii?Q?AfA8oTTfV+DChzjWKEqzHj+iH4Jfl1itSeD+N/VnPkjB/x/KaILZBpXrY4bB?=
 =?us-ascii?Q?5n4LswJXT9jqXiJKkfjcO53Jb9Qcp/2K4IqyHg0XurCEXvtSskGxuI2BHDWM?=
 =?us-ascii?Q?GZSdPBYJ9ngwHAxpAs5/6d78LMFMh+1RmpVcWsOMTGFSQAQHlaQuQ+MVqYO/?=
 =?us-ascii?Q?P2zxENjP8sHJFa188B6NMB00vg/rRBNMoz31sqhou1yIyYEijVQRojtzDbpB?=
 =?us-ascii?Q?flYDESXZscqhukbtnRjNoHIlqoURvQn5du3orlzOqbaoOPk8j6v8YSs9Di6y?=
 =?us-ascii?Q?GixqEua8vomiHZ+8NqQijHwtBuMD+UZkqcuVVzXFjxY6XmcuQb+D0aM+kA6b?=
 =?us-ascii?Q?xwIG4K3Llutk33jczo0XK45JbgkbqQBGvA3TNkoY02htE3y+c702prJlSTqj?=
 =?us-ascii?Q?E1FBetP7ZS4ISMWtEB0sCjpSLv5Ep/manzC8Boi6?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 3f0516dd-ffc8-4552-c08f-08dbff7a363f
X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB6733.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Dec 2023 03:34:16.5535
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: kt7M9pB4p0OD5xj4RE+vlS54QD6yRn1sLCmei5crj1l0UbzhU5mapSqPbbB7x46M8JKYHI3feavlf6Eqv9g76w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR11MB6368
X-OriginatorOrg: intel.com

Fabio M. De Francesco wrote:

[snip]

> 
> Cc: Ira Weiny <ira.weiny@intel.com>
> Signed-off-by: Fabio M. De Francesco <fabio.maria.de.francesco@linux.intel.com>
> ---
>  mm/memory.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/mm/memory.c b/mm/memory.c
> index 7d9f6b685032..88377a107fbe 100644
> --- a/mm/memory.c
> +++ b/mm/memory.c
> @@ -5852,7 +5852,7 @@ static int __access_remote_vm(struct mm_struct *mm, unsigned long addr,
>  			if (bytes > PAGE_SIZE-offset)
>  				bytes = PAGE_SIZE-offset;
>  
> -			maddr = kmap(page);
> +			maddr = kmap_local_page(page);
>  			if (write) {
>  				copy_to_user_page(vma, page, addr,
>  						  maddr + offset, buf, bytes);
> @@ -5861,8 +5861,7 @@ static int __access_remote_vm(struct mm_struct *mm, unsigned long addr,
>  				copy_from_user_page(vma, page, addr,
>  						    buf, maddr + offset, bytes);
>  			}
> -			kunmap(page);
> -			put_page(page);
> +			unmap_and_put_page(page, maddr);

Does this really have the same functionality?

Ira