Received-SPF: pass (google.com: domain of linux-kernel+bounces-2974-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <874cce7f-4545-450f-9d6b-4f3e3357281b@linux.alibaba.com>
Date: Mon, 18 Dec 2023 11:34:59 +0800
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] mm: migrate: fix getting incorrect page mapping during
 page migration
To: Matthew Wilcox <willy@infradead.org>
Cc: akpm@linux-foundation.org, david@redhat.com, ying.huang@intel.com,
 ziy@nvidia.com, xuyu@linux.alibaba.com, linux-mm@kvack.org,
 linux-kernel@vger.kernel.org
References: <e60b17a88afc38cb32f84c3e30837ec70b343d2b.1702641709.git.baolin.wang@linux.alibaba.com>
 <ZXxn/0oixJxxAnpF@casper.infradead.org>
 <ZXxqTjZR0OAvjaXr@casper.infradead.org>
From: Baolin Wang <baolin.wang@linux.alibaba.com>
In-Reply-To: <ZXxqTjZR0OAvjaXr@casper.infradead.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit


On 12/15/2023 11:01 PM, Matthew Wilcox wrote:
> On Fri, Dec 15, 2023 at 02:51:43PM +0000, Matthew Wilcox wrote:
>> I'm not saying no to this fix, but dump_mapping() is supposed to be
>> resilient against this.  Is the issue that 'dentry' is NULL, or is it
>> some field within dentry that is NULL?  eg, would this fix your
>> case?
> 
> Uh, dentry is an on-stack dentry.  So obviously it's a pointer within it
> that's NULL.  Maybe this, having stared at the implementation of %pd?

Yes, I think below check can avoid crash of dentry_name() used by '%pd'. 
Maybe we should also initialize on-stack dentry by
struct dentry dentry = { };

I can send a patch with your suggestion. Thanks.

> +++ b/fs/inode.c
> @@ -588,7 +588,8 @@ void dump_mapping(const struct address_space *mapping)
>          }
> 
>          dentry_ptr = container_of(dentry_first, struct dentry, d_u.d_alias);
> -       if (get_kernel_nofault(dentry, dentry_ptr)) {
> +       if (get_kernel_nofault(dentry, dentry_ptr) ||
> +           !dentry->d_parent || !dentry->d_name) {
>                  pr_warn("aops:%ps ino:%lx invalid dentry:%px\n",
>                                  a_ops, ino, dentry_ptr);
>                  return;