Received-SPF: pass (google.com: domain of linux-kernel+bounces-2990-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <cb93763e-28d3-402a-a5fa-34936646bc0a@ti.com>
Date: Mon, 18 Dec 2023 10:00:34 +0530
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
CC: <vkoul@kernel.org>, <dmaengine@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>,
        <srk@ti.com>, <vigneshr@ti.com>, <s-vadapalli@ti.com>
Subject: Re: [PATCH v2 3/4] dmaengine: ti: k3-udma-glue: Add function to
 request TX channel by ID
Content-Language: en-US
To: =?UTF-8?Q?P=C3=A9ter_Ujfalusi?= <peter.ujfalusi@gmail.com>
References: <20231212111011.1401641-1-s-vadapalli@ti.com>
 <20231212111011.1401641-4-s-vadapalli@ti.com>
 <800ccf2e-65cc-4524-8a42-1657a5906482@gmail.com>
 <4f13681a-dc13-4de2-a0d5-9f85a4c350d4@ti.com>
 <604657b5-0b88-4108-afd3-8cc88e10b16c@gmail.com>
From: Siddharth Vadapalli <s-vadapalli@ti.com>
In-Reply-To: <604657b5-0b88-4108-afd3-8cc88e10b16c@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit


On 17/12/23 16:48, Péter Ujfalusi wrote:
> 
> 
> On 15/12/2023 08:08, Siddharth Vadapalli wrote:
>>>>  err:
>>>> @@ -395,6 +410,40 @@ struct k3_udma_glue_tx_channel *k3_udma_glue_request_tx_chn(struct device *dev,
>>>>  }
>>>>  EXPORT_SYMBOL_GPL(k3_udma_glue_request_tx_chn);
>>>>  
>>>> +struct k3_udma_glue_tx_channel *
>>>> +k3_udma_glue_request_tx_chn_by_id(struct device *dev, struct k3_udma_glue_tx_channel_cfg *cfg,
>>>> +				  struct device_node *udmax_np, u32 thread_id)
>>>
>>> udmax_np is not dev->of_node ?
>>
>> I am not sure I fully understand the question. If you meant to ask if the driver
>> which uses this API will not have its device's of_node set to udmax_np, then yes
>> that's correct.
>>
>> The driver shall be probed over RPMsg-bus, due to which its device's of_node
>> will not be udmax_np. Additionally, the udmax_np is the device-tree node of one
>> of the DMA Controllers described in the device-tree. The driver shall obtain the
>> reference to the udmax_np node using the API:
>> of_find_compatible_node()
>> with the compatible to be passed to the above API being a part of the driver's
>> data. Thus, it is possible to specify which DMA Controller to use by specifying
>> the compatible in the driver's data. I hope that I have answered your question.
>> Please let me know otherwise.
> 
> I see, thank you for the detailed explanation!
> 
>> Thank you for reviewing the series. I will rename the API as mentioned above and
>> if the question you had above regarding the of_node has been addressed, I will
>> post the v3 series. Kindly let me know.
> 
> I don't have other open issues, thanks for the updates
> 

Thank you for the confirmation. I will implement your suggestions and post the
v3 series.

-- 
Regards,
Siddharth.