Received-SPF: pass (google.com: domain of linux-kernel+bounces-3009-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Mon, 18 Dec 2023 13:29:57 +0800
From: Huang Rui <ray.huang@amd.com>
To: Dmitry Osipenko <dmitry.osipenko@collabora.com>
Cc: "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>,
	"virtualization@lists.linux-foundation.org" <virtualization@lists.linux-foundation.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	David Airlie <airlied@redhat.com>,
	Gerd Hoffmann <kraxel@redhat.com>,
	Gurchetan Singh <gurchetansingh@chromium.org>,
	Chia-I Wu <olvaffe@gmail.com>,
	Daniel Vetter <daniel.vetter@ffwll.ch>,
	"Deucher, Alexander" <Alexander.Deucher@amd.com>,
	Xenia Ragiadakou <xenia.ragiadakou@amd.com>
Subject: Re: [PATCH] drm/virtio: add definition for venus capset
Message-ID: <ZX/Y1Rp0RoFdpi1Q@amd.com>
References: <20230915105918.3763061-1-ray.huang@amd.com>
 <a7b783c8-b1c8-90e3-b6c7-7fa8c6d24d21@collabora.com>
 <68470997-bb4c-3c11-98b5-aa75c52cbaea@collabora.com>
 <b79dcf75-c9e8-490e-644f-3b97d95f7397@collabora.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <b79dcf75-c9e8-490e-644f-3b97d95f7397@collabora.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?WsWxN8OiZ8CN80qBLhy/CnCG1uvnHi7CwX6hwY7wzVQCnDf+6oWEpGnFGq7g?=
 =?us-ascii?Q?O/8UBq8kC5gs8RLKx2iqyC+hzGvksFlClI051B5Of6zi6N/BxB+8lBa5HKcF?=
 =?us-ascii?Q?3KZYT1VSf0taISbwEIqb7nskRiBODS1a0I50XYzdSGs+O6488nlbJTxKd/66?=
 =?us-ascii?Q?YbSMaZIkNBsrmsRqc1wC7M91iy/3V0mcQyE+CU19vnMyWtR/UzJciwX1GjIG?=
 =?us-ascii?Q?5IX2E2jIHI+BWlOkG/j2Tn5h+TGta2wefve8HHHNpylLDXLiHW4JGaGqO7kn?=
 =?us-ascii?Q?hHTJJOvH8btqhN0FdAaI/y5mcYPkH7JpSEa+YiB/QgB1lGRxkhek1pEwVS0K?=
 =?us-ascii?Q?x8FXXe70mKWXHixIWewpE6qd9e602nGoTTQy5aeUVwM+TDaL22qLHnJSJKGD?=
 =?us-ascii?Q?Pm1tqCvu9WupcB8+LkwvnFDYYAs6q1P7noASaDpYuCRi9gwSZyiWIskIK79W?=
 =?us-ascii?Q?EA1XTk1A1RGJ5cK0xkrh1zjjEt5E2PpyVxrNmAxQQWC9qbQ0NYDS8eYUqdca?=
 =?us-ascii?Q?ljL0O47oCvNlEv60YejQaxvmJ5X8UyZ7Aylq6zTPKaThybsOOz4Oa0fYozO1?=
 =?us-ascii?Q?/hLpqV7VHHC6xEhxtWH3m69Yj2roObhYBP/Jvtn/Hq7Db5x9jpnXDe89dD1m?=
 =?us-ascii?Q?NN97qGDYfwF9tZcJUBlQabWLSJxAhGR1HpU8ADsZeefN3+AtZOBJRWKqFSJY?=
 =?us-ascii?Q?uzXstvn6SSc/WTpBZNFpCLUdBs8+cV4juHUxFDXlSAgwC3Pc+iQxh+NS6act?=
 =?us-ascii?Q?P+uC2DK9EEWGXc7yT8GX0gscUVNbXdBo5COTE4tcKxwv/iUncM8LIEyoDu0c?=
 =?us-ascii?Q?kQozQ8WWZ2wb7U0LR40Lqe3wjum4agwjmGg/xzGlexNB1/mckEsgl7f89MQw?=
 =?us-ascii?Q?z2M3sHhv3lGg3s1lcH3Ax2X4FjpPtxeya9KsJxfHOthorJX3TUsiBu7pq3qB?=
 =?us-ascii?Q?qF0lsQlU6bHTlSs1PHpAAPXSWmYdOmdNeuLr9gfqsnzw7E2RDbC7t27dBon8?=
 =?us-ascii?Q?CvBzjFGmUAhXHohcyTAvACaEJldkiF8N3Of6NRqPUC5t3bIRoOmaj9od/iBf?=
 =?us-ascii?Q?FK0fn/KgpupMcCBcjgXSzr5SOI90WGAXTNV40VV3/wTo0coOqhz7Pb0nT62p?=
 =?us-ascii?Q?XnllUvQ4CvMQ9S0htfbISHRamtkF/esiRU37TzOoYBZ+EMDM5BQLEuUOjx21?=
 =?us-ascii?Q?m2smQHq0Kt3+lg+m9tFXTPEZ+6kXjMdaJs4P8480E7PsgldGR3LiVrfKkCAi?=
 =?us-ascii?Q?PEqiSrXZiihdRII1lysqKKNDyBN1lSN4bSI2mlo88x05BssBpG0vXsWRsYWr?=
 =?us-ascii?Q?W4jlxIg4hO0rtMTsWZwlBQW/M/Rqwu/qfOSiGsb3WW8aDD87KX2QrwTYNP9X?=
 =?us-ascii?Q?QKVVVIVu6aDtrWeumGU4OFxm06AVw3AE9dqtCX4rYfg5vMDF83CLa3mMjoYc?=
 =?us-ascii?Q?nF1EcyZazXxjxSMUdfa2sifcD7mHjC1KoOOCnl+3m56vJbGYnZbX+5jQfYeR?=
 =?us-ascii?Q?91wH4JhWQ68Mptn10bsRnKfMKCq10/0/g+pYT1xzoC76tTlSgojMTjK/eHLt?=
 =?us-ascii?Q?VkgkIrnApI9fvnLJZD7WngV2Cy6uRlJA2r93JwCT?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c1c788d9-e276-40cf-b6cb-08dbff8a6c0a
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR12MB8690.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Dec 2023 05:30:18.7558
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 0YwqD54XtJKOw8EZdVa1Mo13dHI+jj6boHuaeOeZ5EQ353f1Zdp61XleT+aEL2mMcRFp7jOcaQQFiR/+du8cUQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB9422

On Sat, Dec 16, 2023 at 12:45:32AM +0800, Dmitry Osipenko wrote:
> On 11/19/23 06:46, Dmitry Osipenko wrote:
> > On 9/21/23 00:16, Dmitry Osipenko wrote:
> >> On 9/15/23 13:59, Huang Rui wrote:
> >>> This definition is used fro qemu, and qemu imports this marco in the
> >>> headers to enable venus for virtio gpu. So it should add it even kernel
> >>> doesn't use this.
> >>>
> >>> Signed-off-by: Huang Rui <ray.huang@amd.com>
> >>> ---
> >>>
> >>> Hi all,
> >>>
> >>> We would like to add a new definition for venus capset, it will be used for
> >>> qemu. Please see details on below discussion:
> >>>
> >>> https://lore.kernel.org/qemu-devel/b82982aa-5b9e-481e-9491-b9313877bcaa@daynix.com/
> >>>
> >>> Thanks,
> >>> Ray
> >>>
> >>>  include/uapi/linux/virtio_gpu.h | 2 ++
> >>>  1 file changed, 2 insertions(+)
> >>>
> >>> diff --git a/include/uapi/linux/virtio_gpu.h b/include/uapi/linux/virtio_gpu.h
> >>> index f556fde07b76..0e21f3998108 100644
> >>> --- a/include/uapi/linux/virtio_gpu.h
> >>> +++ b/include/uapi/linux/virtio_gpu.h
> >>> @@ -309,6 +309,8 @@ struct virtio_gpu_cmd_submit {
> >>>  
> >>>  #define VIRTIO_GPU_CAPSET_VIRGL 1
> >>>  #define VIRTIO_GPU_CAPSET_VIRGL2 2
> >>> +/* 3 is reserved for gfxstream */
> >>> +#define VIRTIO_GPU_CAPSET_VENUS 4
> >>
> >> Could you please add all other capsets, so we won't needed to do it
> >> again in the future
> > 
> > I've opened request to update virtio-spec with the corrected/updated
> > capsets https://github.com/oasis-tcs/virtio-spec/issues/182. I'm
> > expecting that it will take some time until spec change will be merged
> > and now leaning to apply this v1 patch to not hold the Venus work.
> > 
> > Gerd, do you have objections? R-b/ack?
> 
> Applied patch to misc-next with edited commit message. Updating spec
> taking much time, not worth to hold this change longer. We'll add the
> rest of capsets later on. Thanks, Rui!
> 

Thank you, Dmitry! I will update corresponding patch in qemu, and send v6
qemu patches.

Best Regards,
Ray