Received-SPF: pass (google.com: domain of linux-kernel+bounces-3015-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Mon, 18 Dec 2023 13:40:33 +0800
From: Jisheng Zhang <jszhang@kernel.org>
To: Jingbao Qiu <qiujingbao.dlmu@gmail.com>
Cc: a.zummo@towertech.it, alexandre.belloni@bootlin.com, robh+dt@kernel.org,
	krzysztof.kozlowski+dt@linaro.org, conor@kernel.org,
	conor+dt@kernel.org, chao.wei@sophgo.com, unicorn_wang@outlook.com,
	paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu,
	linux-rtc@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, dlan@gentoo.org
Subject: Re: [PATCH v2 0/3] riscv: rtc: sophgo: add rtc support for CV1800
Message-ID: <ZX/bUfSS1+32skCM@xhacker>
References: <20231217110952.78784-1-qiujingbao.dlmu@gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20231217110952.78784-1-qiujingbao.dlmu@gmail.com>

On Sun, Dec 17, 2023 at 07:09:49PM +0800, Jingbao Qiu wrote:
> This series adds rtc support for Sophgo CV1800.
> 
> Changes since v1
> - fix duplicate names in subject
> - using RTC replace RTC controller
> - improve the properties of dt-bindings
> - using `unevaluatedProperties` replace `additionalProperties`
> - dt-bindings passed the test
> - using `devm_platform_ioremap_resource()` replace
>   `platform_get_resource()` and `devm_ioremap_resource()`
> - fix random order of the code
> - fix wrong wrapping of the `devm_request_irq()` and map the flag with dts
> - using devm_clk_get_enabled replace `devm_clk_get()` and
>   `clk_prepare_enable()`
> - fix return style
> - add rtc clock calibration function
> - use spinlock when write register on read/set time
> 
> Jingbao Qiu (3):
>   dt-bindings: rtc: sophgo: add RTC support for Sophgo CV1800 series SoC
>   rtc: sophgo: add rtc support for Sophgo CV1800 SoC
>   riscv: dts: sophgo: add rtc dt node for CV1800

AFAICT, the rtc subsystem supports not only RTC function but also
power/reboot controller, so modeling the rtc subsystem as RTC only doesn't
match the HW. I expect a mfd here.

> 
>  .../bindings/rtc/sophgo,cv1800-rtc.yaml       |  47 ++
>  arch/riscv/boot/dts/sophgo/cv1800b.dtsi       |   7 +
>  drivers/rtc/Kconfig                           |   6 +
>  drivers/rtc/Makefile                          |   1 +
>  drivers/rtc/rtc-cv1800.c                      | 400 ++++++++++++++++++
>  5 files changed, 461 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/rtc/sophgo,cv1800-rtc.yaml
>  create mode 100644 drivers/rtc/rtc-cv1800.c
> 
> -- 
> 2.25.1
>