Received-SPF: pass (google.com: domain of linux-kernel+bounces-3066-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Date: Mon, 18 Dec 2023 07:53:13 +0100
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Chunyan Zhang <chunyan.zhang@unisoc.com>
Cc: "Rafael J . Wysocki" <rafael@kernel.org>,
	LKML <linux-kernel@vger.kernel.org>, Jing Xia <jing.xia@unisoc.com>,
	Jing Xia <jing.xia.mail@gmail.com>,
	Xuewen Yan <xuewen.yan@unisoc.com>, Ke Wang <ke.wang@unisoc.com>,
	Chunyan Zhang <zhang.lyra@gmail.com>
Subject: Re: [PATCH] class: fix use-after-free in class_register()
Message-ID: <2023121858-slider-trustful-44a4@gregkh>
References: <20231218024403.1076134-1-chunyan.zhang@unisoc.com>
 <2023121830-proxy-washed-ae4d@gregkh>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <2023121830-proxy-washed-ae4d@gregkh>

On Mon, Dec 18, 2023 at 07:52:18AM +0100, Greg Kroah-Hartman wrote:
> On Mon, Dec 18, 2023 at 10:44:03AM +0800, Chunyan Zhang wrote:
> > From: Jing Xia <jing.xia@unisoc.com>
> > 
> > The lock_class_key is still registered and can be found in
> > lock_keys_hash hlist after subsys_private is freed in error
> > handler path.A task who iterate over the lock_keys_hash
> > later may cause use-after-free.So fix that up and unregister
> > the lock_class_key before kfree(cp).
> 
> What task iterates over all hashes?
> 
> And can you put ' ' after your '.'?
> 
> And how was this found?

And more importantly, how was this tested?

thanks,

greg k-h