Received: by 2002:a05:7412:b112:b0:f9:3106:f1c0 with SMTP id az18csp85992rdb; Sun, 17 Dec 2023 22:54:37 -0800 (PST) X-Google-Smtp-Source: AGHT+IHfy6OKsyfa/Pq5LkIhJSAoTjhLqF26q1aURmKY+FBp6Uh4DxDxlKimDMgwC+NbATIuYGcr X-Received: by 2002:a05:6214:2405:b0:67f:1b59:588c with SMTP id fv5-20020a056214240500b0067f1b59588cmr6292636qvb.108.1702882476911; Sun, 17 Dec 2023 22:54:36 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702882476; cv=none; d=google.com; s=arc-20160816; b=Azw1gk2orbqtutv5sWdj2JsjAx6SQ+BU7ZjazpBSroydEvLrJZEk1E0iMd75ChDUdG XAvnR4iftxIgaiyfeqURQrycUfAl3EPijPae9Y4uOaFW9emoAsjRPLm898klRaFNK96o cwnoN1VoVdx5PAKHg0ynmFA9zuBTQzse0/PSkFLHGHIJtfz87C1AB5m7QzDGs71u62WH BMO5RajhrFlYOsDnu41mO0yMzNPSWHRvmHw9Zfsu+QDwh6/B7Xj0XKVX40E2Xx/JvmYw 8PpwWGpOWFI5eqtopefzf+mgqwD2mbJcoJaUE6SxaUWymyQ/CzGYp6ZYfErK/+zyAhLm E+/Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=ooBu2GeZi9lyJ1h1Vz+NcYi3BWhSuP/Z5vNgPFkWa48=; fh=tg6IlgxB4zzEgcDs3My+TAoclDht2V20wP9Lk5qqw54=; b=XuB0Kc9c64EczhaqV0TLaY6E9/LfyiL7n3OdE1xmW0U9OkIJw/DP8wywDP7I/b98v2 QQwDqdm/iQQb2W2KoKbHDbPy/65i9ZsLMOHr3KdXz/SOXRnb8k5t4Nl/6E50dJ7VTBSY YyvY/EeCWEa1J4a+mqq8/bkcENCyzfWm5FHB2sAKfCEWwVYZfKQTcXZECMLDqUJl0s4a dvE4wzSZEdQ8UcB+QjvK2HILsTaFwDsMYq2DRm5GPZZQJQLrmViB9B84E33Ebm47rqrz awu0sqTnXEe0IM7acvDnbG238N7haAaiFTNSphjqWq5S2agesiGT5VH1YfLQyfjgL7df WOOA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=TEZZF3xe; spf=pass (google.com: domain of linux-kernel+bounces-3069-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-3069-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id s16-20020a0cb310000000b0067a8bf10affsi5738304qve.220.2023.12.17.22.54.36 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 17 Dec 2023 22:54:36 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-3069-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=TEZZF3xe; spf=pass (google.com: domain of linux-kernel+bounces-3069-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-3069-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 563871C22344 for ; Mon, 18 Dec 2023 06:54:36 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 03BEAD272; Mon, 18 Dec 2023 06:54:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="TEZZF3xe" X-Original-To: linux-kernel@vger.kernel.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2013DDF41; Mon, 18 Dec 2023 06:54:12 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2041BC433C7; Mon, 18 Dec 2023 06:54:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1702882452; bh=AwnwLeZjuA8ssS4thTHCovTIbXMTSmXprhrXHbecjl8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=TEZZF3xekE0G2AF/ZrrBlozkVu5GPmdfy2ImhsFGKGa0e3JF7U61gp3gkTBE6zDdL pqjHX0POMD4J9dp7bMHagTdUFtHCkfxIIcfF0CwCySNqqgMWFiwefj0jSLktvXXcrJ FHBo1derxaHMUe6g90afkJyeWSOYDKZzQiAooalY= Date: Mon, 18 Dec 2023 07:54:10 +0100 From: Greg KH To: Shuai Xue Cc: bp@alien8.de, rafael@kernel.org, wangkefeng.wang@huawei.com, tanxiaofei@huawei.com, mawupeng1@huawei.com, tony.luck@intel.com, linmiaohe@huawei.com, naoya.horiguchi@nec.com, james.morse@arm.com, will@kernel.org, jarkko@kernel.org, linux-acpi@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, akpm@linux-foundation.org, linux-edac@vger.kernel.org, acpica-devel@lists.linuxfoundation.org, stable@vger.kernel.org, x86@kernel.org, justin.he@arm.com, ardb@kernel.org, ying.huang@intel.com, ashish.kalra@amd.com, baolin.wang@linux.alibaba.com, tglx@linutronix.de, mingo@redhat.com, dave.hansen@linux.intel.com, lenb@kernel.org, hpa@zytor.com, robert.moore@intel.com, lvying6@huawei.com, xiexiuqi@huawei.com, zhuo.song@linux.alibaba.com Subject: Re: [PATCH v10 3/4] mm: memory-failure: move memory_failure() return value documentation to function declaration Message-ID: <2023121805-wrongness-whinny-8f41@gregkh> References: <20221027042445.60108-1-xueshuai@linux.alibaba.com> <20231218064521.37324-4-xueshuai@linux.alibaba.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231218064521.37324-4-xueshuai@linux.alibaba.com> On Mon, Dec 18, 2023 at 02:45:20PM +0800, Shuai Xue wrote: > Part of return value comments for memory_failure() were originally > documented at the call site. Move those comments to the function > declaration to improve code readability and to provide developers with > immediate access to function usage and return information. > > Signed-off-by: Shuai Xue > --- > arch/x86/kernel/cpu/mce/core.c | 9 +-------- > mm/memory-failure.c | 9 ++++++--- > 2 files changed, 7 insertions(+), 11 deletions(-) > This is not the correct way to submit patches for inclusion in the stable kernel tree. Please read: https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html for how to do this properly.