Received-SPF: pass (google.com: domain of linux-kernel+bounces-3072-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Precedence: bulk
MIME-Version: 1.0
References: <cover.1702822744.git.u.kleine-koenig@pengutronix.de> <94780e5a414b20b6effa1e87208c14620c854e88.1702822744.git.u.kleine-koenig@pengutronix.de>
In-Reply-To: <94780e5a414b20b6effa1e87208c14620c854e88.1702822744.git.u.kleine-koenig@pengutronix.de>
From: Markus Mayer <mmayer@broadcom.com>
Date: Sun, 17 Dec 2023 22:56:32 -0800
Message-ID: <CAGt4E5uvRGq9Cw74T1kWNT0nyPt_R5aGvt9EE1XRkVQGH1tPJw@mail.gmail.com>
Subject: Re: [PATCH 01/15] memory: brcmstb_dpfe: Convert to platform remove
 callback returning void
To: =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= <u.kleine-koenig@pengutronix.de>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>, kernel@pengutronix.de, 
	Broadcom internal kernel review list <bcm-kernel-feedback-list@broadcom.com>, 
	Florian Fainelli <florian.fainelli@broadcom.com>, linux-arm-kernel@lists.infradead.org, 
	linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Sun, 17 Dec 2023 at 06:30, Uwe Kleine-K=C3=B6nig
<u.kleine-koenig@pengutronix.de> wrote:
>
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is ignored (apart
> from emitting a warning) and this typically results in resource leaks.
>
> To improve here there is a quest to make the remove callback return
> void. In the first step of this quest all drivers are converted to
> .remove_new(), which already returns void. Eventually after all drivers
> are converted, .remove_new() will be renamed to .remove().
>
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.
>
> Signed-off-by: Uwe Kleine-K=C3=B6nig <u.kleine-koenig@pengutronix.de>
> ---
>  drivers/memory/brcmstb_dpfe.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/memory/brcmstb_dpfe.c b/drivers/memory/brcmstb_dpfe.=
c
> index a7ab3d377206..5028467b2dc9 100644
> --- a/drivers/memory/brcmstb_dpfe.c
> +++ b/drivers/memory/brcmstb_dpfe.c
> @@ -909,13 +909,11 @@ static int brcmstb_dpfe_probe(struct platform_devic=
e *pdev)
>         return ret;
>  }
>
> -static int brcmstb_dpfe_remove(struct platform_device *pdev)
> +static void brcmstb_dpfe_remove(struct platform_device *pdev)
>  {
>         struct brcmstb_dpfe_priv *priv =3D dev_get_drvdata(&pdev->dev);
>
>         sysfs_remove_groups(&pdev->dev.kobj, priv->dpfe_api->sysfs_attrs)=
;
> -
> -       return 0;
>  }
>
>  static const struct of_device_id brcmstb_dpfe_of_match[] =3D {
> @@ -936,7 +934,7 @@ static struct platform_driver brcmstb_dpfe_driver =3D=
 {
>                 .of_match_table =3D brcmstb_dpfe_of_match,
>         },
>         .probe =3D brcmstb_dpfe_probe,
> -       .remove =3D brcmstb_dpfe_remove,
> +       .remove_new =3D brcmstb_dpfe_remove,
>         .resume =3D brcmstb_dpfe_resume,
>  };

Acked-by: Markus Mayer <mmayer@broadcom.com>