Received: by 2002:a05:7412:b112:b0:f9:3106:f1c0 with SMTP id az18csp122625rdb; Mon, 18 Dec 2023 00:41:54 -0800 (PST) X-Google-Smtp-Source: AGHT+IGMgHv/gWgDJ6y7hKA8Nh5oKEHirHNyd45trOoxnszoeM17lshSOEb6LRnX8olR8GkkZWEB X-Received: by 2002:a05:6a20:9149:b0:18b:92b3:7c80 with SMTP id x9-20020a056a20914900b0018b92b37c80mr21538176pzc.22.1702888914220; Mon, 18 Dec 2023 00:41:54 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702888914; cv=none; d=google.com; s=arc-20160816; b=QfmKhINiJo7NnCplYYuNZ5yd5tsvt1V4PMYhhsNyAj20iMkqeLSarxJYfRrv90/+2T UmYU2y7/4jKFNkbbOS3fHXQSLrNkhgdpsaD2zvOQt6uBjSfpP6loFTwBAO3UX7z5kZwa PDtOmrno332XM4Rmr8/4SMDp9IRayGuVl+0tuJKjenkJhJ2H5IqQ1yBX8XTcy9vI7yPL jUzUnm9oMSvr+3rmdsV1bkzEEVSHokBuaDMDlw394MS3wBRebX+l6nhvdpoT1iQaqKGh bw90ZqJzl7fbB23bIuUT+iw3UrxXImDtpB7y17nn0m9dih9huVMxt4+88JOJi0JDVW2i FbfQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id:dkim-signature; bh=ugssdrOzw4QMy9NRD6lOuOu5cH2OatnY7ktojHy0Rcs=; fh=5gysOgds3QX4D8ISnXEOkk7az3lEMnLQEyoXsR95QWE=; b=RpvgKSl3N1DrXHa+SaISKDqaTrCncGmhktyAHxBKua+/7xnU+siEouzuveixFLblhK Dda4zL8t0Qifh4+QIwtV70bDI9PFRKU+BQ8hw3k30grnHSi831J7wfr+W5q2lBXI9TYn dYwWHd8bqf3+JQSo6A8Zv8MLb9d7a+3ZLZYDLg4YaumlFqOj167SQv5LXGtzNXNGmSQC sh/UQRiHJFLBugsuDyOQvYeCtRvFYwEyHA3AYJLy7cUxyBlcrsvJW0iOiZXguLYnhuu9 b4UzM+bTCCjbSj4MCQ52A7V5RwgsjmU9ZQQhd7pKzFG7/wBhVXUXfWQ3jBUaK23htXur +k+w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ibm.com header.s=pp1 header.b=YjyFznB0; spf=pass (google.com: domain of linux-kernel+bounces-3176-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-3176-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id p5-20020a17090a2d8500b0028b7bdc21c6si1736438pjd.96.2023.12.18.00.41.53 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Dec 2023 00:41:54 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-3176-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@ibm.com header.s=pp1 header.b=YjyFznB0; spf=pass (google.com: domain of linux-kernel+bounces-3176-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-3176-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=NONE dis=NONE) header.from=ibm.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id DA7D4283342 for ; Mon, 18 Dec 2023 08:41:53 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 121D010944; Mon, 18 Dec 2023 08:41:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b="YjyFznB0" X-Original-To: linux-kernel@vger.kernel.org Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C7B881118F; Mon, 18 Dec 2023 08:41:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.ibm.com Received: from pps.filterd (m0353722.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 3BI8IlH0007764; Mon, 18 Dec 2023 08:41:37 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=ugssdrOzw4QMy9NRD6lOuOu5cH2OatnY7ktojHy0Rcs=; b=YjyFznB0xoS5xJZbwij4yffG3LSUEedI9zr1iU+YdYOxDevXfqRvKTxjZcAZ3fNV2ww0 YQEqPe9VXyFZ+S55Ata5Ei33O/jzU/uaTH2iH5g8T5/90EEF0SeneTdMxObBS/ngA8ud fzFV4H6Os9Y/7CNXAeel2QDK4uovdURAppsw5UTWcg2dZpovS418uLR7NfwnAboNECmD RtQX7AJ4Pt6T50pI6XHq7EjoTN526c9XKBhUEynzo9uCeLcGqPkLsMmB20I2qytdt+UK w6CskNw0lJVnR39mbA0htqkljEiodkHEb4JHAcAfYxZm71alB7+luJzNBNcqWuttLMH9 HA== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3v2jexgmef-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 18 Dec 2023 08:41:37 +0000 Received: from m0353722.ppops.net (m0353722.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 3BI8KUkm012376; Mon, 18 Dec 2023 08:41:36 GMT Received: from ppma12.dal12v.mail.ibm.com (dc.9e.1632.ip4.static.sl-reverse.com [50.22.158.220]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3v2jexgmdy-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 18 Dec 2023 08:41:36 +0000 Received: from pps.filterd (ppma12.dal12v.mail.ibm.com [127.0.0.1]) by ppma12.dal12v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 3BI5HGEZ029707; Mon, 18 Dec 2023 08:41:35 GMT Received: from smtprelay06.fra02v.mail.ibm.com ([9.218.2.230]) by ppma12.dal12v.mail.ibm.com (PPS) with ESMTPS id 3v1p7s7vn5-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 18 Dec 2023 08:41:35 +0000 Received: from smtpav04.fra02v.mail.ibm.com (smtpav04.fra02v.mail.ibm.com [10.20.54.103]) by smtprelay06.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 3BI8fWmS37159388 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 18 Dec 2023 08:41:32 GMT Received: from smtpav04.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id C12792004D; Mon, 18 Dec 2023 08:41:32 +0000 (GMT) Received: from smtpav04.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id B19AA2004E; Mon, 18 Dec 2023 08:41:31 +0000 (GMT) Received: from [9.171.88.206] (unknown [9.171.88.206]) by smtpav04.fra02v.mail.ibm.com (Postfix) with ESMTP; Mon, 18 Dec 2023 08:41:31 +0000 (GMT) Message-ID: Date: Mon, 18 Dec 2023 09:41:31 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v6 02/10] net/smc: introduce sub-functions for smc_clc_send_confirm_accept() Content-Language: en-US To: Wen Gu , wenjia@linux.ibm.com, hca@linux.ibm.com, gor@linux.ibm.com, agordeev@linux.ibm.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, kgraul@linux.ibm.com, jaka@linux.ibm.com Cc: borntraeger@linux.ibm.com, svens@linux.ibm.com, alibuda@linux.alibaba.com, tonylu@linux.alibaba.com, raspl@linux.ibm.com, schnelle@linux.ibm.com, guangguan.wang@linux.alibaba.com, linux-s390@vger.kernel.org, netdev@vger.kernel.org, "linux-kernel@vger.kernel.org" References: <1702371151-125258-1-git-send-email-guwen@linux.alibaba.com> <1702371151-125258-3-git-send-email-guwen@linux.alibaba.com> From: Alexandra Winter In-Reply-To: <1702371151-125258-3-git-send-email-guwen@linux.alibaba.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: JB3rLZKB4XGR38mBAPDiYcAkinyTnLoO X-Proofpoint-GUID: p0fbOBz3xxvlq6aK5n13wxWBCoQe8m03 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.997,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-12-18_04,2023-12-14_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 lowpriorityscore=0 suspectscore=0 phishscore=0 spamscore=0 priorityscore=1501 bulkscore=0 mlxscore=0 malwarescore=0 impostorscore=0 mlxlogscore=886 clxscore=1015 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000 definitions=main-2312180061 On 12.12.23 09:52, Wen Gu wrote: > There is a large if-else block in smc_clc_send_confirm_accept() and it > is better to split it into two sub-functions. > > Suggested-by: Alexandra Winter > Signed-off-by: Wen Gu > --- Reviewed-by: Alexandra Winter