Received-SPF: pass (google.com: domain of linux-kernel+bounces-3195-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Precedence: bulk
MIME-Version: 1.0
Date: Mon, 18 Dec 2023 09:50:21 +0100
From: Michael Walle <michael@walle.cc>
To: =?UTF-8?Q?TY=5FChang=5B=E5=BC=B5=E5=AD=90=E9=80=B8=5D?=
 <tychang@realtek.com>
Cc: Andy Shevchenko <andy@kernel.org>, Linus Walleij
 <linus.walleij@linaro.org>, Bartosz Golaszewski <brgl@bgdev.pl>, Rob Herring
 <robh+dt@kernel.org>, Krzysztof Kozlowski
 <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>,
 linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
 linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/2] Add GPIO support for Realtek DHC(Digital Home
 Center) RTD SoCs.
In-Reply-To: <be8db58b51d04043a255a702a08cdaba@realtek.com>
References: <20231207100723.15015-1-tychang@realtek.com>
 <20231207100723.15015-3-tychang@realtek.com>
 <ZXHMbZRXLXGa_tq8@smile.fi.intel.com>
 <989146448858478b975c66899b8f3fed@realtek.com>
 <ZXm0MIub8X2q_lnp@smile.fi.intel.com>
 <23574204547646779d02f0109c20b3ff@realtek.com>
 <ZXsKAyIlY3y3tgUi@smile.fi.intel.com>
 <0f0b3b65a838aea6797ae78c47d6af49@walle.cc>
 <ZXsV96xhuvVSyc1f@smile.fi.intel.com>
 <be8db58b51d04043a255a702a08cdaba@realtek.com>
Message-ID: <3dd3a101e61f5a8f8931114ddc80cecf@walle.cc>
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit

Hi,

> I have looked into regmap-irq, it appears that using the default irq
> thread_fn(regmap_irq_thread) is required. However, due to hardware 
> limitation,
> we need to inspect the IRQ_TYPE to determine whether to manage the irq 
> within
> the irq handler. I think our irq portion does not perfectly fit the 
> regmap-irq.
> Moreover, it seems that the gpio-regmap.c file needs to be modified if 
> the GPIO driver
> requires debounce settings. I think the gpio-regmap may not be 
> appropriate for our driver.
> Do you have any suggestions?

Can't say anything regarding the interrupt handling but adding literally
one line to gpio-regmap shouldn't be a reason not to use it.

-michael