Received-SPF: pass (google.com: domain of linux-kernel+bounces-3228-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Mon, 18 Dec 2023 17:10:23 +0800
From: Hangbin Liu <liuhangbin@gmail.com>
To: Dmitry Safonov <dima@arista.com>
Cc: Shuah Khan <shuah@kernel.org>, David Ahern <dsahern@kernel.org>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Salam Noureddine <noureddine@arista.com>,
	Bob Gilligan <gilligan@arista.com>, linux-kernel@vger.kernel.org,
	linux-kselftest@vger.kernel.org, netdev@vger.kernel.org,
	Dmitry Safonov <0x7f454c46@gmail.com>
Subject: Re: [PATCH 08/12] selftests/net: Add TCP_REPAIR TCP-AO tests
Message-ID: <ZYAMf-vwntB1FveW@Laptop-X1>
References: <20231215-tcp-ao-selftests-v1-0-f6c08180b985@arista.com>
 <20231215-tcp-ao-selftests-v1-8-f6c08180b985@arista.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20231215-tcp-ao-selftests-v1-8-f6c08180b985@arista.com>

On Fri, Dec 15, 2023 at 02:36:22AM +0000, Dmitry Safonov wrote:
> The test plan is:
> 1. check that TCP-AO connection may be restored on another socket
> 2. check restore with wrong send/recv ISN (checking that they are
>    part of MAC generation)
> 3. check restore with wrong SEQ number extension (checking that
>    high bytes of it taken into MAC generation)
> 
> Sample output expected:
> > # ./restore_ipv4
> > 1..20
> > # 1412[lib/setup.c:254] rand seed 1686610825
> > TAP version 13
> > ok 1 TCP-AO migrate to another socket: server alive
> > ok 2 TCP-AO migrate to another socket: post-migrate connection is alive
> > ok 3 TCP-AO migrate to another socket: counter TCPAOGood increased 23 => 44
> > ok 4 TCP-AO migrate to another socket: counter TCPAOGood increased 22 => 42
> > ok 5 TCP-AO with wrong send ISN: server couldn't serve
> > ok 6 TCP-AO with wrong send ISN: post-migrate connection is broken
> > ok 7 TCP-AO with wrong send ISN: counter TCPAOBad increased 0 => 4
> > ok 8 TCP-AO with wrong send ISN: counter TCPAOBad increased 0 => 3
> > ok 9 TCP-AO with wrong receive ISN: server couldn't serve
> > ok 10 TCP-AO with wrong receive ISN: post-migrate connection is broken
> > ok 11 TCP-AO with wrong receive ISN: counter TCPAOBad increased 4 => 8
> > ok 12 TCP-AO with wrong receive ISN: counter TCPAOBad increased 5 => 10
> > ok 13 TCP-AO with wrong send SEQ ext number: server couldn't serve
> > ok 14 TCP-AO with wrong send SEQ ext number: post-migrate connection is broken
> > ok 15 TCP-AO with wrong send SEQ ext number: counter TCPAOBad increased 9 => 10
> > ok 16 TCP-AO with wrong send SEQ ext number: counter TCPAOBad increased 11 => 19
> > ok 17 TCP-AO with wrong receive SEQ ext number: post-migrate connection is broken
> > ok 18 TCP-AO with wrong receive SEQ ext number: server couldn't serve
> > ok 19 TCP-AO with wrong receive SEQ ext number: counter TCPAOBad increased 10 => 18
> > ok 20 TCP-AO with wrong receive SEQ ext number: counter TCPAOBad increased 20 => 23
> > # Totals: pass:20 fail:0 xfail:0 xpass:0 skip:0 error:0
> 
> Signed-off-by: Dmitry Safonov <dima@arista.com>

Tested-by: Hangbin Liu <liuhangbin@gmail.com>