Received-SPF: pass (google.com: domain of linux-kernel+bounces-3232-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Mon, 18 Dec 2023 17:12:10 +0800
From: Hangbin Liu <liuhangbin@gmail.com>
To: Dmitry Safonov <dima@arista.com>
Cc: Shuah Khan <shuah@kernel.org>, David Ahern <dsahern@kernel.org>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Salam Noureddine <noureddine@arista.com>,
	Bob Gilligan <gilligan@arista.com>, linux-kernel@vger.kernel.org,
	linux-kselftest@vger.kernel.org, netdev@vger.kernel.org,
	Dmitry Safonov <0x7f454c46@gmail.com>
Subject: Re: [PATCH 11/12] selftests/net: Add TCP-AO selfconnect/simultaneous
 connect test
Message-ID: <ZYAM6ioeJEq5FnJf@Laptop-X1>
References: <20231215-tcp-ao-selftests-v1-0-f6c08180b985@arista.com>
 <20231215-tcp-ao-selftests-v1-11-f6c08180b985@arista.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20231215-tcp-ao-selftests-v1-11-f6c08180b985@arista.com>

On Fri, Dec 15, 2023 at 02:36:25AM +0000, Dmitry Safonov wrote:
> Check that a rare functionality of TCP named self-connect works with
> TCP-AO. This "under the cover" also checks TCP simultaneous connect
> (TCP_SYN_RECV socket state), which would be harder to check other ways.
> 
> In order to verify that it's indeed TCP simultaneous connect, check
> the counters TCPChallengeACK and TCPSYNChallenge.
> 
> Sample of the output:
> > # ./self-connect_ipv6
> > 1..4
> > # 1738[lib/setup.c:254] rand seed 1696451931
> > TAP version 13
> > ok 1 self-connect(same keyids): connect TCPAOGood 0 => 24
> > ok 2 self-connect(different keyids): connect TCPAOGood 26 => 50
> > ok 3 self-connect(restore): connect TCPAOGood 52 => 97
> > ok 4 self-connect(restore, different keyids): connect TCPAOGood 99 => 144
> > # Totals: pass:4 fail:0 xfail:0 xpass:0 skip:0 error:0
> 
> Signed-off-by: Dmitry Safonov <dima@arista.com>

Tested-by: Hangbin Liu <liuhangbin@gmail.com>