Received: by 2002:ac8:6d01:0:b0:423:7e07:f8e4 with SMTP id o1csp6625439qtt; Mon, 18 Dec 2023 01:51:57 -0800 (PST) X-Google-Smtp-Source: AGHT+IG6iJ1mr/+jNXUMJjbWQbwBCjASe7EKGFFMq+4ODkUt+ehCGtiXsIAn/y7CWLpB00ZZVkoT X-Received: by 2002:a05:6808:208a:b0:3b8:4d71:6cd1 with SMTP id s10-20020a056808208a00b003b84d716cd1mr18554145oiw.8.1702893117653; Mon, 18 Dec 2023 01:51:57 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702893117; cv=none; d=google.com; s=arc-20160816; b=F/+M9/SUhNZHLYlbHUAK8cSaCva8L+nJ6V5vpvJMqp0sgp0NBaybkNraTj0/2sTklL 8b+v0zp8Hh9908B+hsqOhtoJFuuZxbv6pZCL7MaYaIbJWqLRoTYoDoNiU330gBAYa5yv ELZTNNemGMxsvhaQuzzZCqAIIYDHFxEndtVxn2/wpyCN4L6XnB0+8Ps9FK6Cj5ibYW6G 0jf3CUGFuzsyK+PZiCtCaI0wsc7JFuNt/9HVClOPBBdAU9RJASiiUFKdGvmXiuXBwPiz prCJTraUGyZQ6uovd+0KSah9zOc19n7g3D6Z/0JM1k/SJIrnX32hjiqP8/sv8V3WgwuF ATNA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:date:message-id :dkim-signature; bh=UXzapRBF0XP9dqhOwn1urD+qb34Omrr0zBsGvVTpYtU=; fh=s6UZNsgxVNe5XaPjfaRFtaRjWJrvrz5Y4otq1DgEmQE=; b=W9zAiKlVTr2h8EuKJC26lGXTdWJRY7WxMhbaXylwLWDiOlp3x6Xn2p+TCGFdFK4L51 RyMetI0GGTSoQTWWONY3cpt5dh7V7HPX1/VygH5hQ7xzYrjmky/jRDlxm7FsKdr0QOo+ L4dYGI9FvE1nzODb6CwFM29pCGHea6bbiU8Ym+SrhdxU4iVdKK4tQlSJ83Wyo+ogTHQw HYdtsa/NMyhigic2sY1/TKfzSgzZTT7TTkbd7UqNgMcyxDQBVudfba0e4R/U6Gh7MGJN rgB7k5zimulQ8NUxxxTS+U3R6HEcdgt89E4KR9pfrupkS+BsYNGYE5RVOzblBlsOgtkW g1eA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=BxCsjQnu; spf=pass (google.com: domain of linux-kernel+bounces-3274-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-3274-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id o12-20020a63e34c000000b005bd2b19dfc4si17650528pgj.493.2023.12.18.01.51.57 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Dec 2023 01:51:57 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-3274-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=BxCsjQnu; spf=pass (google.com: domain of linux-kernel+bounces-3274-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-3274-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 642A1281EF5 for ; Mon, 18 Dec 2023 09:51:57 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id F3E1412E41; Mon, 18 Dec 2023 09:51:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="BxCsjQnu" X-Original-To: linux-kernel@vger.kernel.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 21C0C12B61; Mon, 18 Dec 2023 09:51:42 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BECF6C433C8; Mon, 18 Dec 2023 09:51:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1702893102; bh=0ltLchd8OdyqGdbUKNCnj2CSZ8BI8m8JXNh7/DpT4q4=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=BxCsjQnuJnhh0O1R4P1jparwYYvwuJzUuts6R9qqR4wY0ZeR5eIdS4bVLOC3EMYJJ BoNRgH9yCu1zFqd3LLzgK0zPtMOLNLbFZHNMmde2Pk9uWDlZcyYUwWCoGkWamIj7z+ 6rpUoxGi/7Dezk78J9tb+fqCtwrVgkcgKlv4uAYpoF3EewrSfEDGhTfzhUFIDrJCpj /rkjWbHMaVlrNZ0o5NVjhXyj6Av1WNDiETUSkftHjyCb/1JHmJmwomRMHYhW23/dPF a6basN5WJgoh0KWx5ED+pMlx2XZ+osDMzmdwFSeSiaUlHW4oCGvwgJVT6ls7VRD6tS +zPJRqAvMhajw== Message-ID: <572219b1-c528-475f-9219-8027a3790563@kernel.org> Date: Mon, 18 Dec 2023 18:51:40 +0900 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 5/5] sd: only call disk_clear_zoned when needed Content-Language: en-US To: Christoph Hellwig , Jens Axboe Cc: Paolo Bonzini , Stefan Hajnoczi , "Martin K. Petersen" , dm-devel@lists.linux.dev, linux-kernel@vger.kernel.org, virtualization@lists.linux.dev, linux-nvme@lists.infradead.org, linux-scsi@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net References: <20231217165359.604246-1-hch@lst.de> <20231217165359.604246-6-hch@lst.de> From: Damien Le Moal Organization: Western Digital Research In-Reply-To: <20231217165359.604246-6-hch@lst.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 2023/12/18 1:53, Christoph Hellwig wrote: > disk_clear_zoned only needs to be called when a device reported zone > managed mode first and we clear it. Add a check so that disk_clear_zoned > isn't called on devices that were never zoned. > > This avoids a fairly expensive queue freezing when revalidating > conventional devices. > > Signed-off-by: Christoph Hellwig Looks good. Reviewed-by: Damien Le Moal -- Damien Le Moal Western Digital Research