Received: by 2002:ac8:6d01:0:b0:423:7e07:f8e4 with SMTP id o1csp6634016qtt; Mon, 18 Dec 2023 02:11:53 -0800 (PST) X-Google-Smtp-Source: AGHT+IF0woniELex9OXsyMAoZn+bJ0gCL2Zaw80cK+pKBcq1WyUOMHsoZbTub3q7FCnj4tY+5owp X-Received: by 2002:a05:6a21:8182:b0:18f:97c:b9ee with SMTP id pd2-20020a056a21818200b0018f097cb9eemr5962572pzb.72.1702894313435; Mon, 18 Dec 2023 02:11:53 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702894313; cv=none; d=google.com; s=arc-20160816; b=i0d0K1gyzPLT8doAduHJ83zfM3exuiPiQ+czaCy4KTGEYMitehrAtHjY5zBB/PT+TT 0o9gLZGEogA9bJajnXW7kNpxEZc0Adl/YYM2L7cdUd7TyxZCHyGCKIMz4JWvihMvWNGt /okHqTLq/3q1qvjfu1TUeD6dtTlTgNLRC7nFNtoK/YYyeIsq+7P/TI+BWgsPVqtNKiCx 1fSJF5fnKWYU1y82eMbOiYpRn86xyEbC/AJn3KAL63UWg3dazPNUwgNQ9+2XBqDq+mcE Q6zbVATwxMDkl2GBRYOTLadOnZBtLksxWtIFXVSTaC/dqkdrti0f6KjiMb/C2MNr8qbm Fjtw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date; bh=aPXxWe48z5dhU1TX2H4ycgYjN+aJ6IVmtasnGEOglV0=; fh=FUVbyeoeMCRuVASjKZRlZMOsivR2fvypT++W9fHJd9A=; b=sK4mzTM2kUfIHklunEugQ6w+rmSYDWhawWZFi7L86dxEwv2vhoiWy4M/3PlzxMCkwc wtrPB/I26nm7n6TrVl/dOfSpl8tLG7VWehAiunhGvt7CJiOfbcAZwB5CxlwLCEBy1y/0 DPrhtNGlRnEIPAd1m/oH1QCMSvTdjo5zEafs0dWyrdWJTEYmfOYr3OfkDw1T65ysDYs1 6mdDdthjhvu13PhTyBH2lnkn4E33nAhWVxklYZoQp4uU3RJ/3n+hM3z9thDejJIr+Usk t9rNxkzf29+8XV2jYwVqzfxHTEtMgGO8NwRQxit40puEOuZhVrO9lQE6F3vFwy/sjPvT gIOg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-3299-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-3299-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=pobox.com Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id b6-20020a6541c6000000b0056fbf85c743si17120847pgq.790.2023.12.18.02.11.53 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Dec 2023 02:11:53 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-3299-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-3299-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-3299-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=pobox.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 1E063282CA7 for ; Mon, 18 Dec 2023 10:11:53 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id EB14813AE6; Mon, 18 Dec 2023 10:11:47 +0000 (UTC) X-Original-To: linux-kernel@vger.kernel.org Received: from relay05.pair.com (relay05.pair.com [216.92.24.67]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 11DB813AC9 for ; Mon, 18 Dec 2023 10:11:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=pobox.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=pobox.com Received: from iguana.lan (99-122-168-208.lightspeed.irvnca.sbcglobal.net [99.122.168.208]) by relay05.pair.com (Postfix) with ESMTP id 9F4FE1A23FC; Mon, 18 Dec 2023 05:11:44 -0500 (EST) Date: Mon, 18 Dec 2023 02:11:42 -0800 From: Adam Goldman To: Takashi Sakamoto Cc: linux1394-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH 8/8] firewire: core: change modalias of unit device with backward incompatibility Message-ID: References: <20231217103012.41273-1-o-takashi@sakamocchi.jp> <20231217103012.41273-10-o-takashi@sakamocchi.jp> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231217103012.41273-10-o-takashi@sakamocchi.jp> Hi, On Sun, Dec 17, 2023 at 07:30:12PM +0900, Takashi Sakamoto wrote: > + vendor_directory = search_directory(root_directory, CSR_DIRECTORY | CSR_VENDOR); Setting the CSR_DIRECTORY bit here is extraneous since search_directory() also sets it. -- Adam