Received: by 2002:ac8:6d01:0:b0:423:7e07:f8e4 with SMTP id o1csp6634123qtt; Mon, 18 Dec 2023 02:12:07 -0800 (PST) X-Google-Smtp-Source: AGHT+IEQX+xOr28FuWzFRJmTf1yYbeIQ4E0RgcNhSXHei5F1Pwi33SDEt/n3xGxHwq/IbfsxKXME X-Received: by 2002:a17:907:2723:b0:a1f:8149:558c with SMTP id d3-20020a170907272300b00a1f8149558cmr14633556ejl.30.1702894327577; Mon, 18 Dec 2023 02:12:07 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702894327; cv=none; d=google.com; s=arc-20160816; b=NkK5OzCfd5aMX6c8rXZAYmu19mLuBybqR5U0EqQDavDiEb1tsf1yilhZEI9Fd+B3Vg f3nL6e974QphGl1DgFleW7ipfaq0lVn9BrE2h69thGOSPwxXEWft1zxIhb69gtVTOfVQ Xl0YwUW7YtSlP0wpIXjnkkTPMdGT3m8RkyEri55gS8QkFuaW8twyjefxXzhx6dCrdPlJ 45YdNlNGLxY6rlxFzJgY4AT2s8TYV3Ov2Oi5N4hX5NBWZmmu6tcMxfOx7iAiG2ICgrKJ ms/mN77WymKueMt7IlN5orrZadE/X4xsnd8J5JkLHqFePpdKjojdLqIIlKp8L16PQ4ai JuXQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:list-unsubscribe:list-subscribe :list-id:precedence:dkim-signature; bh=dWVfo0YlGfjE9aDQP2Ly3L2JCb3LpM/ev0NxuURn88c=; fh=vKBpxrhVMa3V4xspBXgRJV0JST2js4Mf3lMI3E6LaAY=; b=WbC2XIC3ifeIeJbKwfJ/Kmr7uSZ49ZE4V8FN797O4jV+qOVo5vCYHVTAGQMStOiAT/ YO6vGsFJQjdvA3U6hDdNKI+Xb3FdPA7pxO+AEOTuIpaDWE22jNECgmWzXXtoclvQxRjG Rct5T1r4ozVJhKvgMCz/P4SY0VQ+HJLbKyi0ZrtM9yVRhSibOjvqE2vA7zcJFKV4c0/L /VYa9rpmHwfSfttIO5WxvESnb2SVBFcWctcUP1boR0ywqEDsKTnRidYYnEsLPx32v7tJ lXt9F9ik8wYrtG0XB9hmxwaI4FoDZ66O/TpECBZhREKfAII+HIcBSowmKa8DYKN2VyLt X4Iw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=F3LKPLYv; spf=pass (google.com: domain of linux-kernel+bounces-3300-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-3300-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id y10-20020a170906070a00b00a1dbda310ecsi9987589ejb.536.2023.12.18.02.12.07 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Dec 2023 02:12:07 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-3300-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=F3LKPLYv; spf=pass (google.com: domain of linux-kernel+bounces-3300-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-3300-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 31ED21F22E93 for ; Mon, 18 Dec 2023 10:12:07 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id E9893134C6; Mon, 18 Dec 2023 10:11:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="F3LKPLYv" X-Original-To: linux-kernel@vger.kernel.org Received: from mail-pf1-f179.google.com (mail-pf1-f179.google.com [209.85.210.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 034F21401E; Mon, 18 Dec 2023 10:11:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pf1-f179.google.com with SMTP id d2e1a72fcca58-6ce4fe4ed18so229386b3a.1; Mon, 18 Dec 2023 02:11:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1702894308; x=1703499108; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=dWVfo0YlGfjE9aDQP2Ly3L2JCb3LpM/ev0NxuURn88c=; b=F3LKPLYvNsLSAjIf6bFDgT6NL3mkYVdoBJbBT+NiKbKsAsVtYrkOBlV1ILSr1/E7id xiof1aVi2r/nLkEzcXNfo7hn10Ila9xFVz0II22HbAtO6JlOfgK97jpoxdrEXnNQe7aS wTo0EKxwFuEdW9p/iRz4zXwNUmuLS82R7qFflyoZGAj3ZjIMcnad4VQ0bE9NPMwp4jpl nRH9HG/UcspH+K4Jo3J09e2r/H05GjTLnXSTBFIwHg1GaWi1O6PTwFrO1DZAvXeG4n2d bukxkON91yf9GzBLhhDiOg1njwJTXWJzsC0z93LkdFgnNJWOii6WtnongFkTxzb6SPX+ 8ToA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702894308; x=1703499108; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=dWVfo0YlGfjE9aDQP2Ly3L2JCb3LpM/ev0NxuURn88c=; b=Kx1mHtQ2NIolQwwplgHk2PE1k79VESWZKaSY926pIggIB6B0YUQIsSidtOZGYLSIaO /ajobdXOPdhdhruB88AtiHZKrkiSm+MBkb2+Mxe+x46gCkw4aNLUDECP82IhQ7V8GIqZ xm/M9+qaNyVtAgKnm2IyyuSuK0GqaXyvvbp1qaVq/xDt9UJyNgjGYoaw1XmGTztl5Sr4 aacVolva/rbtXZYpdXwctmP052N6uq0HLOkGF/7og0TERYC+bVMeSAAKjh6MNN0sFsCR F1nmTtQVOHbdt7/zeVg3M+rR6w/JOzC5iR/xo9SQAdx9cTg4m9blULGR9RETb/6sbuOD KptA== X-Gm-Message-State: AOJu0YyeSrTVMwDBO2JYLhUt0fSyK/IKyFFSfj49tWxwNXMFxYNVgYSE 9fKUun4PX/NlXaV1fXVUs4uQH0Q88VUeZimeqVCkiff+ X-Received: by 2002:a05:6a00:2288:b0:6cd:e3ef:ce54 with SMTP id f8-20020a056a00228800b006cde3efce54mr34661547pfe.0.1702894308316; Mon, 18 Dec 2023 02:11:48 -0800 (PST) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <1702891731-3417-1-git-send-email-shengjiu.wang@nxp.com> In-Reply-To: <1702891731-3417-1-git-send-email-shengjiu.wang@nxp.com> From: Fabio Estevam Date: Mon, 18 Dec 2023 07:11:36 -0300 Message-ID: Subject: Re: [PATCH] ASoC: fsl_sai: Fix channel swap issue on i.MX8MP To: Shengjiu Wang Cc: shengjiu.wang@gmail.com, Xiubo.Lee@gmail.com, nicoleotsuka@gmail.com, lgirdwood@gmail.com, broonie@kernel.org, perex@perex.cz, tiwai@suse.com, alsa-devel@alsa-project.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, linux-sound@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, Dec 18, 2023 at 7:10=E2=80=AFAM Shengjiu Wang wrote: > > When flag mclk_with_tere and mclk_direction_output enabled, > The SAI transmitter or receiver will be enabled in very early > stage, that if FSL_SAI_xMR is set by previous case, > for example previous case is one channel, current case is > two channels, then current case started with wrong xMR in > the beginning, then channel swap happen. > > The patch is to clear xMR in hw_free() to avoid such > channel swap issue. > > Signed-off-by: Shengjiu Wang Fixes tag, please.