Received-SPF: pass (google.com: domain of linux-kernel+bounces-3331-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
From: Justin Lai <justinlai0215@realtek.com>
To: Jakub Kicinski <kuba@kernel.org>
CC: "davem@davemloft.net" <davem@davemloft.net>,
        "edumazet@google.com"
	<edumazet@google.com>,
        "pabeni@redhat.com" <pabeni@redhat.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "andrew@lunn.ch"
	<andrew@lunn.ch>, Ping-Ke Shih <pkshih@realtek.com>,
        Larry Chiu
	<larry.chiu@realtek.com>
Subject: RE: [PATCH net-next v14 06/13] rtase: Implement .ndo_start_xmit function
Thread-Topic: [PATCH net-next v14 06/13] rtase: Implement .ndo_start_xmit
 function
Thread-Index: AQHaKbubsEorOK9BY0aC7C+4Ofl+iLClijsAgAlZf5A=
Date: Mon, 18 Dec 2023 10:27:42 +0000
Message-ID: <1855bbf9885e4cae86aa32d401296b1e@realtek.com>
References: <20231208094733.1671296-1-justinlai0215@realtek.com>
	<20231208094733.1671296-7-justinlai0215@realtek.com>
 <20231212113212.1cfb9e19@kernel.org>
In-Reply-To: <20231212113212.1cfb9e19@kernel.org>
Accept-Language: zh-TW, en-US
Content-Language: zh-TW
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
MIME-Version: 1.0

>=20
> > +             if (ring->cur_idx !=3D dirty_tx)
> > +                     rtase_w8(tp, RTASE_TPPOLL, BIT(ring->index));
> > +     }
> > +
> > +     return workdone;
> > +}
>=20
> > +     /* multiqueues */
> > +     q_idx =3D skb_get_queue_mapping(skb);
> > +     ring =3D &tp->tx_ring[q_idx];
>=20
> As Paolo pointed out elsewhere you seem to only support one queue.
> Remove this indirection, please, and always use queue 0, otherwise it's a=
 bit
> confusing.

Hi Jakub,

This device supports Multi-Queue.