Received-SPF: pass (google.com: domain of linux-kernel+bounces-3366-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Message-ID: <76af02dd-1f16-41ad-86c7-3202146d0085@intel.com>
Date: Mon, 18 Dec 2023 16:18:29 +0530
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 03/50] x86/lib/cache-smp.c: fix missing include
To: Kent Overstreet <kent.overstreet@linux.dev>,
	<linux-kernel@vger.kernel.org>, <linux-mm@kvack.org>,
	<linux-fsdevel@vger.kernel.org>
CC: <tglx@linutronix.de>, <x86@kernel.org>, <tj@kernel.org>,
	<peterz@infradead.org>, <mathieu.desnoyers@efficios.com>,
	<paulmck@kernel.org>, <keescook@chromium.org>, <dave.hansen@linux.intel.com>,
	<mingo@redhat.com>, <will@kernel.org>, <longman@redhat.com>,
	<boqun.feng@gmail.com>, <brauner@kernel.org>
References: <20231216024834.3510073-1-kent.overstreet@linux.dev>
 <20231216024834.3510073-4-kent.overstreet@linux.dev>
Content-Language: en-US
From: Sohil Mehta <sohil.mehta@intel.com>
In-Reply-To: <20231216024834.3510073-4-kent.overstreet@linux.dev>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SXBkenQyNkhlY3BEWWNJRWVlVWF4aFBBY1c1eTRGZ2RPM0lpMnhocWhLeG82?=
 =?utf-8?B?RnJ4OXRGTk8yZi9wVTFJdFVvcVhLdTQyZHErbnZ6TWthNUNPRUtBUG5nQ1Nv?=
 =?utf-8?B?K2ZNbUpSS0ZxVUh3WDNScjdsbklPajhUUUFwR1JaM0VabUpzOHQ3c1BqeXFz?=
 =?utf-8?B?dklPSDBXeURvVGFVdDk4eGxFMjdLSDd4WCs4Z3AyeEZNU1d4Q251QTlxN0dl?=
 =?utf-8?B?Y3hvNXRVb0pXUFB6WW9xZVJDekQrQzhYOWVrZHMzZ3dwdEo2L1N5VGdpMm5P?=
 =?utf-8?B?WE1vSy9wK0pCUlloVVlYMHlDd3NBRXpZZVlpK0wzTVhUUWhyNFp4VlhvM25O?=
 =?utf-8?B?TkN1UjVBRnBSRWw5amtzb1UrM0xkVitsTHVVZTRRblF2ajAreGhGZFFzQlZB?=
 =?utf-8?B?N09oZVQrNUNGM0lwNWx2RFRhZ0xLOGFBZXNEelpkajUrN3NFeWFlNWYzOGRD?=
 =?utf-8?B?eVhzSU9BZDhuVVF4cGZ5SWlqRmFET1A0TUUrQzNEY1lqOUl1TFowUVYwR3lH?=
 =?utf-8?B?d3pjNGFvMkdaTW9BNFRlV0ZMZFMvRE1UWm52Z05XMkYzRFF6UVFlNkc3Nzkx?=
 =?utf-8?B?OWdNQmZkOUtiOUxlYXh0eUlYUGRNM2wwUWYrMy9iU3JJNjZqSEpLTmx6WGhM?=
 =?utf-8?B?dDErLzlocTNOYmlMSm93K25oUTBqWTF6VkJzNG1SNW1VSDl4NmZSYzlzL1pM?=
 =?utf-8?B?ZC8vMEFDSlJ5NG9uOTVMSUlrWmoweTU1bHJmV2ppZjZIaGdhTzVxTURuMmR0?=
 =?utf-8?B?WVh3TFhpMjVOTXN0RVMyVVNWdDJDRDZKNUtKMU1qLzg0M2tLRHl3V25Vb1lS?=
 =?utf-8?B?aEFZU3N4dURYYkw2c3J4dURIby9SL09ETSt6ZFdQdkl3TFdoR0NwY3Fxa0J2?=
 =?utf-8?B?eTN1Q3BtZ3dIa2VlekpQMlk4TGUwZy9jZkpUZHdFVXB3STV0bEZvK2NEcUlp?=
 =?utf-8?B?Wmc2dWNMa01udi9HSU50d1lvb0UzRG1JbnVveDlMcm83ZTd6QnpvNTVNeWlG?=
 =?utf-8?B?VDdocWQxQmFqSUsyUlBicDZJM1N2aXZvWFlhYTdhSUd6UU1ZbjhTZzBNSmhP?=
 =?utf-8?B?M1pXTnZJQ3RnLzExTDF1elNXRy9iRE5PeUdpZGxMSkpLWFpwbWVwRkM3MlB6?=
 =?utf-8?B?OTExMXh6SHFPQ1pkOU9KaTcvM1hqak9Uc3R3M21lUGw3QzU0VmQ2aVFXZ0p2?=
 =?utf-8?B?QlN0TUx0ZmpXa28rQ0NONStGbkxOVFFsWVg0T2xrUGx2ZHdtdlV5L2c0RzZD?=
 =?utf-8?B?U1Y1QUplNEx3Vksvdzd3SHRLQktVazAyOVQzQk5BUnY4VmFtTjBnbGZLUWxi?=
 =?utf-8?B?T0VkZm5RRytpTzM4V25YK29OUlkxZERVajU3V0VxSkJlaEJaMDBNVmR5NzAz?=
 =?utf-8?B?V2pYajYyV1hUcFlNZVlXZ0xwbmRaTUkwSmZQcElJeHpmeUZ3b2FaTkg5RXN5?=
 =?utf-8?B?V01iVFhnS2U4RzA0ZXU4bDg5eXFPUU5mWUNYRzFFczFmQmpQNnRSdDVhdE82?=
 =?utf-8?B?SDl2b0c2a1RaRVlsdzJWRzcweW4zTzBtdm5VMWZTelhGMXFVcjNqMTJLbW9j?=
 =?utf-8?B?MjFNWjFyZDFPWENHdXpacFBhYkRWTkt4ZUdjYTM5QnRsQnVMb2xua2xCQ3Mr?=
 =?utf-8?B?SnNLaHJCOVFJY3JMSTZVVWNDdjhNNGhsNDcwcysvSDc0Q2duZzJsTlI4anVZ?=
 =?utf-8?B?TDRSUmx1Sy9FZlZ0UVc2Sm52VFNTS3NMeldIVGxJcHQ5NkVpc1kwSVBZM3No?=
 =?utf-8?B?UmtiLzV2WEI1WVZrRkhLd3F3OFhkNlF2REVRNlM5WVJwV1cxVDg2ZHFlQjN3?=
 =?utf-8?B?THcyMTR2VldNbXhBNm5MVmJvNC9VeTFFNmlVbmFSSXlJK3dnUGxKZW9yMTQv?=
 =?utf-8?B?WXVXZTU4aC9XaTQrVXlSYy9aRzVkUXlKN052YldwRWRvc0lCR2lnWXBhRjcv?=
 =?utf-8?B?VjV0YndxNjl2eDJ1QUtZRzdEaTB1cmtLRVZYd3JRMXFNVzBLRmFPM0IxT29q?=
 =?utf-8?B?b3FqeldEWitWaUpGL0NzQTJrZEpwVmtydDYzN0UyWEphb3ZSTFFBNm5kK3cz?=
 =?utf-8?B?MXZmN2FhRWUvQlQzaEZ2QmNQSHVscVYybzJvb21senhFV2JvSmIyR2FSVDR3?=
 =?utf-8?Q?xEBQVELeEWp1xWeYxfa5feZPm?=
X-MS-Exchange-CrossTenant-Network-Message-Id: df94fd37-906d-48cd-ca04-08dbffb6e7cb
X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3320.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Dec 2023 10:48:44.8752
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: qWeiZ4aPMY1Y19fRNLabU3I/clMVfJXFcqPIj8UbO3rbylnX555MUXt35th7rGbz6H755PBY+1oI33+VuIE9bg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5080
X-OriginatorOrg: intel.com

> diff --git a/arch/x86/lib/cache-smp.c b/arch/x86/lib/cache-smp.c
> index 7c48ff4ae8d1..7af743bd3b13 100644
> --- a/arch/x86/lib/cache-smp.c
> +++ b/arch/x86/lib/cache-smp.c
> @@ -1,4 +1,5 @@
>  // SPDX-License-Identifier: GPL-2.0
> +#include <asm/paravirt.h>
>  #include <linux/smp.h>
>  #include <linux/export.h>
>  

I believe the norm is to have the linux/ includes first, followed by the
the asm/ ones. Shouldn't this case be the same?

Sohil