Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756874AbXLGR6k (ORCPT ); Fri, 7 Dec 2007 12:58:40 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753483AbXLGR6b (ORCPT ); Fri, 7 Dec 2007 12:58:31 -0500 Received: from mx3.mail.elte.hu ([157.181.1.138]:32899 "EHLO mx3.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753468AbXLGR6b (ORCPT ); Fri, 7 Dec 2007 12:58:31 -0500 Date: Fri, 7 Dec 2007 18:57:54 +0100 From: Ingo Molnar To: Guillaume Chazarain Cc: stefano.brivio@polimi.it, Nick Piggin , Robert Love , linux-kernel@vger.kernel.org, Dave Jones , "Rafael J. Wysocki" , Michael Buesch , Thomas Gleixner , Andrew Morton , Len Brown Subject: Re: [PATCH] scheduler: fix x86 regression in native_sched_clock Message-ID: <20071207175754.GB19173@elte.hu> References: <20071207021952.6f0ac922@morte> <20071207084559.GA11162@elte.hu> <200712072213.06530.nickpiggin@yahoo.com.au> <20071207122310.maqkoxlb4gsg4ggc@webmail.polimi.it> <20071207122516.GA25115@elte.hu> <20071207123509.GA28676@elte.hu> <20071207124034.GA30052@elte.hu> <20071207145418.GA22277@elte.hu> <20071207174649.39c9198d@inria.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20071207174649.39c9198d@inria.fr> User-Agent: Mutt/1.5.17 (2007-11-01) X-ELTE-VirusStatus: clean X-ELTE-SpamScore: -1.5 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-1.5 required=5.9 tests=BAYES_00 autolearn=no SpamAssassin version=3.2.3 -1.5 BAYES_00 BODY: Bayesian spam probability is 0 to 1% [score: 0.0000] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1027 Lines: 34 * Guillaume Chazarain wrote: > Le Fri, 7 Dec 2007 15:54:18 +0100, > Ingo Molnar a ?crit : > > > This is a version that > > is supposed fix all known aspects of TSC and frequency-change > > weirdnesses. > > Tested it with frequency changes, the clock is as smooth as I like it > :-) ok, great :-) > The only remaining sched_clock user in need of conversion seems to be > lockdep. yeah - for CONFIG_LOCKSTAT - but that needs to be done even more carefully, due to rq->lock being lockdep-checked. We can perhaps try a lock-less cpu_clock() version - other CPUs are not supposed to update rq->clock. > Great work. thanks. I do get the impression that most of this can/should wait until 2.6.25. The patches look quite dangerous. Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/