Received: by 2002:a05:7412:a9a3:b0:f9:327e:43ab with SMTP id o35csp15229rdh; Mon, 18 Dec 2023 03:00:14 -0800 (PST) X-Google-Smtp-Source: AGHT+IFEkVSQsNRjiwfDmsSRMTvqgkQkf6OWHc3MQvPsO2dMu8oEzNwebJgvFG3ulYXERh1V/DkK X-Received: by 2002:a05:6102:2921:b0:466:917b:b223 with SMTP id cz33-20020a056102292100b00466917bb223mr486143vsb.41.1702897214002; Mon, 18 Dec 2023 03:00:14 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702897213; cv=none; d=google.com; s=arc-20160816; b=xTHTk1L9WYUmm9KOge0Kqwxg6/eehimy5etGL33TPN0L9SZqvUl6C+KovvtrPoUup4 oOOFsQ1wB/IrO5B8+dJ6Bg8WrsxNOxcLE2tdTCeUYCacQzDnoHwnwdMa7MBw4unF2mK2 sho6amwX+0SSEtoLyleu/llYXamxfKlCSvyVW3Y13O1X7bxX1dJiDBTaJCAIg/OS+pCV EPBx+PTLoznaw6fIXD5zmh6ta375AnK8T2xRepaxyWmZtLKJEdN8w8Pv8ghZ/ATASd57 ECqS7kvMPC845Y1INyMHKw37z9IsgCZvRfAONlynHmp4m85p/lztfj2IX4fFaQi3MzaP pbLQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:feedback-id:dkim-signature:dkim-signature; bh=DhJuFyKeI5xdQm8Pua0VofKhhE351ohYbJVIzzUIEi4=; fh=67agiwVtf7SL9Lp1G76jZqUs0lhG35+jEmQRT9JnphI=; b=yxOjmbAucYKeJ1k9h5XY19iEa01N7NMHz+aIuXG/qxlFcItTMvsHzWgJe66GcKwcuE /LmU6qE1/MxJIqZUdPnLTOA8+8YVcDf38CgIrST7w2xoaOg9RfXC078qM3vPLEnPTJz+ iBb99TkccT1/AtlySOb0bw5A4liBLbf6I+CH9C3bcy1XM/BF4XQFd1WgG3UrFQWdxkUq cvIK3KsEPmAsLD3HTX2mNNqRFoxi8PuDFhjq5s7wmr/C7Gxdw3sN+jOt2yMQF2LNf3W4 3ykVKnAvLj85bVqBmuohW4RGyrYcDZ9aijWQNLVGYbFIM+t4kzW+bx3ATnQnhBwWJwdN z8bQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kroah.com header.s=fm2 header.b=WilBptd2; dkim=pass header.i=@messagingengine.com header.s=fm2 header.b=wriK9Y1+; spf=pass (google.com: domain of linux-kernel+bounces-3395-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-3395-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kroah.com Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id e14-20020ac8598e000000b0042520be2b47si21725048qte.160.2023.12.18.03.00.13 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Dec 2023 03:00:13 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-3395-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kroah.com header.s=fm2 header.b=WilBptd2; dkim=pass header.i=@messagingengine.com header.s=fm2 header.b=wriK9Y1+; spf=pass (google.com: domain of linux-kernel+bounces-3395-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-3395-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kroah.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id A99581C22AB3 for ; Mon, 18 Dec 2023 11:00:13 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id A179A18E0D; Mon, 18 Dec 2023 11:00:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kroah.com header.i=@kroah.com header.b="WilBptd2"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="wriK9Y1+" X-Original-To: linux-kernel@vger.kernel.org Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A88381946B; Mon, 18 Dec 2023 11:00:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=kroah.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kroah.com Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id AAB6D5C0109; Mon, 18 Dec 2023 06:00:00 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Mon, 18 Dec 2023 06:00:00 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kroah.com; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm2; t=1702897200; x=1702983600; bh=DhJuFyKeI5 xdQm8Pua0VofKhhE351ohYbJVIzzUIEi4=; b=WilBptd2KY3wYkNR+dcC6HKzBF M/iKlNojY1Zo3MIWsFUsnce6zS9ZGLHV0SgfmaDAMoOk8CnRuvgw+rO2Kgg5GZ5k D454PbdqLMmv+zwXodoO+q9xWo2QFpKpLyjjK1SbWAa3SfY8POAJdjEthSQ0Afs3 a2UtpzIuoHNk+9TTMUaH4D+kXAKZYQgCcM0DTf6Olu6ynvaKd7/xxELRGf82nlur ny0ITnHI+9UDAdtR5Shhj8iIxVZ4B9bNB9ck3p9lEkqf9x8IW5rYNfR4aPP2cWsD EEc3qgu7r1DNra1s0fKMXnNUMupZmsv7C2BahG+WgeRbNyyfsNzaLJRwIqig== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1702897200; x=1702983600; bh=DhJuFyKeI5xdQm8Pua0VofKhhE35 1ohYbJVIzzUIEi4=; b=wriK9Y1+6TAMgj5hg6iJd4T4zEJfpkCsRvlp+3Zwnd7c ds9bJ2Qpy2QOn8AGgkWK7E5B7ZHkuUgoyoIR1Gym1baSNbuRa41VmVYF4jPNn+up EbG8WBPHR6e9NlNOIKSzgB4aH90iYz8fHvnCOLEhinq/VNfMFykUZtlLHyNOWaOI DhmqnJr8+Q/JetrYRD/0Nuvr4Uo2thl52CVrkYUpcfHCHTQPawon0uZYLRLjF1/g akUM5d3iqKhVa6laulVol+P0GOsfSA8ze0p+29+BL4iYoPefzQGZElEEGVitJXtD vQ07ezINcpdTHNqPkaCOYs/MvK4pOqy0Wq5I5IrinA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrvddtkedgvdduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkfhggtggujgesthdtredttddtvdenucfhrhhomhepifhrvghg ucfmjfcuoehgrhgvgheskhhrohgrhhdrtghomheqnecuggftrfgrthhtvghrnhepheegvd evvdeljeeugfdtudduhfekledtiefhveejkeejuefhtdeufefhgfehkeetnecuvehluhhs thgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepghhrvghgsehkrhhorg hhrdgtohhm X-ME-Proxy: Feedback-ID: i787e41f1:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 18 Dec 2023 05:59:59 -0500 (EST) Date: Mon, 18 Dec 2023 11:59:58 +0100 From: Greg KH To: Sidhartha Kumar Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, maple-tree@lists.infradead.org, akpm@linux-foundation.org, willy@infradead.org, liam.howlett@oracle.com, zhangpeng.00@bytedance.com, stable@vger.kernel.org Subject: Re: [PATCH 6.6.y] maple_tree: do not preallocate nodes for slot stores Message-ID: <2023121847-cope-surviving-26bf@gregkh> References: <20231212195255.219624-1-sidhartha.kumar@oracle.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231212195255.219624-1-sidhartha.kumar@oracle.com> On Tue, Dec 12, 2023 at 11:52:55AM -0800, Sidhartha Kumar wrote: > mas_preallocate() defaults to requesting 1 node for preallocation and then > ,depending on the type of store, will update the request variable. There > isn't a check for a slot store type, so slot stores are preallocating the > default 1 node. Slot stores do not require any additional nodes, so add a > check for the slot store case that will bypass node_count_gfp(). Update > the tests to reflect that slot stores do not require allocations. > > User visible effects of this bug include increased memory usage from the > unneeded node that was allocated. > > Fixes: 0b8bb544b1a7 ("maple_tree: update mas_preallocate() testing") > Cc: # 6.6+ > Signed-off-by: Sidhartha Kumar > --- > This is a modified backport as the patch to fix this in upstream does not > apply to 6.6 because the node_end field was moved from the ma_wr_state to > the ma_state after 6.6. What is the git commit id of this change in Linus's tree? thanks, greg k-h