Received-SPF: pass (google.com: domain of linux-kernel+bounces-3420-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
From: Suman Ghosh <sumang@marvell.com>
To: Zhang Yiqun <zhangyiqun@phytium.com.cn>,
        "steffen.klassert@secunet.com"
	<steffen.klassert@secunet.com>,
        "herbert@gondor.apana.org.au"
	<herbert@gondor.apana.org.au>,
        "davem@davemloft.net" <davem@davemloft.net>,
        "edumazet@google.com" <edumazet@google.com>,
        "kuba@kernel.org"
	<kuba@kernel.org>,
        "pabeni@redhat.com" <pabeni@redhat.com>
CC: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [EXT] [PATCH] xfrm: Use spin_lock_bh() in xfrm_input()
Thread-Topic: [EXT] [PATCH] xfrm: Use spin_lock_bh() in xfrm_input()
Thread-Index: AQHaMY5OGX60TXM4g0KDmJHKima4ObCu4lEA
Date: Mon, 18 Dec 2023 11:17:25 +0000
Message-ID: 
 <SJ0PR18MB5216378D11AB3E5DEE8D32C3DB90A@SJ0PR18MB5216.namprd18.prod.outlook.com>
References: <20231218084252.7644-1-zhangyiqun@phytium.com.cn>
In-Reply-To: <20231218084252.7644-1-zhangyiqun@phytium.com.cn>
Accept-Language: en-IN, en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?us-ascii?Q?YIJODQsw4elSzl7Lhvvs1G123pJ2VpWojWq0CzJGxsZJ26NPsPj3EqvAiweK?=
 =?us-ascii?Q?fVVXdTJLI5Bm+lOCs+VfjxEyKAoBsLAUGPhBE//2iWEv4NfQD0M+uImio6oR?=
 =?us-ascii?Q?fuuW3Y3kSZuHscuT5QIrncsRO+USX7yr+LNJuXLkCVNBFEZn8K0gUbVVWMOO?=
 =?us-ascii?Q?C+245xSqJ0D5YKbAdRxuJSZ1lixbklmW1TxVQX++5cdpgoRiZrLT9FnPronV?=
 =?us-ascii?Q?vMcoYNwLDNPvTWJbbtSxqYZfkg3lj3b6msGCGQu8AF0IcVET59AS3M3fidgF?=
 =?us-ascii?Q?0UC+k/VYWdlgDj1k8RYRiuB2uy5X4K14zwPqWK2KzjQx0JJ3qdZldMMVsekY?=
 =?us-ascii?Q?G/alMeZZFUPki8gpyW1tWAQtrjarZFOaKplejjehs+GcE3rVNc+QVhhlxnU4?=
 =?us-ascii?Q?zHqfL1lqFYK2Lrn+z8AnQcrmU8amJj9SP9Jrt+UsrEP/A8pcNc/UBXRXunh/?=
 =?us-ascii?Q?6ZC/pVu8NAfvAHVXfaDVs4+v14cMomJhrmtL0ors/MEzSxB5xGQl7loWCBL9?=
 =?us-ascii?Q?Sd+nFXqkAgquiIuT9Z4RvOGWsJUmJ36saNgDnKnqbVVVhVR5AdBB8PJLeleE?=
 =?us-ascii?Q?1TG9SpN9qXbMjmFOdH8hyzYlElblb3mSxOfZDRCa8jTyo9idQPAvfWedXDvq?=
 =?us-ascii?Q?zi2J/5BPR5x2AhdxVAveuCvyZd5+DSk1r78QuuQbUl8YWZAoiI3YvHttR1Lv?=
 =?us-ascii?Q?JWMxgjdX1ssCA3m+1qGBVXPFtXrOhureOfkWbcOxVJdXck0WbAQt6LMRL+Qi?=
 =?us-ascii?Q?IGxuxYlhjA0/YUcOv/i+ZjkFIsG+f2MmRHNNog0ppfnHqBymezg7YgUCqjEr?=
 =?us-ascii?Q?mReI7tBj0vKudmH+xKzeKGdQFGBu3uY3J8AHA6WTEFyklxw6Is4nxy7QxGop?=
 =?us-ascii?Q?220qTEESPehlE5M5Ho5OE7u/R+Wf0bJ3I73TqCScIRZIOuNmPoHX19p9vmi+?=
 =?us-ascii?Q?qqtaI1hd6FWUmRz4jJrhHPeut7uVwEaQFxNTX1AFU8PIiRuVq9MhE92CIOle?=
 =?us-ascii?Q?YqGUaDJDoFnv7+ElCGp42WUex2q/Kw/3koh7Z1x/k4ON+JxOvJihPBQ3MoOb?=
 =?us-ascii?Q?/utZ8ugwM+P7Jh/TAbBv5cpWej23pz1wpbvucbJC0ndGT06RAKLY/aTNwiMv?=
 =?us-ascii?Q?9mC6Gz5mCRHIqw1yuSKbWT3j7e6ibl1u0Z0VK/bIfwGOfi9wc6Dz6sNOzAtW?=
 =?us-ascii?Q?Usr85KHqdKpOC6Bom3V+Ho/Cy0yO6a4Jc9oN8B8RDU5O6+ReI+60GXIAqHN0?=
 =?us-ascii?Q?KLXmQVBq0L7LtL39xRH35/9XQAtQLNyzeroaQJ9KcqyK07wq/cG2w+smPd2R?=
 =?us-ascii?Q?aOArUKheTk0r5Zy0YU34wsdSIMeCSM/gofk4UuNN/ETXWy2mqCctf9D5E5LP?=
 =?us-ascii?Q?NNX2c6eUEPwebVo74Lf3NuY4Qzs7L4vDWa24xfCkUCWXhg6w32JoZaEK7qAE?=
 =?us-ascii?Q?Elslkg0VWBgbvQdJ+nAtK5xsX65imFV8d2B70EFL8oA+pzHwIeUNsQsAuxSg?=
 =?us-ascii?Q?MXEW3b12pvifr7N7mtiFDx18p5ggTxOV2lrUEcnH8cdlxowYtdBUZSdu0jVw?=
 =?us-ascii?Q?fHcFo+bIWlp2DmWGTG4cMz5NgkPaiTidgQENj/A9?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: marvell.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR18MB5216.namprd18.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 99c968f9-ae33-48f5-b345-08dbffbaea13
X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Dec 2023 11:17:25.8915
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: f+fWd0TybfhKKqlDlb0GWKPalpGwoloAISH3TUUPqlp/nXQZGE1SI3fMAUcLHrFQpnTQurrQGjC3kTE6pr4jvA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR18MB4536
X-Proofpoint-ORIG-GUID: bQ8NY7SLHMFnlW6CVPrEpP2EYBoLaf0k
X-Proofpoint-GUID: bQ8NY7SLHMFnlW6CVPrEpP2EYBoLaf0k
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.997,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2023-12-09_02,2023-12-07_01,2023-05-22_02

>diff --git a/net/xfrm/xfrm_input.c b/net/xfrm/xfrm_input.c index
>bd4ce21d76d7..f4cd46d73b1e 100644
>--- a/net/xfrm/xfrm_input.c
>+++ b/net/xfrm/xfrm_input.c
>@@ -581,7 +581,7 @@ int xfrm_input(struct sk_buff *skb, int nexthdr,
>__be32 spi, int encap_type)
> 		}
>
> lock:
>-		spin_lock(&x->lock);
>+		spin_lock_bh(&x->lock);
[Suman] Hi Zhang,
There is a spin_lock() after label "resume". Don't we need to change it the=
re?
>