Received-SPF: pass (google.com: domain of linux-kernel+bounces-3427-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Message-ID: <1ef3dad2-5f55-40e5-bba7-3c71d71c12e4@kontron.de>
Date: Mon, 18 Dec 2023 12:24:23 +0100
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] drm: bridge: samsung-dsim: Don't use FORCE_STOP_STATE
Content-Language: en-US, de-DE
To: Michael Walle <mwalle@kernel.org>, Inki Dae <inki.dae@samsung.com>,
 Jagan Teki <jagan@amarulasolutions.com>,
 Marek Szyprowski <m.szyprowski@samsung.com>,
 Andrzej Hajda <andrzej.hajda@intel.com>,
 Neil Armstrong <neil.armstrong@linaro.org>, Robert Foss <rfoss@kernel.org>,
 Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
 Jonas Karlman <jonas@kwiboo.se>, Jernej Skrabec <jernej.skrabec@gmail.com>,
 David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
 Tim Harvey <tharvey@gateworks.com>,
 Alexander Stein <alexander.stein@ew.tq-group.com>
Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
References: <20231113164344.1612602-1-mwalle@kernel.org>
 <631fe35a2a3b00781231e4f3f5094fae@kernel.org>
From: Frieder Schrempf <frieder.schrempf@kontron.de>
In-Reply-To: <631fe35a2a3b00781231e4f3f5094fae@kernel.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?KzVoWHFKVkFocTFJSjVETTM0TWM5Ykt6WVJMRXZ6MXpLNjhUZksyQ1NVTzRJ?=
 =?utf-8?B?cTN3R2NtNEd6c0JjcU9xVWhOb3lMTnJOVDhoUkVkdXNkUDE3N2FpZmx3RWdX?=
 =?utf-8?B?VUZyQnUzcTdzQmN5QTR6QURCODNUZis5cjlpOHhqZW9wUWtJTnordFBiVzNo?=
 =?utf-8?B?THRMQkRWMzh2cWROcjZsYVZZUEVzeTZtWjRoQ0UxOWJURmkvRmJ3VWNsNDJX?=
 =?utf-8?B?N3RIczNYT3FVK3A4Q2hxT2xydWxjU1BlTVZFbVI3cU53Y2xXZUJ1QTlOWTB0?=
 =?utf-8?B?WWtqZ1cvZUJOUlBvQkhkZkpiQVZKcFVnUFVNVVVQVkNPWDZhSUZ6a1dlTGcy?=
 =?utf-8?B?NkFObnplYnB0dzhRelNWQzZ4R0l0amNOZHBDeWZSYmZzQUUxQ1BLbm5xaEZG?=
 =?utf-8?B?TXA2US9HQU1xbjY2cHp4UzUzd1NpaGhRMlpjekhJRHdRL0c0aExDdVNhTktj?=
 =?utf-8?B?WXA0K2hmSUdYWWtXcFJtakw5QmlXVVR5REhjYlBkRC9jNjdwWXV0ZHgzSGdE?=
 =?utf-8?B?dkhUTjVsZmNsOWhyV3laZHJhdEVKYVV1akFmOUh4Y09QWGJDMmZFWkJxMW9F?=
 =?utf-8?B?UUJ2eEtjYmZMVUtqSUYwd2xlSE5zZzA2VGxudFhGUkRWcWRXdnFNbW1yR1hW?=
 =?utf-8?B?SEwva0dnRFVoREVQaThTMHE2VXZBTDQ0ZmUwcDk3NisxR3BMU01WQnYvU200?=
 =?utf-8?B?Z2NRNGJzeTZSUWVtYktLUzVpQ0JvYUJkM2Nza0VlRURkREpmZkhMS202T1dC?=
 =?utf-8?B?OE9YVE5UK256VWZ4aW1nTUx5MGZOZExkOU9hKzM1N2k0UlBEdHduUlRxMjVR?=
 =?utf-8?B?MnZsUGw3L09QN2R3TXltVlFyd2sxZFE5ejZTd3h0MEZEV0Z2a3NMbEprcEJx?=
 =?utf-8?B?ZStaWDRNZVVMdGdzeDdXTTczeWFzUnRmSElGNHUxUXNxSWpkY2JPUVhSRHJY?=
 =?utf-8?B?bVArUHJKTkhMZEVEMWhiNUV4Wk5nR3JjUkozMjE0VytFNWxoaHNqZ3RYUWtR?=
 =?utf-8?B?OHFib0huZ3h0ZExWQ3pFSHpta0tRQVVrN1Nqb3B3RjRmMW9JeTBOSmc0SEFz?=
 =?utf-8?B?TU5KelJraHlyRTE1TkV1TGhwR0wrUWhSS0F0SFFhbEd6MDBtY1Iwd3h1NGw5?=
 =?utf-8?B?Qis2emhpVnNNWXhyQy9vM2hXMTFpejIyN1Y4NjlJUytyQlpId29hdk52Z1pk?=
 =?utf-8?B?d0Z4S21kWjlHZit4S3E4US9ZUEsxWXlwUnFieDNyeDhBMWs1RkhxQWpiNlhT?=
 =?utf-8?B?aHRjNUdUMytiNmNDYUNsVklyZVlYMThUeVFoZ3FEaGJiVEVyYXhFdzFibmwz?=
 =?utf-8?B?L3JTd3NkcUJ1MlVGT2lyN0NQN0w2TGFsVzVnSjhNV3crZ0JvaVUxOCtLOGw0?=
 =?utf-8?B?cm9xTVl2R1IvQ0lkNjBmajlieUZoRDZjTFNKSGNlZ1R1VFM4QVZpOWdNcmg4?=
 =?utf-8?B?YWFOdTgvcFBBMGhkVThRa29qb1BkTmZVMWpQSUZrRnVyMnRkYjhkYnBEQ1pq?=
 =?utf-8?B?eElDQmhSdm15TFhBTmFGNFBRRlEvKzBOSkthUXI5bDFTN1VoTlh0Q3BuZndp?=
 =?utf-8?B?S0dyUktEYytydFhCUmdXd0hoTHdWaUlpUUlySGdSaldPOWVzQ2hCU3A1YnN2?=
 =?utf-8?B?bnpsR0FHYzdKcFkyVU1vSm1MNDhaaG9HNTYrSWZBd3J6SkU5TU9kNDE4Uyt3?=
 =?utf-8?B?SGpXaTc5eWl0TlRPUmdWcTR4bVVUbmwxTFNiMzJURUhpTEdTNFg4VnFCUnN2?=
 =?utf-8?B?ODRsOFJtUW1CUHJySklRQnI0Y2ZUNWVZRkFyQ29XRDUrWU9qZ1puaW5FUjUr?=
 =?utf-8?B?cDhnSzlLQk80R1lwUFBEUUdtYWlFUnZZM3BTSVcvYU02dTBnRmpJNGhiRlhs?=
 =?utf-8?B?aFNKSklwQmI1bnpzdFJvRjQ5aEwyNGZjMm4rL3ZsSnJMZlZycW9BZzZrUG5F?=
 =?utf-8?B?ZzBLUGxld1pqSTRzYTBqWGx4dmVPNXFYekxyOFhIVGdZTlUyakE5STdKT3l2?=
 =?utf-8?B?T04vOFJKbE9hdTM0V0cxREJmQTBhTC9acVM2Qzg2QzZPZk9rWVFZRVp0d0VN?=
 =?utf-8?B?blRMSUNHd3lqYXc1TTFPbTRndkJnajU3d253ekJWVUJyU1huMXBPei9aK3ZQ?=
 =?utf-8?B?eGU4MTVCZzlONXBzREFLR3A2VWtFenI0d0JLbmE2by9MM2QwdWtLbVF2Q1po?=
 =?utf-8?B?QlE9PQ==?=
X-OriginatorOrg: kontron.de
X-MS-Exchange-CrossTenant-Network-Message-Id: c50733e2-8de7-4189-4c08-08dbffbbe41e
X-MS-Exchange-CrossTenant-AuthSource: PA4PR10MB5681.EURPRD10.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Dec 2023 11:24:25.5556
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 8c9d3c97-3fd9-41c8-a2b1-646f3942daf1
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 50bXvKGvcDxKxdoofanUCdG6BEdanFKRrJcM3sHxONxp60f3MCU1KJ5AF6JClmiQ7tppWk/llvrHiAeOtHw71g1+VdbjtrM0rLzyMl//gpY=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS2PR10MB7346

On 01.12.23 10:04, Michael Walle wrote:
>> The FORCE_STOP_STATE bit is unsuitable to force the DSI link into LP-11
>> mode. It seems the bridge internally queues DSI packets and when the
>> FORCE_STOP_STATE bit is cleared, they are sent in close succession
>> without any useful timing (this also means that the DSI lanes won't go
>> into LP-11 mode). The length of this gibberish varies between 1ms and
>> 5ms. This sometimes breaks an attached bridge (TI SN65DSI84 in this
>> case). In our case, the bridge will fail in about 1 per 500 reboots.
>>
>> The FORCE_STOP_STATE handling was introduced to have the DSI lanes in
>> LP-11 state during the .pre_enable phase. But as it turns out, none of
>> this is needed at all. Between samsung_dsim_init() and
>> samsung_dsim_set_display_enable() the lanes are already in LP-11 mode.
>> The code as it was before commit 20c827683de0 ("drm: bridge:
>> samsung-dsim: Fix init during host transfer") and 0c14d3130654 ("drm:
>> bridge: samsung-dsim: Fix i.MX8M enable flow to meet spec") was correct
>> in this regard.
>>
>> This patch basically reverts both commits. It was tested on an i.MX8M
>> SoC with an SN65DSI84 bridge. The signals were probed and the DSI
>> packets were decoded during initialization and link start-up. After this
>> patch the first DSI packet on the link is a VSYNC packet and the timing
>> is correct.
>>
>> Command mode between .pre_enable and .enable was also briefly tested by
>> a quick hack. There was no DSI link partner which would have responded,
>> but it was made sure the DSI packet was send on the link. As a side
>> note, the command mode seems to just work in HS mode. I couldn't find
>> that the bridge will handle commands in LP mode.
>>
>> Fixes: 20c827683de0 ("drm: bridge: samsung-dsim: Fix init during host
>> transfer")
>> Fixes: 0c14d3130654 ("drm: bridge: samsung-dsim: Fix i.MX8M enable
>> flow to meet spec")
>> Signed-off-by: Michael Walle <mwalle@kernel.org>
>> ---
>> Let me know wether this should be two commits each reverting one, but
>> both
>> commits appeared first in kernel 6.5.
> 
> Are there any news?

Inki, are you picking this up? Or if not, who will?