Received-SPF: pass (google.com: domain of linux-kernel+bounces-3572-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Mon, 18 Dec 2023 20:36:38 +0800
From: Wang Jinchao <wangjinchao@xfusion.com>
To: Sohil Mehta <sohil.mehta@intel.com>
CC: Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>, Dave Hansen <dave.hansen@linux.intel.com>,
	<x86@kernel.org>, "H. Peter Anvin" <hpa@zytor.com>,
	<linux-kernel@vger.kernel.org>, <stone.xulei@xfusion.com>
Subject: Re: [PATCH] x86/setup: remove duplicated including
Message-ID: <ZYA81v/l4eWUxZKk@fedora>
References: <202312151755+0800-wangjinchao@xfusion.com>
 <16028dde-261a-4403-8165-f0a8b70f13fa@intel.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <16028dde-261a-4403-8165-f0a8b70f13fa@intel.com>

On Mon, Dec 18, 2023 at 05:27:46PM +0530, Sohil Mehta wrote:
> How about rewording the above to?
> 
> "x86/setup: Remove duplicate header includes"
> 
> On 12/15/2023 3:25 PM, Wang Jinchao wrote:
> > rm the second #include <asm/efi.h> in setup.c
> 
> > rm the second #include <asm/spec-ctrl.h> in smpboot.c
> 
> Actually, these two lines are evident from the diff itself. You can
> remove both of them. If you really want to have some text in the commit
> message you can probably just say:
> 
> efi.h and spec-ctrl.h are included twice. Remove the duplicate entries.
> 
> > 
> > Signed-off-by: Wang Jinchao <wangjinchao@xfusion.com>
> > ---
> >  arch/x86/kernel/setup.c   | 1 -
> >  arch/x86/kernel/smpboot.c | 1 -
> >  2 files changed, 2 deletions(-)
> > 
> 
> With the above changes, please feel free to add:
> 
> Reviewed-by: Sohil Mehta <sohil.mehta@intel.com>
> 
Thanks for the suggestion, which has been applied to the v2 patch.