Received: by 2002:a05:7412:a9a3:b0:f9:327e:43ab with SMTP id o35csp64189rdh; Mon, 18 Dec 2023 04:37:59 -0800 (PST) X-Google-Smtp-Source: AGHT+IHxmX76pctXwZdXMkvl2PBlt13H5AbJBp/LJf1D7e0I159riQye/0QHzu7BG817kG6ukcpT X-Received: by 2002:a17:902:dad2:b0:1d3:cc53:ea79 with SMTP id q18-20020a170902dad200b001d3cc53ea79mr394838plx.41.1702903079012; Mon, 18 Dec 2023 04:37:59 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702903078; cv=none; d=google.com; s=arc-20160816; b=ko5+rC9wyFSm142r9U4ayb6OUQ2+4xRG4usUWoA2GJb2UwKKnuqN+DMH3hSEK3UsXM s2dLycWFfJ8Rbj3KyDJDXOiwZZoWFH74swsnVHKt7/l6YwWFRsTk24mPTRCdCyxYE0yH MMerJbgX4b0zZZkwv7DAXO8jbZt5ScmSm1xYTikS6oWKzznuGO/iYLoikjtRb9Lib/Kv vnSsYHSimNaQVs1hoLJ6Px6BBhn5xLhiMD47OoIo41ug2M3thXoxaD1/C6pV39GEQJVD tqLjsdKV4vha2NbPEbL5b3/V8i3dXhix1+X2sRbshiLnc2jsH+E0AxWbE+Im9ZnVzls5 m6+w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id:dkim-signature; bh=4T70cxyfYBrIT00YJPhgzlaa8IjVEwywR+fjzgz6hnA=; fh=pug+WK5cgVvlw/GSkU4VcKwsW/1wdN8AJU//kbaZW8Y=; b=OUwf2DM/OXLUjerL5BG/ptl0Le6yef037QeI+tRhUUY8rW97Y4A78PIjIQC5UL4ycU H5i3zVfX4KRfKMFFc6D9nzRXNJgSeUHiXKLXZOxjtbi13POWm1uh4KjjFj0yUDIC6V8C 0YmhRcUHjZd6V58f6oGXu32Y9cxqsLNMd0iJ4lx3pfTb5idsekcJBo9YyPG6thXCDI8+ MWGC5SSOTgIN2dlq8KURqVEP5YqTbA1O9SEm4ctZD/HCUQ502CQyglVYxc0m1nR740zX EAZBpQf8ejQXEZX/4RdHHD0Ebf24Mdbv+kVKDscIHXdSj3pSB8OQJYP7apXAQByobnpl jwVg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=d+WsUw26; spf=pass (google.com: domain of linux-kernel+bounces-3573-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-3573-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id t1-20020a170902e84100b001d3ca5ce643si639295plg.138.2023.12.18.04.37.58 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Dec 2023 04:37:58 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-3573-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=d+WsUw26; spf=pass (google.com: domain of linux-kernel+bounces-3573-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-3573-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id A99F4281EAD for ; Mon, 18 Dec 2023 12:37:58 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id D257E7D618; Mon, 18 Dec 2023 12:37:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="d+WsUw26" X-Original-To: linux-kernel@vger.kernel.org Received: from mail-ed1-f44.google.com (mail-ed1-f44.google.com [209.85.208.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AB2E5199B2; Mon, 18 Dec 2023 12:37:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-ed1-f44.google.com with SMTP id 4fb4d7f45d1cf-54c70c70952so3583674a12.3; Mon, 18 Dec 2023 04:37:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1702903069; x=1703507869; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=4T70cxyfYBrIT00YJPhgzlaa8IjVEwywR+fjzgz6hnA=; b=d+WsUw26xqkHKaiBguVwyakO18u4pNIyivaUn4vPAkTgnV3VHrU/TzZkhhLXKryz5B QKA62sKxk8ybWtFJsoivwGoKCGuqpIxFqF/t20BfQTpzSD4qXisPMSmVYfOTffEzyV5/ 2WcfKSdjCS2EeImOc+BvnuwymaPF534SN1UjrfDLdQNz8flWV6J0AKn3kvbCvkkYqOxj yvs6aRAg+qPcF3AXZz1LBoKsDZIAjftM0Clh9K0Gdj54UoCeB9wm+mIkWBxg6oi7qDyQ CEtov8gE/TT2FMUKMFpFJmDSORmUYRzhWf6BjszseDQ8aV0oYxZzSPFomec08Q6UM3kv L7Dg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702903069; x=1703507869; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=4T70cxyfYBrIT00YJPhgzlaa8IjVEwywR+fjzgz6hnA=; b=uzLYtHW2rGrINSXilYRawfNVG5X4yZ6DGO7F3/MiSHYeNlI92PGLAXumimgFATluza fgjY157hJKjg7YYa0sjOBN6ijnTO37zDNbn1AX/VYXBgXRiPbh2ZJztJovhv0562axRj w/am0QlRgqEGqrrEgjRGVULtAlW/K6NMudu/FqgT/x3QS8x+3HQyinENVD8pilPQTpfn DoMclCMyPZbN/5P1s5zI8IIer4PhTA2Tvi3K5pRo1ggQVD2HS08td0NpI2j7ep0Xlo2C 8ZDkZDstv248rIcBdDFzg1K9aV6NPrx8yKxHHf9c8y216paZ+YQH8iHAXvsvCilSIr0D jZkg== X-Gm-Message-State: AOJu0Yyvot2WmGUX2mx0tIzPH/Z6rNjlO2hFSAGnxxkOkwtG60Y2H3kE r+rrYrApB5WXxM2XyE3orw== X-Received: by 2002:a50:c346:0:b0:553:7898:e6ac with SMTP id q6-20020a50c346000000b005537898e6acmr137799edb.126.1702903068671; Mon, 18 Dec 2023 04:37:48 -0800 (PST) Received: from ?IPV6:2a02:810b:f40:4300:4847:f8df:b40e:3aa8? ([2a02:810b:f40:4300:4847:f8df:b40e:3aa8]) by smtp.gmail.com with ESMTPSA id dh6-20020a0564021d2600b0055338547cc1sm1409895edb.70.2023.12.18.04.37.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 18 Dec 2023 04:37:48 -0800 (PST) Message-ID: Date: Mon, 18 Dec 2023 13:37:47 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 20/27] drm/rockchip: inno_hdmi: Correctly setup HDMI quantization range Content-Language: en-US, de-DE To: Maxime Ripard Cc: Sandy Huang , =?UTF-8?Q?Heiko_St=C3=BCbner?= , Andy Yan , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Maarten Lankhorst , Thomas Zimmermann , David Airlie , Daniel Vetter , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org References: <20231216162639.125215-1-knaerzche@gmail.com> <20231216162639.125215-21-knaerzche@gmail.com> From: Alex Bee In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Am 18.12.23 um 10:05 schrieb Maxime Ripard: > On Sat, Dec 16, 2023 at 05:26:31PM +0100, Alex Bee wrote: >> @@ -431,6 +452,9 @@ static int inno_hdmi_setup(struct inno_hdmi *hdmi, >> else >> inno_conn_state->colorimetry = HDMI_COLORIMETRY_ITU_709; >> >> + inno_conn_state->rgb_limited_range = >> + drm_default_rgb_quant_range(mode) == HDMI_QUANTIZATION_RANGE_LIMITED; >> + >> /* Mute video and audio output */ >> hdmi_modb(hdmi, HDMI_AV_MUTE, m_AUDIO_MUTE | m_VIDEO_BLACK, >> v_AUDIO_MUTE(1) | v_VIDEO_MUTE(1)); > This needs to be done at atomic_check time: the expectation is that by > the time you commit the state, everything is prepared for it. OK. I guess that also applies to the other members of inno_hdmi_connector_state (former hdmi_data) and was wrong all the time. Alex > Maxime