Received: by 2002:a05:7412:a9a3:b0:f9:327e:43ab with SMTP id o35csp82130rdh; Mon, 18 Dec 2023 05:08:54 -0800 (PST) X-Google-Smtp-Source: AGHT+IHthtX+YidMsLBlbh+69uFz2pOoI5QTJQRQRBmQqWXOTxptl0ddBHrp8UJjg7/uMEXyBlaw X-Received: by 2002:a17:90b:1e42:b0:28b:6ebf:8998 with SMTP id pi2-20020a17090b1e4200b0028b6ebf8998mr2663942pjb.11.1702904934039; Mon, 18 Dec 2023 05:08:54 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702904934; cv=none; d=google.com; s=arc-20160816; b=m3p9TY7t3A4ljHzYXdhSiYLzzHwopXgrEyV3yuwk3Jffa7jIClFeb8dDYx44LF1ICO zx1LbaTCh8x5cnMwG0Gy9KBsfkGobZxZIDB+mPfRvI4bupAfehJTj6qgX4GElvJbtV7o Yr9teKaOhOsLkUOtsDi9S3XEVg42K20MaV7jaK/Ow5zOT65mbyyuwkSjGWCPNhhN3c44 REL4OqZ5kS2w05U+eBM3c4h/p4OymAiTVgbFh/mgefvLtvUYtVFrXDvnBRRWCUfpu2P2 s8rKQJ7AM45i42OV1dmkKrLSP7k8IF6zG1dydHT+Y4fsVp9GWERPVwV5qGrNPBXg92qC 0Z1Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:mail-followup-to :message-id:subject:cc:to:from:date:feedback-id:dkim-signature :dkim-signature; bh=Sp32Kv+FtgVwjl+FmjJanWnjE4SgTjgXVYd4enIlghQ=; fh=7tCR2OY+o2tzhFP0PdsbGzYyG96Vzu3n/lYSO2E5INs=; b=m3R2M8xu3HPgNTXTkUJ9LPEAeT64qF2AKJycvnqyFxmkSaBNnzNCrvVYbWLUEtiG8m NlEOpuCMDWbitA6ezWxz5YwY6aeIlAa8/8TA8qRrFml05PIvGMJPDDaPPrL4wq6DsD01 dYiZBAm6foF0jQiBPkwjE7ytWIW+EdQd2RpQkn1we5sRyWbw2fRx8KO5dNl8q4vQSh2w MnVRzIhN3/qL8WROLCgpbFI8raji9RJ8DKI+uQCG2fE+kAONELNSY1HADN28Tp/fJT4I SiybcntX7ND+TbKBUFcJEjDnkGo+jGUmXWbPMvAdlnxV05w0NTjO4xSpKaEHyEz8f/jL 3p4A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@sakamocchi.jp header.s=fm2 header.b=lBwINm1S; dkim=pass header.i=@messagingengine.com header.s=fm2 header.b=fwDsPFb7; spf=pass (google.com: domain of linux-kernel+bounces-3656-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-3656-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=sakamocchi.jp Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id e10-20020a17090a804a00b0028b5016a273si3976473pjw.100.2023.12.18.05.08.53 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Dec 2023 05:08:54 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-3656-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@sakamocchi.jp header.s=fm2 header.b=lBwINm1S; dkim=pass header.i=@messagingengine.com header.s=fm2 header.b=fwDsPFb7; spf=pass (google.com: domain of linux-kernel+bounces-3656-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-3656-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=sakamocchi.jp Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 36545286084 for ; Mon, 18 Dec 2023 13:00:29 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 7A8A480584; Mon, 18 Dec 2023 12:46:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=sakamocchi.jp header.i=@sakamocchi.jp header.b="lBwINm1S"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="fwDsPFb7" X-Original-To: linux-kernel@vger.kernel.org Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 80F3D7CCF6 for ; Mon, 18 Dec 2023 12:46:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sakamocchi.jp Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sakamocchi.jp Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 88C1D5C00CA; Mon, 18 Dec 2023 07:46:50 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Mon, 18 Dec 2023 07:46:50 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sakamocchi.jp; h=cc:cc:content-type:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to; s=fm2; t=1702903610; x= 1702990010; bh=Sp32Kv+FtgVwjl+FmjJanWnjE4SgTjgXVYd4enIlghQ=; b=l BwINm1SPVYf/2xehUq8cI0Pan7ZFfVrVl5KaBov3E6F/LkWo/G5T9O50Ul1rfunP 6nhpVjRtgtG9VpcDQGtN3gLpWDpOo7eksvJOI1D1nPsKB2jjJLKwxvYtVw/y76FI XVvZOI24OHF1RaLM1DWklgsB112WcueZdeBgioXFc11j2MqPG/JIdTim5OZZV0eI wi9Mih4vKgWhHLB9R3T5nrFEPTpPB9Qcqu+BMEsFJ4BB5gCfh/gMvG1pZbEXXttw vQsxlOF6rqA4KpfSpmSP6OC3CWR+GxfUZPgLF3kRprijmT7oZ0wIOkBOWSGc6KYw XAdCN/n+q6W6L7Hy1a/RQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1702903610; x=1702990010; bh=Sp32Kv+FtgVwjl+FmjJanWnjE4Sg TjgXVYd4enIlghQ=; b=fwDsPFb78Bn/QPrqT3e7IO5SbbQjzk438KtHqj4uNRfL 3NTsLKZZgd1kwYS7XEc9/dri3Ld74Rv6HDG3GpDuqB/4TRszTi9siDD6tNyfjty/ sGhbKvpsU59g1KdKPeZKQJzSCMLxUxksFvd0HprRohdikV1rZmgAIjb2gVaTEeUc K4FRFZ/eXygez6Nxmy/LfS2chHllkJX5kB1HWl/H66kVzbYRyauDYsglacQtHi4e yKwKZvMTvdU6z09F9VXEggwTQvAVmOi+23PvEjCIk8YvSX0u9WnWA3JQTniFmKcN HHQrKYgiKyfqgUkQbRbP7A1lmH2bZusb+9oRHli8uQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrvddtkedggeduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkfhggtggujgesthdtredttddtvdenucfhrhhomhepvfgrkhgr shhhihcuufgrkhgrmhhothhouceoohdqthgrkhgrshhhihesshgrkhgrmhhotggthhhird hjpheqnecuggftrfgrthhtvghrnhephefhhfettefgkedvieeuffevveeufedtlefhjeei ieetvdelfedtgfefuedukeeunecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpe hmrghilhhfrhhomhepohdqthgrkhgrshhhihesshgrkhgrmhhotggthhhirdhjph X-ME-Proxy: Feedback-ID: ie8e14432:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 18 Dec 2023 07:46:49 -0500 (EST) Date: Mon, 18 Dec 2023 21:46:45 +0900 From: Takashi Sakamoto To: Adam Goldman Cc: linux1394-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH 8/8] firewire: core: change modalias of unit device with backward incompatibility Message-ID: <20231218124645.GA46034@workstation.local> Mail-Followup-To: Adam Goldman , linux1394-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org References: <20231217103012.41273-1-o-takashi@sakamocchi.jp> <20231217103012.41273-10-o-takashi@sakamocchi.jp> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Hi, On Mon, Dec 18, 2023 at 02:11:42AM -0800, Adam Goldman wrote: > Hi, > > On Sun, Dec 17, 2023 at 07:30:12PM +0900, Takashi Sakamoto wrote: > > + vendor_directory = search_directory(root_directory, CSR_DIRECTORY | CSR_VENDOR); > > Setting the CSR_DIRECTORY bit here is extraneous since search_directory() also sets it. Indeed. It is redundant. Thanks Takashi Sakamoto